* [PATCH] gpu: host1x: do not check previously handled gathers
@ 2014-01-07 20:03 ` Erik Faye-Lund
0 siblings, 0 replies; 9+ messages in thread
From: Erik Faye-Lund @ 2014-01-07 20:03 UTC (permalink / raw)
To: linux-tegra
Cc: thierry.reding, tbergstrom, dri-devel, linux-kernel, Erik Faye-Lund
When patching gathers, we don't need to check against
gathers with lower indices than the current one, as
they are guaranteed to already have been handled.
Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
---
Here's a trivial optimization I have been running with for a while.
drivers/gpu/host1x/job.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
index de5ec33..e965805 100644
--- a/drivers/gpu/host1x/job.c
+++ b/drivers/gpu/host1x/job.c
@@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
g->base = job->gather_addr_phys[i];
- for (j = 0; j < job->num_gathers; j++)
+ for (j = i + 1; j < job->num_gathers; j++)
if (job->gathers[j].bo == g->bo)
job->gathers[j].handled = true;
--
1.8.1.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
2014-01-07 20:03 ` Erik Faye-Lund
@ 2014-01-23 17:31 ` Erik Faye-Lund
-1 siblings, 0 replies; 9+ messages in thread
From: Erik Faye-Lund @ 2014-01-23 17:31 UTC (permalink / raw)
To: linux-tegra; +Cc: tbergstrom, linux-kernel, dri-devel
Ping?
On Tue, Jan 7, 2014 at 9:03 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index de5ec33..e965805 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
>
> g->base = job->gather_addr_phys[i];
>
> - for (j = 0; j < job->num_gathers; j++)
> + for (j = i + 1; j < job->num_gathers; j++)
> if (job->gathers[j].bo == g->bo)
> job->gathers[j].handled = true;
>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
@ 2014-01-23 17:31 ` Erik Faye-Lund
0 siblings, 0 replies; 9+ messages in thread
From: Erik Faye-Lund @ 2014-01-23 17:31 UTC (permalink / raw)
To: linux-tegra
Cc: thierry.reding, tbergstrom, dri-devel, linux-kernel, Erik Faye-Lund
Ping?
On Tue, Jan 7, 2014 at 9:03 PM, Erik Faye-Lund <kusmabite@gmail.com> wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index de5ec33..e965805 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
>
> g->base = job->gather_addr_phys[i];
>
> - for (j = 0; j < job->num_gathers; j++)
> + for (j = i + 1; j < job->num_gathers; j++)
> if (job->gathers[j].bo == g->bo)
> job->gathers[j].handled = true;
>
> --
> 1.8.1.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
2014-01-07 20:03 ` Erik Faye-Lund
(?)
(?)
@ 2014-01-30 13:51 ` Terje Bergström
-1 siblings, 0 replies; 9+ messages in thread
From: Terje Bergström @ 2014-01-30 13:51 UTC (permalink / raw)
To: Erik Faye-Lund, linux-tegra; +Cc: thierry.reding, dri-devel, linux-kernel
On 07.01.2014 22:03, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/host1x/job.c b/drivers/gpu/host1x/job.c
> index de5ec33..e965805 100644
> --- a/drivers/gpu/host1x/job.c
> +++ b/drivers/gpu/host1x/job.c
> @@ -534,7 +534,7 @@ int host1x_job_pin(struct host1x_job *job, struct device *dev)
>
> g->base = job->gather_addr_phys[i];
>
> - for (j = 0; j < job->num_gathers; j++)
> + for (j = i + 1; j < job->num_gathers; j++)
> if (job->gathers[j].bo == g->bo)
> job->gathers[j].handled = true;
>
Hi,
Thanks. This looks good logically, and I ran some tests that agree.
Acked-By: Terje Bergstrom <tbergstrom@nvidia.com>
Terje
^ permalink raw reply [flat|nested] 9+ messages in thread
[parent not found: <1389124986-32501-1-git-send-email-kusmabite-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
2014-01-07 20:03 ` Erik Faye-Lund
@ 2014-02-10 13:10 ` Thierry Reding
-1 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2014-02-10 13:10 UTC (permalink / raw)
To: Erik Faye-Lund
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA,
tbergstrom-DDmLM1+adcrQT0dZR+AlfA,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 522 bytes --]
On Tue, Jan 07, 2014 at 09:03:06PM +0100, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
@ 2014-02-10 13:10 ` Thierry Reding
0 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2014-02-10 13:10 UTC (permalink / raw)
To: Erik Faye-Lund; +Cc: linux-tegra, tbergstrom, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Tue, Jan 07, 2014 at 09:03:06PM +0100, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
2014-01-07 20:03 ` Erik Faye-Lund
@ 2014-02-12 10:18 ` Thierry Reding
-1 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2014-02-12 10:18 UTC (permalink / raw)
To: Erik Faye-Lund; +Cc: linux-tegra, tbergstrom, linux-kernel, dri-devel
[-- Attachment #1.1: Type: text/plain, Size: 492 bytes --]
On Tue, Jan 07, 2014 at 09:03:06PM +0100, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thierry
[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] gpu: host1x: do not check previously handled gathers
@ 2014-02-12 10:18 ` Thierry Reding
0 siblings, 0 replies; 9+ messages in thread
From: Thierry Reding @ 2014-02-12 10:18 UTC (permalink / raw)
To: Erik Faye-Lund; +Cc: linux-tegra, tbergstrom, dri-devel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 492 bytes --]
On Tue, Jan 07, 2014 at 09:03:06PM +0100, Erik Faye-Lund wrote:
> When patching gathers, we don't need to check against
> gathers with lower indices than the current one, as
> they are guaranteed to already have been handled.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@gmail.com>
> ---
>
> Here's a trivial optimization I have been running with for a while.
>
> drivers/gpu/host1x/job.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks!
Thierry
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread