All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu
@ 2014-04-19 12:16 Fabio Fantoni
  2014-04-22 13:11 ` Ian Jackson
  2014-05-02 11:41 ` Ian Campbell
  0 siblings, 2 replies; 20+ messages in thread
From: Fabio Fantoni @ 2014-04-19 12:16 UTC (permalink / raw)
  To: xen-devel
  Cc: anthony.perard, Fabio Fantoni, Ian.Jackson, Ian.Campbell,
	Stefano.Stabellini

Reading one qemu-devel post seems that setting video memory of
cirrus vga with upstream qemu is wrong even if not show errors.

Signed-off-by: Fabio Fantoni <fabio.fantoni@m2r.biz>

---

Note:
- when this patch will be accepted upstream should be
  backported also on xen 4.4
- with this qemu parameters seems correct but for further
  confirmation I posted a question about it:
http://lists.xen.org/archives/html/xen-devel/2014-04/msg02606.html
---
 tools/libxl/libxl_dm.c |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
index 8abed7b..90f19b7 100644
--- a/tools/libxl/libxl_dm.c
+++ b/tools/libxl/libxl_dm.c
@@ -508,9 +508,8 @@ static char ** libxl__build_device_model_args_new(libxl__gc *gc,
             flexarray_append_pair(dm_args, "-device", "VGA");
             break;
         case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
-            flexarray_append_pair(dm_args, "-device", "cirrus-vga");
-            flexarray_append_pair(dm_args, "-global",
-                GCSPRINTF("vga.vram_size_mb=%d",
+            flexarray_append_pair(dm_args, "-device",
+                GCSPRINTF("cirrus-vga,vgamem_mb=%d",
                 libxl__sizekb_to_mb(b_info->video_memkb)));
             break;
         case LIBXL_VGA_INTERFACE_TYPE_NONE:
-- 
1.7.9.5

^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2014-05-09 14:48 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-19 12:16 [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu Fabio Fantoni
2014-04-22 13:11 ` Ian Jackson
2014-04-22 13:21   ` Fabio Fantoni
2014-04-24 10:33     ` Fabio Fantoni
2014-05-02  9:11       ` Fabio Fantoni
2014-05-02 11:41 ` Ian Campbell
2014-05-02 19:44   ` Don Slutz
2014-05-02 20:04     ` Fabio Fantoni
2014-05-07 12:20       ` Fabio Fantoni
2014-05-08 10:10         ` Ian Campbell
2014-05-08 10:41           ` Fabio Fantoni
2014-05-08 11:33             ` Ian Campbell
2014-05-08 15:03               ` Fabio Fantoni
2014-05-08 15:19                 ` Ian Campbell
2014-05-09  8:01                   ` Fabio Fantoni
2014-05-09  9:09                     ` Ian Campbell
2014-05-09 14:03                       ` Stefano Stabellini
2014-05-09 14:08                         ` Ian Campbell
2014-05-09 14:24                         ` Fabio Fantoni
2014-05-09 14:48                           ` Fabio Fantoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.