[PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

[PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

[Joonyoung Shim]

Hi,

GEM CMA supports dma_buf but it needs GEM CMA specific functionality for
dma_buf. We can use prime helpers for dma_buf by commit
89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so
this patchset is to replace from using GEM CMA specific functions to
using prime helpers.

Thanks.

Joonyoung Shim (3):
       drm: add mmap function to prime helpers
       drm/cma: add low-level hook functions to use prime helpers
       drm/cma: remove GEM CMA specific dma_buf functionality

  drivers/gpu/drm/drm_gem_cma_helper.c | 291 
+++++------------------------------
  drivers/gpu/drm/drm_prime.c          |   5 +-
  include/drm/drmP.h                   |   2 +
  include/drm/drm_gem_cma_helper.h     |  13 +-
  4 files changed, 56 insertions(+), 255 deletions(-)

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

[Laurent Pinchart]

Hi Joonyoung,

Thank you for the patches. I'll try to review and test them next week.

On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote:
> Hi,
> 
> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for
> dma_buf. We can use prime helpers for dma_buf by commit
> 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so
> this patchset is to replace from using GEM CMA specific functions to
> using prime helpers.
> 
> Thanks.
> 
> Joonyoung Shim (3):
>        drm: add mmap function to prime helpers
>        drm/cma: add low-level hook functions to use prime helpers
>        drm/cma: remove GEM CMA specific dma_buf functionality
> 
>   drivers/gpu/drm/drm_gem_cma_helper.c | 291 ++++---------------------------
>   drivers/gpu/drm/drm_prime.c          |   5 +-
>   include/drm/drmP.h                   |   2 +
>   include/drm/drm_gem_cma_helper.h     |  13 +-
>   4 files changed, 56 insertions(+), 255 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

[Laurent Pinchart]

Hi Joonyoung,

On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote:
> Hi,
> 
> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for
> dma_buf. We can use prime helpers for dma_buf by commit
> 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so
> this patchset is to replace from using GEM CMA specific functions to
> using prime helpers.

Overall this looks good to me, except the that prime helpers don't cache 
mappings, unlike the current implementation in the GEM CMA helpers. Could that 
be fixed in the prime helpers first ?

> Thanks.
> 
> Joonyoung Shim (3):
>        drm: add mmap function to prime helpers
>        drm/cma: add low-level hook functions to use prime helpers
>        drm/cma: remove GEM CMA specific dma_buf functionality
> 
>   drivers/gpu/drm/drm_gem_cma_helper.c | 291 ++++---------------------------
>   drivers/gpu/drm/drm_prime.c          |   5 +-
>   include/drm/drmP.h                   |   2 +
>   include/drm/drm_gem_cma_helper.h     |  13 +-
>   4 files changed, 56 insertions(+), 255 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [PATCH 0/3] drm/cma: use prim helpers instead GEM CMA specific dma_buf functionality

[Joonyoung Shim]

On 06/19/2013 08:02 AM, Laurent Pinchart wrote:
> Hi Joonyoung,
>
> On Wednesday 12 June 2013 22:16:14 Joonyoung Shim wrote:
>> Hi,
>>
>> GEM CMA supports dma_buf but it needs GEM CMA specific functionality for
>> dma_buf. We can use prime helpers for dma_buf by commit
>> 89177644a7b6306e6084a89eab7e290f4bfef397 "drm: add prime helpers", so
>> this patchset is to replace from using GEM CMA specific functions to
>> using prime helpers.
> Overall this looks good to me, except the that prime helpers don't cache
> mappings, unlike the current implementation in the GEM CMA helpers. Could that
> be fixed in the prime helpers first ?

Right, i will update it first.

Thanks.