From: Rajendra Nayak <rnayak@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, tony@atomide.com,
bcousson@baylibre.com, nm@ti.com, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3 2/4] ARM: dts: Add support for DRA72x family of devices
Date: Mon, 28 Apr 2014 11:39:22 +0530 [thread overview]
Message-ID: <535DF092.7000307@ti.com> (raw)
In-Reply-To: <201404241513.54380.arnd@arndb.de>
On Thursday 24 April 2014 06:43 PM, Arnd Bergmann wrote:
> On Thursday 24 April 2014, Rajendra Nayak wrote:
>>
>> -- DRA742
>> - compatible = "ti,dra7xx", "ti,dra7"
>> +- DRA74x
>> + compatible = "ti,dra74", "ti,dra7"
>> +
>> +- DRA72x
>> + compatible = "ti,dra72", "ti,dra7"
>
> Actually, what I meant was that you should list the fill name of the SoC,
> e.g. "ti,dra742", not just "ti,dra74". Leaving out the 'x' is not going
> to prevent this from breaking when you have a new dra745 that is incompatible.
>
> You can always list more strings, e.g.
>
> compatible = "ti,dra745", "ti,dra742", "ti,dra74", "ti,dra7";
>
> if you have a dra745 product that is fully compatible with dra742, but the
> important part here is that the first string must be the full name.
Okay, I will update the device compatibles to something like this..
DRA742
compatible = "ti,dra742", "ti,dra74", "ti,dra7"
DRA722
compatible = "ti,dra722", "ti,dra72", "ti,dra7"
And the evm compatibles as
DRA742 EVM: Software Developement Board for DRA742
compatible = "ti,dra7-evm", "ti,dra742", "ti,dra74", "ti,dra7"
DRA722 EVM: Software Development Board for DRA722
compatible = "ti,dra72-evm", "ti,dra722", "ti,dra72", "ti,dra7"
I was also calling the .dtsi files as dra72x.dtsi and dra74x.dtsi, do you suggest I call
them dra742.dtsi and dra722.dtsi instead? Just that if we end up with a dra745 which is
fully compatible with dra742, as you mentioned above, we would be using a dra742.dtsi for a dra745
device which could be a little confusing.
>
> Arnd
>
WARNING: multiple messages have this Message-ID (diff)
From: rnayak@ti.com (Rajendra Nayak)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/4] ARM: dts: Add support for DRA72x family of devices
Date: Mon, 28 Apr 2014 11:39:22 +0530 [thread overview]
Message-ID: <535DF092.7000307@ti.com> (raw)
In-Reply-To: <201404241513.54380.arnd@arndb.de>
On Thursday 24 April 2014 06:43 PM, Arnd Bergmann wrote:
> On Thursday 24 April 2014, Rajendra Nayak wrote:
>>
>> -- DRA742
>> - compatible = "ti,dra7xx", "ti,dra7"
>> +- DRA74x
>> + compatible = "ti,dra74", "ti,dra7"
>> +
>> +- DRA72x
>> + compatible = "ti,dra72", "ti,dra7"
>
> Actually, what I meant was that you should list the fill name of the SoC,
> e.g. "ti,dra742", not just "ti,dra74". Leaving out the 'x' is not going
> to prevent this from breaking when you have a new dra745 that is incompatible.
>
> You can always list more strings, e.g.
>
> compatible = "ti,dra745", "ti,dra742", "ti,dra74", "ti,dra7";
>
> if you have a dra745 product that is fully compatible with dra742, but the
> important part here is that the first string must be the full name.
Okay, I will update the device compatibles to something like this..
DRA742
compatible = "ti,dra742", "ti,dra74", "ti,dra7"
DRA722
compatible = "ti,dra722", "ti,dra72", "ti,dra7"
And the evm compatibles as
DRA742 EVM: Software Developement Board for DRA742
compatible = "ti,dra7-evm", "ti,dra742", "ti,dra74", "ti,dra7"
DRA722 EVM: Software Development Board for DRA722
compatible = "ti,dra72-evm", "ti,dra722", "ti,dra72", "ti,dra7"
I was also calling the .dtsi files as dra72x.dtsi and dra74x.dtsi, do you suggest I call
them dra742.dtsi and dra722.dtsi instead? Just that if we end up with a dra745 which is
fully compatible with dra742, as you mentioned above, we would be using a dra742.dtsi for a dra745
device which could be a little confusing.
>
> Arnd
>
next prev parent reply other threads:[~2014-04-28 6:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 10:06 [PATCH v3 0/4] ARM: DRA7: Add support for DRA72x devices Rajendra Nayak
2014-04-24 10:06 ` Rajendra Nayak
[not found] ` <1398333987-19454-1-git-send-email-rnayak-l0cyMroinI0@public.gmane.org>
2014-04-24 10:06 ` [PATCH v3 1/4] ARM: dts: dra7-evm: Remove the wrong and undocumented compatible Rajendra Nayak
2014-04-24 10:06 ` Rajendra Nayak
2014-04-24 10:06 ` [PATCH v3 2/4] ARM: dts: Add support for DRA72x family of devices Rajendra Nayak
2014-04-24 10:06 ` Rajendra Nayak
2014-04-24 13:13 ` Arnd Bergmann
2014-04-24 13:13 ` Arnd Bergmann
2014-04-28 6:09 ` Rajendra Nayak [this message]
2014-04-28 6:09 ` Rajendra Nayak
[not found] ` <535DF092.7000307-l0cyMroinI0@public.gmane.org>
2014-04-28 8:50 ` Arnd Bergmann
2014-04-28 8:50 ` Arnd Bergmann
2014-04-28 8:55 ` Rajendra Nayak
2014-04-28 8:55 ` Rajendra Nayak
2014-04-24 10:06 ` [PATCH v3 3/4] ARM: OMAP2+: Add machine entry for dra72x devices Rajendra Nayak
2014-04-24 10:06 ` Rajendra Nayak
2014-04-24 17:09 ` Suman Anna
2014-04-24 17:09 ` Suman Anna
2014-04-28 6:10 ` Rajendra Nayak
2014-04-28 6:10 ` Rajendra Nayak
2014-04-24 10:06 ` [PATCH v3 4/4] ARM: DRA7: Add support for soc_is_dra74x() and soc_is_dra72x() varients Rajendra Nayak
2014-04-24 10:06 ` Rajendra Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=535DF092.7000307@ti.com \
--to=rnayak@ti.com \
--cc=arnd@arndb.de \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.