Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Marek Vasut <marex@denx.de>
Cc: netdev@vger.kernel.org, Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sat, 15 Dec 2018 09:31:54 -0800	[thread overview]
Message-ID: <53643e4a-675a-f5bc-21d6-d0f9b3341f80@gmail.com> (raw)
In-Reply-To: <20181215170153.GA5922@lunn.ch>

Le 12/15/18 à 9:01 AM, Andrew Lunn a écrit :
>> +static struct tja11xx_phy_stats tja11xx_hw_stats[] = {
>> +	{ "phy_symbol_error_count", 20, 0, 0xffff },
>> +	{ "phy_overtemp_error", 21, 1, BIT(1) },
>> +	{ "phy_undervolt_error", 21, 3, BIT(3) },
>> +	{ "phy_polarity_detect", 25, 6, BIT(6) },
>> +	{ "phy_open_detect", 25, 7, BIT(7) },
>> +	{ "phy_short_detect", 25, 8, BIT(8) },
> 
> Hi Marek
> 
> You have a number of one bit counters here, which is pretty unusual.
> The names also don't really suggest they are counters.
> 
> Florian, Heiner, do we want to allow this?

Would it make sense to register HWMON attributes for "overtemp",
"polarity", "undervolt"? The open/short detect sounds like something we
should add once we finally get to the cable diagnostics support within
the netlink version of ethtool.
-- 
Florian