Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver

From: Marek Vasut <marex@denx.de>
To: Heiner Kallweit <hkallweit1@gmail.com>, netdev@vger.kernel.org
Cc: f.fainelli@gmail.com, andrew@lunn.ch
Subject: Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sat, 15 Dec 2018 19:29:30 +0100	[thread overview]
Message-ID: <cf6e09b4-3e77-ebad-7c81-3098dc3e239c@denx.de> (raw)
In-Reply-To: <3cb8b832-b1b8-783e-d1c6-0e1859849775@gmail.com>

On 12/15/2018 07:06 PM, Heiner Kallweit wrote:

[...]

>>> +static int tja11xx_config_init(struct phy_device *phydev)
>>> +{
>>> +	int ret;
>>> +
>>> +	ret = tja11xx_enable_reg_write(phydev);
>>> +	if (ret)
>>> +		return ret;
>>> +
>>> +	phydev->irq = PHY_POLL;
>>> +	phydev->autoneg = AUTONEG_DISABLE;
>>> +	phydev->speed = SPEED_100;
> 
> One more thing: In the data sheet there are SPEED_SELECT bits allowing
> to set also 10MBit and 1GBit mode. Don't you want to support this?

The bits are there, but they have no influence on the actual symbol rate
of the PHY, that's fixed, so the PHY can only too 100/Full. There are
more bits like that, I presume for "compatibility" reason.

Registering HWMON device sounds good.

I'll deal with the rest of the feedback later (~next week).

-- 
Best regards,
Marek Vasut