All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiner Kallweit <hkallweit1@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Marek Vasut <marex@denx.de>,
	netdev@vger.kernel.org, f.fainelli@gmail.com
Subject: Re: [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver
Date: Sat, 15 Dec 2018 21:01:26 +0100	[thread overview]
Message-ID: <cd68af46-ff7c-6271-97f8-7e1ab71bf920@gmail.com> (raw)
In-Reply-To: <20181215195940.GF5922@lunn.ch>

On 15.12.2018 20:59, Andrew Lunn wrote:
>>>> +static int tja11xx_config_init(struct phy_device *phydev)
>>>> +{
>>>> +	int ret;
>>>> +
>>>> +	ret = tja11xx_enable_reg_write(phydev);
>>>> +	if (ret)
>>>> +		return ret;
>>>> +
>>>> +	phydev->irq = PHY_POLL;
>>>> +	phydev->autoneg = AUTONEG_DISABLE;
>>>> +	phydev->speed = SPEED_100;
>>
>> One more thing: In the data sheet there are SPEED_SELECT bits allowing
>> to set also 10MBit and 1GBit mode. Don't you want to support this?
> 
> Hi Heiner
> 
> Did you read footnote 2?
> 
> Speed Select. 00: 10 Mbits; 01: 100Mbit/s, 10: 1000Mbit/s, 11:
> reserved. a write access value other than 01 is ignored.
> 
Uh, missed that. Thanks for the hint.

> So the bits are there, but not really used. It can only do 100Mbit/s.
> 
>    Andrew
> 
> 

  reply	other threads:[~2018-12-15 20:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-14 16:11 [PATCH V2] net: phy: tja11xx: Add TJA11xx PHY driver Marek Vasut
2018-12-15 17:01 ` Andrew Lunn
2018-12-15 17:31   ` Florian Fainelli
2018-12-15 17:40     ` Andrew Lunn
2018-12-15 17:38   ` Heiner Kallweit
2018-12-21 23:22     ` Marek Vasut
2018-12-22 17:24       ` Heiner Kallweit
2018-12-23  9:12         ` Marek Vasut
2018-12-15 18:01 ` Heiner Kallweit
2018-12-15 18:06   ` Heiner Kallweit
2018-12-15 18:29     ` Marek Vasut
2018-12-15 19:59     ` Andrew Lunn
2018-12-15 20:01       ` Heiner Kallweit [this message]
2018-12-21 23:31   ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cd68af46-ff7c-6271-97f8-7e1ab71bf920@gmail.com \
    --to=hkallweit1@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=marex@denx.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.