All of lore.kernel.org
 help / color / mirror / Atom feed
From: micky <micky_ching@realsil.com.cn>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chris Ball <chris@printf.net>, Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	<devel@linuxdriverproject.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Roger <rogerable@realtek.com>, Wei WANG <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req"
Date: Thu, 8 May 2014 13:54:18 +0800	[thread overview]
Message-ID: <536B1C0A.2050001@realsil.com.cn> (raw)
In-Reply-To: <CAPDyKFqSdvjJrsbDeX1KbjQtOjfoAwC0xz3y7Rm-BsD0T8tmxg@mail.gmail.com>

Hi Lee

Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: 
add support for pre_reqand post_req"
if need for 3.15 fix.

Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
> On 29 April 2014 03:54,<micky_ching@realsil.com.cn>  wrote:
>> >From: Micky Ching<micky_ching@realsil.com.cn>
>> >
>> >This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
>> >
>> >commit <mmc: rtsx: add support for pre_req and post_req> did use
>> >mutex_unlock() in tasklet, but mutex_unlock() can't used in
>> >tasklet(atomic context). The driver need use mutex to avoid concurrency,
>> >so we can't use tasklet here, the patch need to be removed.
>> >
>> >The spinlock host->lock and pcr->lock may deadlock, one way to solve the
>> >deadlock is remove host->lock in sd_isr_done_transfer(), but if using
>> >workqueue the we can avoid using the spinlock and also avoid the problem.
>> >
>> >Signed-off-by: Micky Ching<micky_ching@realsil.com.cn>
> Acked-by: Ulf Hansson<ulf.hansson@linaro.org>
>


WARNING: multiple messages have this Message-ID (diff)
From: micky <micky_ching@realsil.com.cn>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-mmc <linux-mmc@vger.kernel.org>,
	Chris Ball <chris@printf.net>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Wei WANG <wei_wang@realsil.com.cn>, Roger <rogerable@realtek.com>,
	devel@linuxdriverproject.org, Lee Jones <lee.jones@linaro.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req"
Date: Thu, 8 May 2014 13:54:18 +0800	[thread overview]
Message-ID: <536B1C0A.2050001@realsil.com.cn> (raw)
In-Reply-To: <CAPDyKFqSdvjJrsbDeX1KbjQtOjfoAwC0xz3y7Rm-BsD0T8tmxg@mail.gmail.com>

Hi Lee

Sorry for previous email, only [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: 
add support for pre_reqand post_req"
if need for 3.15 fix.

Best Regards.
micky.
On 04/29/2014 03:36 PM, Ulf Hansson wrote:
> On 29 April 2014 03:54,<micky_ching@realsil.com.cn>  wrote:
>> >From: Micky Ching<micky_ching@realsil.com.cn>
>> >
>> >This reverts commit c42deffd5b53c9e583d83c7964854ede2f12410d.
>> >
>> >commit <mmc: rtsx: add support for pre_req and post_req> did use
>> >mutex_unlock() in tasklet, but mutex_unlock() can't used in
>> >tasklet(atomic context). The driver need use mutex to avoid concurrency,
>> >so we can't use tasklet here, the patch need to be removed.
>> >
>> >The spinlock host->lock and pcr->lock may deadlock, one way to solve the
>> >deadlock is remove host->lock in sd_isr_done_transfer(), but if using
>> >workqueue the we can avoid using the spinlock and also avoid the problem.
>> >
>> >Signed-off-by: Micky Ching<micky_ching@realsil.com.cn>
> Acked-by: Ulf Hansson<ulf.hansson@linaro.org>
>

  parent reply	other threads:[~2014-05-08  5:50 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-29  1:54 [PATCH 0/2] mmc: rtsx: revert support for mmc async request micky_ching
2014-04-29  1:54 ` micky_ching
2014-04-29  1:54 ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handle and remove smatch warnings" micky_ching
2014-04-29  1:54   ` micky_ching
2014-04-29  7:30   ` Ulf Hansson
2014-05-08  5:49     ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify error handleandremove " micky
2014-05-08  5:49       ` micky
2014-05-08  7:55       ` Lee Jones
2014-05-08  8:22         ` Ulf Hansson
2014-05-09  1:09           ` [PATCH 1/2] mmc: rtsx: Revert "mmc: rtsx: modify errorhandleandremovesmatch warnings" micky
2014-05-09  1:09             ` micky
2014-04-29  1:54 ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_req and post_req" micky_ching
2014-04-29  1:54   ` micky_ching
2014-04-29  7:36   ` Ulf Hansson
2014-05-05  9:31     ` Ulf Hansson
2014-05-08  7:53       ` Lee Jones
2014-05-08  5:54     ` micky [this message]
2014-05-08  5:54       ` [PATCH 2/2] mmc: rtsx: Revert "mmc: rtsx: add support for pre_reqandpost_req" micky
2014-04-29  8:02 ` [PATCH 0/2] mmc: rtsx: revert support for mmc async request Lee Jones
2014-04-30  1:32   ` micky
2014-04-30  1:32     ` micky
2014-04-29  9:45 ` [PATCH] mmc: rtsx: usb backend needs LED support Arnd Bergmann
2014-04-29 11:05   ` Ulf Hansson
2014-04-29 11:05     ` Ulf Hansson
2014-04-29 12:46     ` Arnd Bergmann
     [not found]     ` <201404300228.s3U2S7WA026782@rtits1.realtek.com>
2014-04-30  3:34       ` Roger
2014-04-30  3:34         ` Roger
2014-04-30  7:00         ` Arnd Bergmann
2014-04-30  7:00           ` Arnd Bergmann
2014-04-30  8:19         ` Ulf Hansson
2014-04-30  8:19           ` Ulf Hansson
2014-05-08  8:08           ` Roger
2014-05-08  8:08             ` Roger
2014-05-08  8:25             ` Arnd Bergmann
2014-05-08  8:29             ` Lee Jones
2014-05-08  8:29               ` Lee Jones
2014-05-08  8:29             ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=536B1C0A.2050001@realsil.com.cn \
    --to=micky_ching@realsil.com.cn \
    --cc=chris@printf.net \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=rogerable@realtek.com \
    --cc=sameo@linux.intel.com \
    --cc=ulf.hansson@linaro.org \
    --cc=wei_wang@realsil.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.