[PATCH 0/4] clocksource: remove unnecessary OOM messages

[PATCH 0/4] clocksource: remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().

Jingoo Han (4):
      clocksource: em_sti: remove unnecessary OOM messages
      clocksource: sh_cmt: remove unnecessary OOM messages
      clocksource: sh_mtu2: remove unnecessary OOM messages
      clocksource: sh_tmu: remove unnecessary OOM messages

---
 drivers/clocksource/em_sti.c  |    4 +---
 drivers/clocksource/sh_cmt.c  |    4 +---
 drivers/clocksource/sh_mtu2.c |    4 +---
 drivers/clocksource/sh_tmu.c  |    4 +---
 4 files changed, 4 insertions(+), 12 deletions(-)

[PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/clocksource/em_sti.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
index 9d17083..d0a7bd6 100644
--- a/drivers/clocksource/em_sti.c
+++ b/drivers/clocksource/em_sti.c
@@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
 	int irq;
 
 	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
-	if (p == NULL) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
+	if (p == NULL)
 		return -ENOMEM;
-	}
 
 	p->pdev = pdev;
 	platform_set_drvdata(pdev, p);
-- 
1.7.10.4

Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Daniel Lezcano]

On 04/29/2014 10:26 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.

Are you sure the MM subsys display a message when an allocation fails ?

There are multiple reasons an allocation can fail.

> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
>   drivers/clocksource/em_sti.c |    4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> index 9d17083..d0a7bd6 100644
> --- a/drivers/clocksource/em_sti.c
> +++ b/drivers/clocksource/em_sti.c
> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
>   	int irq;
>
>   	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> -	if (p == NULL) {
> -		dev_err(&pdev->dev, "failed to allocate driver data\n");
> +	if (p == NULL)
>   		return -ENOMEM;
> -	}
>
>   	p->pdev = pdev;
>   	platform_set_drvdata(pdev, p);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Jingoo Han]

On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
> On 04/29/2014 10:26 AM, Jingoo Han wrote:
> > The site-specific OOM messages are unnecessary, because they
> > duplicate the MM subsystem generic OOM message.
> 
> Are you sure the MM subsys display a message when an allocation fails ?
> 
> There are multiple reasons an allocation can fail.

(+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
       Thierry Reding, Andrew Morton)

There was a discussion about this in other threads. [1]
Please refer to the following link. Thank you.

[1] http://patchwork.ozlabs.org/patch/324158/

Best regards,
Jingoo Han

> 
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> >   drivers/clocksource/em_sti.c |    4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> > index 9d17083..d0a7bd6 100644
> > --- a/drivers/clocksource/em_sti.c
> > +++ b/drivers/clocksource/em_sti.c
> > @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
> >   	int irq;
> >
> >   	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> > -	if (p == NULL) {
> > -		dev_err(&pdev->dev, "failed to allocate driver data\n");
> > +	if (p == NULL)
> >   		return -ENOMEM;
> > -	}
> >
> >   	p->pdev = pdev;
> >   	platform_set_drvdata(pdev, p);
> >

Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Dan Carpenter]

On Thu, May 22, 2014 at 01:55:20PM +0900, Jingoo Han wrote:
> On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
> > On 04/29/2014 10:26 AM, Jingoo Han wrote:
> > > The site-specific OOM messages are unnecessary, because they
> > > duplicate the MM subsystem generic OOM message.
> > 
> > Are you sure the MM subsys display a message when an allocation fails ?
> > 
> > There are multiple reasons an allocation can fail.
> 
> (+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
>        Thierry Reding, Andrew Morton)
> 
> There was a discussion about this in other threads. [1]
> Please refer to the following link. Thank you.
> 
> [1] http://patchwork.ozlabs.org/patch/324158/
> 

Yes yes.  These are the right things to do, no need to add me to the CC
list, Jingoo.

Someone was going to give a talk on removing these as part of their
kernel smallification project or something...

regards,
dan carpenter

Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Daniel Lezcano]

On 05/22/2014 06:55 AM, Jingoo Han wrote:
> On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
>> On 04/29/2014 10:26 AM, Jingoo Han wrote:
>>> The site-specific OOM messages are unnecessary, because they
>>> duplicate the MM subsystem generic OOM message.
>>
>> Are you sure the MM subsys display a message when an allocation fails ?
>>
>> There are multiple reasons an allocation can fail.
>
> (+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
>         Thierry Reding, Andrew Morton)
>
> There was a discussion about this in other threads. [1]
> Please refer to the following link. Thank you.
>
> [1] http://patchwork.ozlabs.org/patch/324158/

Ok, thanks for the pointer.



>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>> ---
>>>    drivers/clocksource/em_sti.c |    4 +---
>>>    1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
>>> index 9d17083..d0a7bd6 100644
>>> --- a/drivers/clocksource/em_sti.c
>>> +++ b/drivers/clocksource/em_sti.c
>>> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
>>>    	int irq;
>>>
>>>    	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
>>> -	if (p == NULL) {
>>> -		dev_err(&pdev->dev, "failed to allocate driver data\n");
>>> +	if (p == NULL)
>>>    		return -ENOMEM;
>>> -	}
>>>
>>>    	p->pdev = pdev;
>>>    	platform_set_drvdata(pdev, p);
>>>
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[PATCH 2/4] clocksource: sh_cmt: remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/clocksource/sh_cmt.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index 0b1836a..d2aa209 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -824,10 +824,8 @@ static int sh_cmt_probe(struct platform_device *pdev)
 	}
 
 	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p == NULL) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
+	if (p == NULL)
 		return -ENOMEM;
-	}
 
 	ret = sh_cmt_setup(p, pdev);
 	if (ret) {
-- 
1.7.10.4

[PATCH 3/4] clocksource: sh_mtu2: remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/clocksource/sh_mtu2.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index e30d76e..e6bee62 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -349,10 +349,8 @@ static int sh_mtu2_probe(struct platform_device *pdev)
 	}
 
 	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p == NULL) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
+	if (p == NULL)
 		return -ENOMEM;
-	}
 
 	ret = sh_mtu2_setup(p, pdev);
 	if (ret) {
-- 
1.7.10.4

[PATCH 4/4] clocksource: sh_tmu: remove unnecessary OOM messages

[Jingoo Han]

The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/clocksource/sh_tmu.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index ecd7b60..b62f28c 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -514,10 +514,8 @@ static int sh_tmu_probe(struct platform_device *pdev)
 	}
 
 	p = kmalloc(sizeof(*p), GFP_KERNEL);
-	if (p == NULL) {
-		dev_err(&pdev->dev, "failed to allocate driver data\n");
+	if (p == NULL)
 		return -ENOMEM;
-	}
 
 	ret = sh_tmu_setup(p, pdev);
 	if (ret) {
-- 
1.7.10.4

Re: [PATCH 0/4] clocksource: remove unnecessary OOM messages

[Daniel Lezcano]

On 04/29/2014 10:24 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
>
> Jingoo Han (4):
>        clocksource: em_sti: remove unnecessary OOM messages
>        clocksource: sh_cmt: remove unnecessary OOM messages
>        clocksource: sh_mtu2: remove unnecessary OOM messages
>        clocksource: sh_tmu: remove unnecessary OOM messages
>
> ---
>   drivers/clocksource/em_sti.c  |    4 +---
>   drivers/clocksource/sh_cmt.c  |    4 +---
>   drivers/clocksource/sh_mtu2.c |    4 +---
>   drivers/clocksource/sh_tmu.c  |    4 +---
>   4 files changed, 4 insertions(+), 12 deletions(-)

Applied to my tree for 3.16 with some slight changes due to Laurent's 
changes (kmalloc -> kzalloc).

Thanks !
   -- Daniel


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog