* [PATCH 0/4] clocksource: remove unnecessary OOM messages
@ 2014-04-29 8:24 Jingoo Han
2014-04-29 8:26 ` [PATCH 1/4] clocksource: em_sti: " Jingoo Han
` (4 more replies)
0 siblings, 5 replies; 10+ messages in thread
From: Jingoo Han @ 2014-04-29 8:24 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Jingoo Han'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message. For example,
k.alloc and v.alloc failures use dump_stack().
Jingoo Han (4):
clocksource: em_sti: remove unnecessary OOM messages
clocksource: sh_cmt: remove unnecessary OOM messages
clocksource: sh_mtu2: remove unnecessary OOM messages
clocksource: sh_tmu: remove unnecessary OOM messages
---
drivers/clocksource/em_sti.c | 4 +---
drivers/clocksource/sh_cmt.c | 4 +---
drivers/clocksource/sh_mtu2.c | 4 +---
drivers/clocksource/sh_tmu.c | 4 +---
4 files changed, 4 insertions(+), 12 deletions(-)
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
@ 2014-04-29 8:26 ` Jingoo Han
2014-05-19 10:48 ` Daniel Lezcano
2014-04-29 8:27 ` [PATCH 2/4] clocksource: sh_cmt: " Jingoo Han
` (3 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Jingoo Han @ 2014-04-29 8:26 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Jingoo Han',
'Shinya Kuribayashi', 'Magnus Damm'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/clocksource/em_sti.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
index 9d17083..d0a7bd6 100644
--- a/drivers/clocksource/em_sti.c
+++ b/drivers/clocksource/em_sti.c
@@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
int irq;
p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
- if (p == NULL) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (p == NULL)
return -ENOMEM;
- }
p->pdev = pdev;
platform_set_drvdata(pdev, p);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/4] clocksource: sh_cmt: remove unnecessary OOM messages
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
2014-04-29 8:26 ` [PATCH 1/4] clocksource: em_sti: " Jingoo Han
@ 2014-04-29 8:27 ` Jingoo Han
2014-04-29 8:27 ` [PATCH 3/4] clocksource: sh_mtu2: " Jingoo Han
` (2 subsequent siblings)
4 siblings, 0 replies; 10+ messages in thread
From: Jingoo Han @ 2014-04-29 8:27 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Jingoo Han',
'Magnus Damm'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/clocksource/sh_cmt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index 0b1836a..d2aa209 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -824,10 +824,8 @@ static int sh_cmt_probe(struct platform_device *pdev)
}
p = kmalloc(sizeof(*p), GFP_KERNEL);
- if (p == NULL) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (p == NULL)
return -ENOMEM;
- }
ret = sh_cmt_setup(p, pdev);
if (ret) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/4] clocksource: sh_mtu2: remove unnecessary OOM messages
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
2014-04-29 8:26 ` [PATCH 1/4] clocksource: em_sti: " Jingoo Han
2014-04-29 8:27 ` [PATCH 2/4] clocksource: sh_cmt: " Jingoo Han
@ 2014-04-29 8:27 ` Jingoo Han
2014-04-29 8:28 ` [PATCH 4/4] clocksource: sh_tmu: " Jingoo Han
2014-05-22 12:06 ` [PATCH 0/4] clocksource: " Daniel Lezcano
4 siblings, 0 replies; 10+ messages in thread
From: Jingoo Han @ 2014-04-29 8:27 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Jingoo Han',
'Magnus Damm'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/clocksource/sh_mtu2.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index e30d76e..e6bee62 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -349,10 +349,8 @@ static int sh_mtu2_probe(struct platform_device *pdev)
}
p = kmalloc(sizeof(*p), GFP_KERNEL);
- if (p == NULL) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (p == NULL)
return -ENOMEM;
- }
ret = sh_mtu2_setup(p, pdev);
if (ret) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 4/4] clocksource: sh_tmu: remove unnecessary OOM messages
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
` (2 preceding siblings ...)
2014-04-29 8:27 ` [PATCH 3/4] clocksource: sh_mtu2: " Jingoo Han
@ 2014-04-29 8:28 ` Jingoo Han
2014-05-22 12:06 ` [PATCH 0/4] clocksource: " Daniel Lezcano
4 siblings, 0 replies; 10+ messages in thread
From: Jingoo Han @ 2014-04-29 8:28 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner', linux-kernel, 'Jingoo Han',
'Magnus Damm'
The site-specific OOM messages are unnecessary, because they
duplicate the MM subsystem generic OOM message.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/clocksource/sh_tmu.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index ecd7b60..b62f28c 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -514,10 +514,8 @@ static int sh_tmu_probe(struct platform_device *pdev)
}
p = kmalloc(sizeof(*p), GFP_KERNEL);
- if (p == NULL) {
- dev_err(&pdev->dev, "failed to allocate driver data\n");
+ if (p == NULL)
return -ENOMEM;
- }
ret = sh_tmu_setup(p, pdev);
if (ret) {
--
1.7.10.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages
2014-04-29 8:26 ` [PATCH 1/4] clocksource: em_sti: " Jingoo Han
@ 2014-05-19 10:48 ` Daniel Lezcano
2014-05-22 4:55 ` Jingoo Han
0 siblings, 1 reply; 10+ messages in thread
From: Daniel Lezcano @ 2014-05-19 10:48 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Thomas Gleixner',
linux-kernel, 'Shinya Kuribayashi', 'Magnus Damm'
On 04/29/2014 10:26 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message.
Are you sure the MM subsys display a message when an allocation fails ?
There are multiple reasons an allocation can fail.
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/clocksource/em_sti.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> index 9d17083..d0a7bd6 100644
> --- a/drivers/clocksource/em_sti.c
> +++ b/drivers/clocksource/em_sti.c
> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
> int irq;
>
> p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> - if (p == NULL) {
> - dev_err(&pdev->dev, "failed to allocate driver data\n");
> + if (p == NULL)
> return -ENOMEM;
> - }
>
> p->pdev = pdev;
> platform_set_drvdata(pdev, p);
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages
2014-05-19 10:48 ` Daniel Lezcano
@ 2014-05-22 4:55 ` Jingoo Han
2014-05-22 7:27 ` Dan Carpenter
2014-05-22 11:54 ` Daniel Lezcano
0 siblings, 2 replies; 10+ messages in thread
From: Jingoo Han @ 2014-05-22 4:55 UTC (permalink / raw)
To: 'Daniel Lezcano'
Cc: 'Thomas Gleixner',
linux-kernel, 'Shinya Kuribayashi', 'Magnus Damm',
'Viresh Kumar', 'Laurent Pinchart',
'Dan Carpenter', 'Joe Perches',
'Thierry Reding', 'Andrew Morton',
'Jingoo Han'
On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
> On 04/29/2014 10:26 AM, Jingoo Han wrote:
> > The site-specific OOM messages are unnecessary, because they
> > duplicate the MM subsystem generic OOM message.
>
> Are you sure the MM subsys display a message when an allocation fails ?
>
> There are multiple reasons an allocation can fail.
(+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
Thierry Reding, Andrew Morton)
There was a discussion about this in other threads. [1]
Please refer to the following link. Thank you.
[1] http://patchwork.ozlabs.org/patch/324158/
Best regards,
Jingoo Han
>
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/clocksource/em_sti.c | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> > index 9d17083..d0a7bd6 100644
> > --- a/drivers/clocksource/em_sti.c
> > +++ b/drivers/clocksource/em_sti.c
> > @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
> > int irq;
> >
> > p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> > - if (p == NULL) {
> > - dev_err(&pdev->dev, "failed to allocate driver data\n");
> > + if (p == NULL)
> > return -ENOMEM;
> > - }
> >
> > p->pdev = pdev;
> > platform_set_drvdata(pdev, p);
> >
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages
2014-05-22 4:55 ` Jingoo Han
@ 2014-05-22 7:27 ` Dan Carpenter
2014-05-22 11:54 ` Daniel Lezcano
1 sibling, 0 replies; 10+ messages in thread
From: Dan Carpenter @ 2014-05-22 7:27 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Daniel Lezcano', 'Thomas Gleixner',
linux-kernel, 'Shinya Kuribayashi', 'Magnus Damm',
'Viresh Kumar', 'Laurent Pinchart',
'Joe Perches', 'Thierry Reding',
'Andrew Morton'
On Thu, May 22, 2014 at 01:55:20PM +0900, Jingoo Han wrote:
> On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
> > On 04/29/2014 10:26 AM, Jingoo Han wrote:
> > > The site-specific OOM messages are unnecessary, because they
> > > duplicate the MM subsystem generic OOM message.
> >
> > Are you sure the MM subsys display a message when an allocation fails ?
> >
> > There are multiple reasons an allocation can fail.
>
> (+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
> Thierry Reding, Andrew Morton)
>
> There was a discussion about this in other threads. [1]
> Please refer to the following link. Thank you.
>
> [1] http://patchwork.ozlabs.org/patch/324158/
>
Yes yes. These are the right things to do, no need to add me to the CC
list, Jingoo.
Someone was going to give a talk on removing these as part of their
kernel smallification project or something...
regards,
dan carpenter
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages
2014-05-22 4:55 ` Jingoo Han
2014-05-22 7:27 ` Dan Carpenter
@ 2014-05-22 11:54 ` Daniel Lezcano
1 sibling, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2014-05-22 11:54 UTC (permalink / raw)
To: Jingoo Han
Cc: 'Thomas Gleixner',
linux-kernel, 'Shinya Kuribayashi', 'Magnus Damm',
'Viresh Kumar', 'Laurent Pinchart',
'Dan Carpenter', 'Joe Perches',
'Thierry Reding', 'Andrew Morton'
On 05/22/2014 06:55 AM, Jingoo Han wrote:
> On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
>> On 04/29/2014 10:26 AM, Jingoo Han wrote:
>>> The site-specific OOM messages are unnecessary, because they
>>> duplicate the MM subsystem generic OOM message.
>>
>> Are you sure the MM subsys display a message when an allocation fails ?
>>
>> There are multiple reasons an allocation can fail.
>
> (+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
> Thierry Reding, Andrew Morton)
>
> There was a discussion about this in other threads. [1]
> Please refer to the following link. Thank you.
>
> [1] http://patchwork.ozlabs.org/patch/324158/
Ok, thanks for the pointer.
>>> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
>>> ---
>>> drivers/clocksource/em_sti.c | 4 +---
>>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>>
>>> diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
>>> index 9d17083..d0a7bd6 100644
>>> --- a/drivers/clocksource/em_sti.c
>>> +++ b/drivers/clocksource/em_sti.c
>>> @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
>>> int irq;
>>>
>>> p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
>>> - if (p == NULL) {
>>> - dev_err(&pdev->dev, "failed to allocate driver data\n");
>>> + if (p == NULL)
>>> return -ENOMEM;
>>> - }
>>>
>>> p->pdev = pdev;
>>> platform_set_drvdata(pdev, p);
>>>
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/4] clocksource: remove unnecessary OOM messages
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
` (3 preceding siblings ...)
2014-04-29 8:28 ` [PATCH 4/4] clocksource: sh_tmu: " Jingoo Han
@ 2014-05-22 12:06 ` Daniel Lezcano
4 siblings, 0 replies; 10+ messages in thread
From: Daniel Lezcano @ 2014-05-22 12:06 UTC (permalink / raw)
To: Jingoo Han; +Cc: 'Thomas Gleixner', linux-kernel
On 04/29/2014 10:24 AM, Jingoo Han wrote:
> The site-specific OOM messages are unnecessary, because they
> duplicate the MM subsystem generic OOM message. For example,
> k.alloc and v.alloc failures use dump_stack().
>
> Jingoo Han (4):
> clocksource: em_sti: remove unnecessary OOM messages
> clocksource: sh_cmt: remove unnecessary OOM messages
> clocksource: sh_mtu2: remove unnecessary OOM messages
> clocksource: sh_tmu: remove unnecessary OOM messages
>
> ---
> drivers/clocksource/em_sti.c | 4 +---
> drivers/clocksource/sh_cmt.c | 4 +---
> drivers/clocksource/sh_mtu2.c | 4 +---
> drivers/clocksource/sh_tmu.c | 4 +---
> 4 files changed, 4 insertions(+), 12 deletions(-)
Applied to my tree for 3.16 with some slight changes due to Laurent's
changes (kmalloc -> kzalloc).
Thanks !
-- Daniel
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-05-22 12:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-29 8:24 [PATCH 0/4] clocksource: remove unnecessary OOM messages Jingoo Han
2014-04-29 8:26 ` [PATCH 1/4] clocksource: em_sti: " Jingoo Han
2014-05-19 10:48 ` Daniel Lezcano
2014-05-22 4:55 ` Jingoo Han
2014-05-22 7:27 ` Dan Carpenter
2014-05-22 11:54 ` Daniel Lezcano
2014-04-29 8:27 ` [PATCH 2/4] clocksource: sh_cmt: " Jingoo Han
2014-04-29 8:27 ` [PATCH 3/4] clocksource: sh_mtu2: " Jingoo Han
2014-04-29 8:28 ` [PATCH 4/4] clocksource: sh_tmu: " Jingoo Han
2014-05-22 12:06 ` [PATCH 0/4] clocksource: " Daniel Lezcano
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.