All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: "Matias Bjørling" <m@bjorling.me>,
	"Matthew Wilcox" <willy@linux.intel.com>,
	"Keith Busch" <keith.busch@intel.com>,
	"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-nvme <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v6] NVMe: conversion to blk-mq
Date: Mon, 9 Jun 2014 09:40:28 -0600	[thread overview]
Message-ID: <5395D56C.4000304@fb.com> (raw)
In-Reply-To: <CACVXFVMQ_ehnsj=7+6-WmKLSQAhDRDvOEnE6Ekbwj8sfYuuRAA@mail.gmail.com>

On 2014-06-09 09:15, Ming Lei wrote:
> On Mon, Jun 9, 2014 at 11:10 PM, Jens Axboe <axboe@fb.com> wrote:
>> On 2014-06-09 09:07, Ming Lei wrote:
>>
>> You are right, I didn't get to the bottom of the thread first.
>> Might be better to just have ->start_time set always, regardless of io stats
>> being enabled or not.
>
> Yes, just like what non-mq code did.

I queued up a fix for it.

-- 
Jens Axboe


WARNING: multiple messages have this Message-ID (diff)
From: axboe@fb.com (Jens Axboe)
Subject: [PATCH v6] NVMe: conversion to blk-mq
Date: Mon, 9 Jun 2014 09:40:28 -0600	[thread overview]
Message-ID: <5395D56C.4000304@fb.com> (raw)
In-Reply-To: <CACVXFVMQ_ehnsj=7+6-WmKLSQAhDRDvOEnE6Ekbwj8sfYuuRAA@mail.gmail.com>

On 2014-06-09 09:15, Ming Lei wrote:
> On Mon, Jun 9, 2014@11:10 PM, Jens Axboe <axboe@fb.com> wrote:
>> On 2014-06-09 09:07, Ming Lei wrote:
>>
>> You are right, I didn't get to the bottom of the thread first.
>> Might be better to just have ->start_time set always, regardless of io stats
>> being enabled or not.
>
> Yes, just like what non-mq code did.

I queued up a fix for it.

-- 
Jens Axboe

  reply	other threads:[~2014-06-09 15:41 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06 12:20 [PATCH v6] conversion to blk-mq Matias Bjørling
2014-06-06 12:20 ` Matias Bjørling
2014-06-06 12:20 ` [PATCH v6] NVMe: " Matias Bjørling
2014-06-06 12:20   ` Matias Bjørling
2014-06-09  4:35   ` Ming Lei
2014-06-09  4:35     ` Ming Lei
2014-06-09  6:00     ` Matias Bjørling
2014-06-09  6:00       ` Matias Bjørling
2014-06-09  7:50       ` Ming Lei
2014-06-09  7:50         ` Ming Lei
2014-06-09  7:53         ` Ming Lei
2014-06-09  7:53           ` Ming Lei
2014-06-09 10:40           ` Ming Lei
2014-06-09 10:40             ` Ming Lei
2014-06-12  0:58             ` Ming Lei
2014-06-12  0:58               ` Ming Lei
2014-06-09 14:08     ` Jens Axboe
2014-06-09 14:08       ` Jens Axboe
2014-06-09 14:59       ` Christoph Hellwig
2014-06-09 14:59         ` Christoph Hellwig
2014-06-09 15:27         ` Jens Axboe
2014-06-09 15:27           ` Jens Axboe
2014-06-09 15:35           ` Ming Lei
2014-06-09 15:35             ` Ming Lei
2014-06-10 11:35             ` Christoph Hellwig
2014-06-10 11:35               ` Christoph Hellwig
2014-06-10 11:55               ` Ming Lei
2014-06-10 11:55                 ` Ming Lei
2014-06-10 12:40                 ` Christoph Hellwig
2014-06-10 12:40                   ` Christoph Hellwig
2014-06-09 15:07       ` Ming Lei
2014-06-09 15:07         ` Ming Lei
2014-06-09 15:10         ` Jens Axboe
2014-06-09 15:10           ` Jens Axboe
2014-06-09 15:15           ` Ming Lei
2014-06-09 15:15             ` Ming Lei
2014-06-09 15:40             ` Jens Axboe [this message]
2014-06-09 15:40               ` Jens Axboe
2014-06-10 19:42               ` Matias Bjørling
2014-06-10 19:42                 ` Matias Bjørling

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5395D56C.4000304@fb.com \
    --to=axboe@fb.com \
    --cc=keith.busch@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=m@bjorling.me \
    --cc=sbradshaw@micron.com \
    --cc=tom.leiming@gmail.com \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.