From: Ming Lei <tom.leiming@gmail.com>
To: Jens Axboe <axboe@fb.com>
Cc: Christoph Hellwig <hch@infradead.org>,
"Matias Bj??rling" <m@bjorling.me>,
Matthew Wilcox <willy@linux.intel.com>,
Keith Busch <keith.busch@intel.com>,
"Sam Bradshaw (sbradshaw)" <sbradshaw@micron.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-nvme <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH v6] NVMe: conversion to blk-mq
Date: Mon, 9 Jun 2014 23:35:00 +0800 [thread overview]
Message-ID: <CACVXFVNNm5PJ8g=QD5zm49kaqW_oKCM+utMz+qSd=3WfsE4U2g@mail.gmail.com> (raw)
In-Reply-To: <5395D24D.9000306@fb.com>
On Mon, Jun 9, 2014 at 11:27 PM, Jens Axboe <axboe@fb.com> wrote:
> On 2014-06-09 08:59, Christoph Hellwig wrote:
>>
>> On Mon, Jun 09, 2014 at 08:08:50AM -0600, Jens Axboe wrote:
>>>>
>>>> [ 487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1
>>>> [ 487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1
>>>> [ 487.736093] end_request: I/O error, dev nvme0n1, sector 91532352
>>>> [ 487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0
>>>>
>>>>
>>>> when running fio randread(libaio, iodepth:64) with more than 3 jobs.
>>>>
>>>> And looks no such failure when jobs is 1 or 2.
>>>
>>>
>>> It's a known issue, make sure you have this patch:
>>>
>>>
>>> https://urldefense.proofpoint.com/v1/url?u=http://git.kernel.dk/?p%3Dlinux-block.git%3Ba%3Dcommit%3Bh%3Df6be4fb4bcb396fc3b1c134b7863351972de081f&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=MKK7A%2B9AnXXwtMV9YPSFEprXId0z0WLtd2JQPxnaNVc%3D%0A&s=45425e5d17390ae912457035ff081b95a7084725706ffe91166a1bdb25d8bf3d
>>
>>
>> So without this patch we can get duplicate completions? That could
>> explain the issues that Robert sees with scsi-mq and hpsa..
Use-after-free may cause duplicate completions.
BTW, is the scsi-mq patchset public now?
Thanks,
--
Ming Lei
WARNING: multiple messages have this Message-ID (diff)
From: tom.leiming@gmail.com (Ming Lei)
Subject: [PATCH v6] NVMe: conversion to blk-mq
Date: Mon, 9 Jun 2014 23:35:00 +0800 [thread overview]
Message-ID: <CACVXFVNNm5PJ8g=QD5zm49kaqW_oKCM+utMz+qSd=3WfsE4U2g@mail.gmail.com> (raw)
In-Reply-To: <5395D24D.9000306@fb.com>
On Mon, Jun 9, 2014@11:27 PM, Jens Axboe <axboe@fb.com> wrote:
> On 2014-06-09 08:59, Christoph Hellwig wrote:
>>
>> On Mon, Jun 09, 2014@08:08:50AM -0600, Jens Axboe wrote:
>>>>
>>>> [ 487.704074] nvme 0000:00:07.0: Cancelling I/O 202 QID 1
>>>> [ 487.717881] nvme 0000:00:07.0: Aborting I/O 202 QID 1
>>>> [ 487.736093] end_request: I/O error, dev nvme0n1, sector 91532352
>>>> [ 487.747378] nvme 0000:00:07.0: completed id 0 twice on queue 0
>>>>
>>>>
>>>> when running fio randread(libaio, iodepth:64) with more than 3 jobs.
>>>>
>>>> And looks no such failure when jobs is 1 or 2.
>>>
>>>
>>> It's a known issue, make sure you have this patch:
>>>
>>>
>>> https://urldefense.proofpoint.com/v1/url?u=http://git.kernel.dk/?p%3Dlinux-block.git%3Ba%3Dcommit%3Bh%3Df6be4fb4bcb396fc3b1c134b7863351972de081f&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=3JMVyziIyZtZ5cv9eWNLwQ%3D%3D%0A&m=MKK7A%2B9AnXXwtMV9YPSFEprXId0z0WLtd2JQPxnaNVc%3D%0A&s=45425e5d17390ae912457035ff081b95a7084725706ffe91166a1bdb25d8bf3d
>>
>>
>> So without this patch we can get duplicate completions? That could
>> explain the issues that Robert sees with scsi-mq and hpsa..
Use-after-free may cause duplicate completions.
BTW, is the scsi-mq patchset public now?
Thanks,
--
Ming Lei
next prev parent reply other threads:[~2014-06-09 15:35 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-06 12:20 [PATCH v6] conversion to blk-mq Matias Bjørling
2014-06-06 12:20 ` Matias Bjørling
2014-06-06 12:20 ` [PATCH v6] NVMe: " Matias Bjørling
2014-06-06 12:20 ` Matias Bjørling
2014-06-09 4:35 ` Ming Lei
2014-06-09 4:35 ` Ming Lei
2014-06-09 6:00 ` Matias Bjørling
2014-06-09 6:00 ` Matias Bjørling
2014-06-09 7:50 ` Ming Lei
2014-06-09 7:50 ` Ming Lei
2014-06-09 7:53 ` Ming Lei
2014-06-09 7:53 ` Ming Lei
2014-06-09 10:40 ` Ming Lei
2014-06-09 10:40 ` Ming Lei
2014-06-12 0:58 ` Ming Lei
2014-06-12 0:58 ` Ming Lei
2014-06-09 14:08 ` Jens Axboe
2014-06-09 14:08 ` Jens Axboe
2014-06-09 14:59 ` Christoph Hellwig
2014-06-09 14:59 ` Christoph Hellwig
2014-06-09 15:27 ` Jens Axboe
2014-06-09 15:27 ` Jens Axboe
2014-06-09 15:35 ` Ming Lei [this message]
2014-06-09 15:35 ` Ming Lei
2014-06-10 11:35 ` Christoph Hellwig
2014-06-10 11:35 ` Christoph Hellwig
2014-06-10 11:55 ` Ming Lei
2014-06-10 11:55 ` Ming Lei
2014-06-10 12:40 ` Christoph Hellwig
2014-06-10 12:40 ` Christoph Hellwig
2014-06-09 15:07 ` Ming Lei
2014-06-09 15:07 ` Ming Lei
2014-06-09 15:10 ` Jens Axboe
2014-06-09 15:10 ` Jens Axboe
2014-06-09 15:15 ` Ming Lei
2014-06-09 15:15 ` Ming Lei
2014-06-09 15:40 ` Jens Axboe
2014-06-09 15:40 ` Jens Axboe
2014-06-10 19:42 ` Matias Bjørling
2014-06-10 19:42 ` Matias Bjørling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACVXFVNNm5PJ8g=QD5zm49kaqW_oKCM+utMz+qSd=3WfsE4U2g@mail.gmail.com' \
--to=tom.leiming@gmail.com \
--cc=axboe@fb.com \
--cc=hch@infradead.org \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=m@bjorling.me \
--cc=sbradshaw@micron.com \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.