All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-05-23 14:39 ` Tomasz Figa
  0 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-05-23 14:39 UTC (permalink / raw)
  To: linux-samsung-soc
  Cc: linux-arm-kernel, Kukjin Kim, Marek Szyprowski, Tomasz Figa, Tomasz Figa

This patch fixes reg entry sizes in GIC node that were not large enough
to cover whole regions.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..fbaf426 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -113,7 +113,7 @@
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
+		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
 	};
 
 	combiner: interrupt-controller@10440000 {
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-05-23 14:39 ` Tomasz Figa
  0 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-05-23 14:39 UTC (permalink / raw)
  To: linux-arm-kernel

This patch fixes reg entry sizes in GIC node that were not large enough
to cover whole regions.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos4.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index b8ece4b..fbaf426 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -113,7 +113,7 @@
 		compatible = "arm,cortex-a9-gic";
 		#interrupt-cells = <3>;
 		interrupt-controller;
-		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
+		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
 	};
 
 	combiner: interrupt-controller at 10440000 {
-- 
1.9.3

^ permalink raw reply related	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
  2014-05-23 14:39 ` Tomasz Figa
@ 2014-05-30 11:41   ` Tomasz Figa
  -1 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-05-30 11:41 UTC (permalink / raw)
  To: Tomasz Figa, linux-samsung-soc
  Cc: linux-arm-kernel, Kukjin Kim, Marek Szyprowski

Hi,

On 23.05.2014 16:39, Tomasz Figa wrote:
> This patch fixes reg entry sizes in GIC node that were not large enough
> to cover whole regions.
> 
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..fbaf426 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -113,7 +113,7 @@
>  		compatible = "arm,cortex-a9-gic";
>  		#interrupt-cells = <3>;
>  		interrupt-controller;
> -		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
> +		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
>  	};
>  
>  	combiner: interrupt-controller@10440000 {
> 

Ping.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-05-30 11:41   ` Tomasz Figa
  0 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-05-30 11:41 UTC (permalink / raw)
  To: linux-arm-kernel

Hi,

On 23.05.2014 16:39, Tomasz Figa wrote:
> This patch fixes reg entry sizes in GIC node that were not large enough
> to cover whole regions.
> 
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
> index b8ece4b..fbaf426 100644
> --- a/arch/arm/boot/dts/exynos4.dtsi
> +++ b/arch/arm/boot/dts/exynos4.dtsi
> @@ -113,7 +113,7 @@
>  		compatible = "arm,cortex-a9-gic";
>  		#interrupt-cells = <3>;
>  		interrupt-controller;
> -		reg = <0x10490000 0x1000>, <0x10480000 0x100>;
> +		reg = <0x10490000 0x10000>, <0x10480000 0x10000>;
>  	};
>  
>  	combiner: interrupt-controller at 10440000 {
> 

Ping.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
  2014-05-30 11:41   ` Tomasz Figa
@ 2014-05-30 18:18     ` Kukjin Kim
  -1 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2014-05-30 18:18 UTC (permalink / raw)
  To: Tomasz Figa
  Cc: Tomasz Figa, linux-samsung-soc, linux-arm-kernel, Kukjin Kim,
	Marek Szyprowski

On 05/30/14 20:41, Tomasz Figa wrote:
> Hi,
>
> On 23.05.2014 16:39, Tomasz Figa wrote:
>> This patch fixes reg entry sizes in GIC node that were not large enough
>> to cover whole regions.
>>
>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index b8ece4b..fbaf426 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -113,7 +113,7 @@
>>   		compatible = "arm,cortex-a9-gic";
>>   		#interrupt-cells =<3>;
>>   		interrupt-controller;
>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>   	};
>>
>>   	combiner: interrupt-controller@10440000 {
>>
>
> Ping.
>
Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT 
support. Applied, but I need to check this is required for stable tree...

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-05-30 18:18     ` Kukjin Kim
  0 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2014-05-30 18:18 UTC (permalink / raw)
  To: linux-arm-kernel

On 05/30/14 20:41, Tomasz Figa wrote:
> Hi,
>
> On 23.05.2014 16:39, Tomasz Figa wrote:
>> This patch fixes reg entry sizes in GIC node that were not large enough
>> to cover whole regions.
>>
>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>> index b8ece4b..fbaf426 100644
>> --- a/arch/arm/boot/dts/exynos4.dtsi
>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>> @@ -113,7 +113,7 @@
>>   		compatible = "arm,cortex-a9-gic";
>>   		#interrupt-cells =<3>;
>>   		interrupt-controller;
>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>   	};
>>
>>   	combiner: interrupt-controller at 10440000 {
>>
>
> Ping.
>
Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT 
support. Applied, but I need to check this is required for stable tree...

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
  2014-05-30 18:18     ` Kukjin Kim
@ 2014-06-10 15:28       ` Tomasz Figa
  -1 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-06-10 15:28 UTC (permalink / raw)
  To: Kukjin Kim, Tomasz Figa
  Cc: linux-samsung-soc, linux-arm-kernel, Marek Szyprowski

Hi Kukjin,

On 30.05.2014 20:18, Kukjin Kim wrote:
> On 05/30/14 20:41, Tomasz Figa wrote:
>> Hi,
>>
>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>> to cover whole regions.
>>>
>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>> ---
>>>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>> index b8ece4b..fbaf426 100644
>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>> @@ -113,7 +113,7 @@
>>>   		compatible = "arm,cortex-a9-gic";
>>>   		#interrupt-cells =<3>;
>>>   		interrupt-controller;
>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>   	};
>>>
>>>   	combiner: interrupt-controller@10440000 {
>>>
>>
>> Ping.
>>
> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT 
> support. Applied, but I need to check this is required for stable tree...

Not sure if you already managed, but I think it might not be necessary
in stable trees, as the (correct) static mapping is still there and it
causes ioremap() to return correctly mapped area, ignoring the length
specified in device tree.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-06-10 15:28       ` Tomasz Figa
  0 siblings, 0 replies; 10+ messages in thread
From: Tomasz Figa @ 2014-06-10 15:28 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Kukjin,

On 30.05.2014 20:18, Kukjin Kim wrote:
> On 05/30/14 20:41, Tomasz Figa wrote:
>> Hi,
>>
>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>> to cover whole regions.
>>>
>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>> ---
>>>   arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>> index b8ece4b..fbaf426 100644
>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>> @@ -113,7 +113,7 @@
>>>   		compatible = "arm,cortex-a9-gic";
>>>   		#interrupt-cells =<3>;
>>>   		interrupt-controller;
>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>   	};
>>>
>>>   	combiner: interrupt-controller at 10440000 {
>>>
>>
>> Ping.
>>
> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT 
> support. Applied, but I need to check this is required for stable tree...

Not sure if you already managed, but I think it might not be necessary
in stable trees, as the (correct) static mapping is still there and it
causes ioremap() to return correctly mapped area, ignoring the length
specified in device tree.

Best regards,
Tomasz

^ permalink raw reply	[flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
  2014-06-10 15:28       ` Tomasz Figa
@ 2014-06-11 15:42         ` Kukjin Kim
  -1 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2014-06-11 15:42 UTC (permalink / raw)
  To: Tomasz Figa
  Cc: Kukjin Kim, Tomasz Figa, linux-samsung-soc, linux-arm-kernel,
	Marek Szyprowski

On 06/11/14 00:28, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi Tomasz,

> On 30.05.2014 20:18, Kukjin Kim wrote:
>> On 05/30/14 20:41, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>>> to cover whole regions.
>>>>
>>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>>> ---
>>>>    arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>>> index b8ece4b..fbaf426 100644
>>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>>> @@ -113,7 +113,7 @@
>>>>    		compatible = "arm,cortex-a9-gic";
>>>>    		#interrupt-cells =<3>;
>>>>    		interrupt-controller;
>>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>>    	};
>>>>
>>>>    	combiner: interrupt-controller@10440000 {
>>>>
>>>
>>> Ping.
>>>
>> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT
>> support. Applied, but I need to check this is required for stable tree...
>
> Not sure if you already managed, but I think it might not be necessary
> in stable trees, as the (correct) static mapping is still there and it
> causes ioremap() to return correctly mapped area, ignoring the length
> specified in device tree.
>
Yes, agreed. this is not required for stable tree...

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC
@ 2014-06-11 15:42         ` Kukjin Kim
  0 siblings, 0 replies; 10+ messages in thread
From: Kukjin Kim @ 2014-06-11 15:42 UTC (permalink / raw)
  To: linux-arm-kernel

On 06/11/14 00:28, Tomasz Figa wrote:
> Hi Kukjin,
>
Hi Tomasz,

> On 30.05.2014 20:18, Kukjin Kim wrote:
>> On 05/30/14 20:41, Tomasz Figa wrote:
>>> Hi,
>>>
>>> On 23.05.2014 16:39, Tomasz Figa wrote:
>>>> This patch fixes reg entry sizes in GIC node that were not large enough
>>>> to cover whole regions.
>>>>
>>>> Signed-off-by: Tomasz Figa<t.figa@samsung.com>
>>>> ---
>>>>    arch/arm/boot/dts/exynos4.dtsi | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
>>>> index b8ece4b..fbaf426 100644
>>>> --- a/arch/arm/boot/dts/exynos4.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos4.dtsi
>>>> @@ -113,7 +113,7 @@
>>>>    		compatible = "arm,cortex-a9-gic";
>>>>    		#interrupt-cells =<3>;
>>>>    		interrupt-controller;
>>>> -		reg =<0x10490000 0x1000>,<0x10480000 0x100>;
>>>> +		reg =<0x10490000 0x10000>,<0x10480000 0x10000>;
>>>>    	};
>>>>
>>>>    	combiner: interrupt-controller at 10440000 {
>>>>
>>>
>>> Ping.
>>>
>> Yeah, SZ_64K is used for GIC_CPU and GIC_DIST before moving on DT
>> support. Applied, but I need to check this is required for stable tree...
>
> Not sure if you already managed, but I think it might not be necessary
> in stable trees, as the (correct) static mapping is still there and it
> causes ioremap() to return correctly mapped area, ignoring the length
> specified in device tree.
>
Yes, agreed. this is not required for stable tree...

Thanks,
Kukjin

^ permalink raw reply	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-06-11 15:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-23 14:39 [PATCH] ARM: dts: exynos4: Fix reg sizes of GIC Tomasz Figa
2014-05-23 14:39 ` Tomasz Figa
2014-05-30 11:41 ` Tomasz Figa
2014-05-30 11:41   ` Tomasz Figa
2014-05-30 18:18   ` Kukjin Kim
2014-05-30 18:18     ` Kukjin Kim
2014-06-10 15:28     ` Tomasz Figa
2014-06-10 15:28       ` Tomasz Figa
2014-06-11 15:42       ` Kukjin Kim
2014-06-11 15:42         ` Kukjin Kim

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.