From: Mat Martineau <mathew.j.martineau at linux.intel.com> To: mptcp at lists.01.org Subject: [MPTCP] Re: [RFC PATCH] selinux: handle MPTCP consistently with TCP Date: Thu, 03 Dec 2020 09:24:43 -0800 [thread overview] Message-ID: <539f376-62c2-dbe7-fbfd-6dc7a53eafa@linux.intel.com> (raw) In-Reply-To: 3a5f156da4569957b91bb5aa4d2a316b729a2c69.camel@redhat.com [-- Attachment #1: Type: text/plain, Size: 2146 bytes --] On Wed, 2 Dec 2020, Paolo Abeni wrote: > On Wed, 2020-12-02 at 11:31 +0100, Paolo Abeni wrote: >> The MPTCP protocol uses a specific protocol value, even if >> it's an extension to TCP. Additionally, MPTCP sockets >> could 'fall-back' to TCP at run-time, depending on peer MPTCP >> support and available resources. >> >> As a consequence of the specific protocol number, selinux >> applies the raw_socket class to MPTCP sockets. >> >> Existing TCP application converted to MPTCP - or forced to >> use MPTCP socket with user-space hacks - will need an >> updated policy to run successfully. >> >> This change lets selinux attach the TCP socket class to >> MPTCP sockets, too, so that no policy changes are needed in >> the above scenario. >> >> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com> >> --- >> security/selinux/hooks.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c >> index 6b1826fc3658..9a6b4bf1bc5b 100644 >> --- a/security/selinux/hooks.c >> +++ b/security/selinux/hooks.c >> @@ -1120,7 +1120,8 @@ static inline u16 inode_mode_to_security_class(umode_t mode) >> >> static inline int default_protocol_stream(int protocol) >> { >> - return (protocol == IPPROTO_IP || protocol == IPPROTO_TCP); >> + return (protocol == IPPROTO_IP || protocol == IPPROTO_TCP || >> + protocol == IPPROTO_MPTCP); >> } This looks like a good default to me. >> >> static inline int default_protocol_dgram(int protocol) >> @@ -1152,7 +1153,7 @@ static inline u16 socket_type_to_security_class(int family, int type, int protoc >> return SECCLASS_TCP_SOCKET; >> else if (extsockclass && protocol == IPPROTO_SCTP) >> return SECCLASS_SCTP_SOCKET; >> - else >> + elseextsockclass > > Whoops, my bad! I don't know how this chunk slipped-in. I'll fix it in > the formal submission for inclusion, if there is agreement on this > change. Ok, looks fine to send after fixup. I think there may be a small fix required to smack too, but that's an entirely different patch. -- Mat Martineau Intel
WARNING: multiple messages have this Message-ID (diff)
From: Mat Martineau <mathew.j.martineau@linux.intel.com> To: Paolo Abeni <pabeni@redhat.com> Cc: Paul Moore <paul@paul-moore.com>, Stephen Smalley <stephen.smalley.work@gmail.com>, selinux@vger.kernel.org, mptcp@lists.01.org Subject: Re: [MPTCP] Re: [RFC PATCH] selinux: handle MPTCP consistently with TCP Date: Thu, 3 Dec 2020 09:24:43 -0800 (PST) [thread overview] Message-ID: <539f376-62c2-dbe7-fbfd-6dc7a53eafa@linux.intel.com> (raw) In-Reply-To: <3a5f156da4569957b91bb5aa4d2a316b729a2c69.camel@redhat.com> On Wed, 2 Dec 2020, Paolo Abeni wrote: > On Wed, 2020-12-02 at 11:31 +0100, Paolo Abeni wrote: >> The MPTCP protocol uses a specific protocol value, even if >> it's an extension to TCP. Additionally, MPTCP sockets >> could 'fall-back' to TCP at run-time, depending on peer MPTCP >> support and available resources. >> >> As a consequence of the specific protocol number, selinux >> applies the raw_socket class to MPTCP sockets. >> >> Existing TCP application converted to MPTCP - or forced to >> use MPTCP socket with user-space hacks - will need an >> updated policy to run successfully. >> >> This change lets selinux attach the TCP socket class to >> MPTCP sockets, too, so that no policy changes are needed in >> the above scenario. >> >> Signed-off-by: Paolo Abeni <pabeni@redhat.com> >> --- >> security/selinux/hooks.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c >> index 6b1826fc3658..9a6b4bf1bc5b 100644 >> --- a/security/selinux/hooks.c >> +++ b/security/selinux/hooks.c >> @@ -1120,7 +1120,8 @@ static inline u16 inode_mode_to_security_class(umode_t mode) >> >> static inline int default_protocol_stream(int protocol) >> { >> - return (protocol == IPPROTO_IP || protocol == IPPROTO_TCP); >> + return (protocol == IPPROTO_IP || protocol == IPPROTO_TCP || >> + protocol == IPPROTO_MPTCP); >> } This looks like a good default to me. >> >> static inline int default_protocol_dgram(int protocol) >> @@ -1152,7 +1153,7 @@ static inline u16 socket_type_to_security_class(int family, int type, int protoc >> return SECCLASS_TCP_SOCKET; >> else if (extsockclass && protocol == IPPROTO_SCTP) >> return SECCLASS_SCTP_SOCKET; >> - else >> + elseextsockclass > > Whoops, my bad! I don't know how this chunk slipped-in. I'll fix it in > the formal submission for inclusion, if there is agreement on this > change. Ok, looks fine to send after fixup. I think there may be a small fix required to smack too, but that's an entirely different patch. -- Mat Martineau Intel
next reply other threads:[~2020-12-03 17:24 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-03 17:24 Mat Martineau [this message] 2020-12-03 17:24 ` [MPTCP] Re: [RFC PATCH] selinux: handle MPTCP consistently with TCP Mat Martineau -- strict thread matches above, loose matches on Subject: below -- 2020-12-10 2:43 Paul Moore 2020-12-10 2:43 ` Paul Moore 2020-12-09 10:02 Paolo Abeni 2020-12-09 10:02 ` Paolo Abeni 2020-12-08 23:35 Paul Moore 2020-12-08 23:35 ` Paul Moore 2020-12-08 15:35 Paolo Abeni 2020-12-08 15:35 ` Paolo Abeni 2020-12-04 23:22 Paul Moore 2020-12-04 23:22 ` Paul Moore 2020-12-04 10:04 Paolo Abeni 2020-12-04 10:04 ` Paolo Abeni 2020-12-04 2:24 Paul Moore 2020-12-04 2:24 ` Paul Moore 2020-12-03 23:54 Florian Westphal 2020-12-03 23:54 ` Florian Westphal 2020-12-03 23:30 Paul Moore 2020-12-03 23:30 ` Paul Moore 2020-12-02 11:17 Paolo Abeni 2020-12-02 11:17 ` [MPTCP] " Paolo Abeni 2020-12-02 10:31 Paolo Abeni 2020-12-02 10:31 ` Paolo Abeni
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=539f376-62c2-dbe7-fbfd-6dc7a53eafa@linux.intel.com \ --to=unknown@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.