* Are Small Changes in kernel accepted as patches
@ 2014-06-21 9:37 karthik
2014-06-21 10:04 ` Jeff Kirsher
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
0 siblings, 2 replies; 5+ messages in thread
From: karthik @ 2014-06-21 9:37 UTC (permalink / raw)
To: kernelnewbies
Hey There,
I was just going through the linux-next source and found a small change
in one of the files. (Unnecessary else)
Now should I make this a patch and submit it or is it too small to submit?
Regards
Karthik Nayak
^ permalink raw reply [flat|nested] 5+ messages in thread
* Are Small Changes in kernel accepted as patches
2014-06-21 9:37 Are Small Changes in kernel accepted as patches karthik
@ 2014-06-21 10:04 ` Jeff Kirsher
2014-06-21 10:27 ` Robert P. J. Day
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
1 sibling, 1 reply; 5+ messages in thread
From: Jeff Kirsher @ 2014-06-21 10:04 UTC (permalink / raw)
To: kernelnewbies
On Sat, Jun 21, 2014 at 2:37 AM, karthik <karthik.188@gmail.com> wrote:
> Hey There,
> I was just going through the linux-next source and found a small change
> in one of the files. (Unnecessary else)
> Now should I make this a patch and submit it or is it too small to submit?
> Regards
> Karthik Nayak
>
Any patch can never be "to small", in fact small changes/patches are
preferred over large changes/patches.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Are Small Changes in kernel accepted as patches
2014-06-21 10:04 ` Jeff Kirsher
@ 2014-06-21 10:27 ` Robert P. J. Day
0 siblings, 0 replies; 5+ messages in thread
From: Robert P. J. Day @ 2014-06-21 10:27 UTC (permalink / raw)
To: kernelnewbies
On Sat, 21 Jun 2014, Jeff Kirsher wrote:
> On Sat, Jun 21, 2014 at 2:37 AM, karthik <karthik.188@gmail.com> wrote:
> > Hey There,
> > I was just going through the linux-next source and found a small change
> > in one of the files. (Unnecessary else)
> > Now should I make this a patch and submit it or is it too small to submit?
> > Regards
> > Karthik Nayak
>
> Any patch can never be "to small", in fact small changes/patches are
> preferred over large changes/patches.
there is a special email address for innocuous patches --
"trivial at kernel.org".
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
^ permalink raw reply [flat|nested] 5+ messages in thread
* Are Small Changes in kernel accepted as patches
2014-06-21 9:37 Are Small Changes in kernel accepted as patches karthik
2014-06-21 10:04 ` Jeff Kirsher
@ 2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
2014-06-21 14:42 ` karthik
1 sibling, 1 reply; 5+ messages in thread
From: Valdis.Kletnieks at vt.edu @ 2014-06-21 14:23 UTC (permalink / raw)
To: kernelnewbies
On Sat, 21 Jun 2014 15:07:49 +0530, karthik said:
> I was just going through the linux-next source and found a small change
> in one of the files. (Unnecessary else)
One-line patches that fix misleading logic are always welcome.
Just remember to:
1_ Read Documentation/SubmititingPatches.txt and follow the directions
2) In the patch description/ changelog explain *why* the 'else' is unneeded
as that's a change in the program logic. And then fix it correctly - if
the else is unneeded because you can prove it's deal code because the
if condition is always true, then the 'if then' part can probably be
fixed up as well....
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 848 bytes
Desc: not available
Url : http://lists.kernelnewbies.org/pipermail/kernelnewbies/attachments/20140621/db1304c4/attachment.bin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Are Small Changes in kernel accepted as patches
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
@ 2014-06-21 14:42 ` karthik
0 siblings, 0 replies; 5+ messages in thread
From: karthik @ 2014-06-21 14:42 UTC (permalink / raw)
To: kernelnewbies
On Saturday 21 June 2014 07:53 PM, Valdis.Kletnieks at vt.edu wrote:
> On Sat, 21 Jun 2014 15:07:49 +0530, karthik said:
>
>> I was just going through the linux-next source and found a small change
>> in one of the files. (Unnecessary else)
> One-line patches that fix misleading logic are always welcome.
>
> Just remember to:
>
> 1_ Read Documentation/SubmititingPatches.txt and follow the directions
>
> 2) In the patch description/ changelog explain *why* the 'else' is unneeded
> as that's a change in the program logic. And then fix it correctly - if
> the else is unneeded because you can prove it's deal code because the
> if condition is always true, then the 'if then' part can probably be
> fixed up as well....
Brilliant
Thanks for the replies
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-06-21 14:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-06-21 9:37 Are Small Changes in kernel accepted as patches karthik
2014-06-21 10:04 ` Jeff Kirsher
2014-06-21 10:27 ` Robert P. J. Day
2014-06-21 14:23 ` Valdis.Kletnieks at vt.edu
2014-06-21 14:42 ` karthik
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.