From: Paolo Bonzini <pbonzini@redhat.com>
To: Christoffer Dall <christoffer.dall@linaro.org>,
Mario Smarduch <m.smarduch@samsung.com>
Cc: kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
xiaoguangrong@linux.vnet.ibm.com, steve.capper@arm.com,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
gavin.guo@canonical.com, peter.maydell@linaro.org,
jays.lee@samsung.com, sungjinn.chung@samsung.com
Subject: Re: [RESEND PATCH v7 3/4] arm: dirty log write protect management support
Date: Fri, 04 Jul 2014 18:29:31 +0200 [thread overview]
Message-ID: <53B6D66B.9070608@redhat.com> (raw)
In-Reply-To: <20140703150401.GE20104@cbox>
Il 03/07/2014 17:04, Christoffer Dall ha scritto:
> Hmmm, I'm really not an expert in the 'established procedures' for what
> to put in config files etc., but here's my basic take:
>
> a) you wouldn't put a config option in Kconfig unless it's comething
> that's actually configurable or some generic feature/subsystem that
> should only be enabled if hardware has certain capabilities or other
> config options enabled.
>
> b) this seems entirely an implementation issue and not depending on
> anything users should select.
Actually I think Mario's idea is just fine. Non-user-accessible Kconfig
symbols are used a lot to invoke an #ifdef elsewhere in the code;
compare this with his proposal is a bit different but not too much.
Sometimes #defines are used, sometimes Kconfig symbols, but the idea is
the same.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: pbonzini@redhat.com (Paolo Bonzini)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v7 3/4] arm: dirty log write protect management support
Date: Fri, 04 Jul 2014 18:29:31 +0200 [thread overview]
Message-ID: <53B6D66B.9070608@redhat.com> (raw)
In-Reply-To: <20140703150401.GE20104@cbox>
Il 03/07/2014 17:04, Christoffer Dall ha scritto:
> Hmmm, I'm really not an expert in the 'established procedures' for what
> to put in config files etc., but here's my basic take:
>
> a) you wouldn't put a config option in Kconfig unless it's comething
> that's actually configurable or some generic feature/subsystem that
> should only be enabled if hardware has certain capabilities or other
> config options enabled.
>
> b) this seems entirely an implementation issue and not depending on
> anything users should select.
Actually I think Mario's idea is just fine. Non-user-accessible Kconfig
symbols are used a lot to invoke an #ifdef elsewhere in the code;
compare this with his proposal is a bit different but not too much.
Sometimes #defines are used, sometimes Kconfig symbols, but the idea is
the same.
Paolo
next prev parent reply other threads:[~2014-07-04 16:30 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 23:19 [PATCH v7 0/4] arm: dirty page logging support for ARMv7 Mario Smarduch
2014-06-03 23:19 ` Mario Smarduch
2014-06-03 23:19 ` [PATCH v7 1/4] arm: add ARMv7 HYP API to flush VM TLBs without address param Mario Smarduch
2014-06-03 23:19 ` Mario Smarduch
2014-06-08 12:05 ` Christoffer Dall
2014-06-08 12:05 ` Christoffer Dall
2014-06-09 17:06 ` Mario Smarduch
2014-06-09 17:06 ` Mario Smarduch
2014-06-09 17:49 ` Christoffer Dall
2014-06-09 17:49 ` Christoffer Dall
2014-06-09 18:36 ` Mario Smarduch
2014-06-09 18:36 ` Mario Smarduch
2014-06-03 23:19 ` [PATCH v7 2/4] arm: dirty page logging inital mem region write protect (w/no huge PUD support) Mario Smarduch
2014-06-03 23:19 ` Mario Smarduch
2014-06-08 12:05 ` Christoffer Dall
2014-06-08 12:05 ` Christoffer Dall
2014-06-09 17:58 ` Mario Smarduch
2014-06-09 17:58 ` Mario Smarduch
2014-06-09 18:09 ` Christoffer Dall
2014-06-09 18:09 ` Christoffer Dall
2014-06-09 18:33 ` Mario Smarduch
2014-06-09 18:33 ` Mario Smarduch
2014-06-03 23:19 ` [PATCH v7 3/4] arm: dirty log write protect management support Mario Smarduch
2014-06-03 23:19 ` Mario Smarduch
2014-06-03 23:19 ` [PATCH v7 4/4] arm: dirty page logging 2nd stage page fault handling support Mario Smarduch
2014-06-03 23:19 ` Mario Smarduch
2014-06-08 12:05 ` Christoffer Dall
2014-06-08 12:05 ` Christoffer Dall
2014-06-10 18:23 ` Mario Smarduch
2014-06-10 18:23 ` Mario Smarduch
2014-06-11 6:58 ` Christoffer Dall
2014-06-11 6:58 ` Christoffer Dall
2014-06-12 2:53 ` Mario Smarduch
2014-06-12 2:53 ` Mario Smarduch
2014-06-06 17:33 ` [RESEND PATCH v7 3/4] arm: dirty log write protect management support Mario Smarduch
2014-06-06 17:33 ` Mario Smarduch
2014-06-08 12:05 ` Christoffer Dall
2014-06-08 12:05 ` Christoffer Dall
2014-06-10 1:47 ` Mario Smarduch
2014-06-10 1:47 ` Mario Smarduch
2014-06-10 9:22 ` Christoffer Dall
2014-06-10 9:22 ` Christoffer Dall
2014-06-10 18:08 ` Mario Smarduch
2014-06-10 18:08 ` Mario Smarduch
2014-06-11 7:03 ` Christoffer Dall
2014-06-11 7:03 ` Christoffer Dall
2014-06-12 3:02 ` Mario Smarduch
2014-06-12 3:02 ` Mario Smarduch
2014-06-18 1:41 ` Mario Smarduch
2014-06-18 1:41 ` Mario Smarduch
2014-07-03 15:04 ` Christoffer Dall
2014-07-03 15:04 ` Christoffer Dall
2014-07-04 16:29 ` Paolo Bonzini [this message]
2014-07-04 16:29 ` Paolo Bonzini
2014-07-17 16:00 ` Mario Smarduch
2014-07-17 16:00 ` Mario Smarduch
2014-07-17 16:17 ` Mario Smarduch
2014-07-17 16:17 ` Mario Smarduch
2014-06-08 10:45 ` [PATCH v7 0/4] arm: dirty page logging support for ARMv7 Christoffer Dall
2014-06-08 10:45 ` Christoffer Dall
2014-06-09 17:02 ` Mario Smarduch
2014-06-09 17:02 ` Mario Smarduch
2014-06-04 21:11 [RESEND PATCH v7 3/4] arm: dirty log write protect management support Mario Smarduch
2014-06-04 21:11 ` Mario Smarduch
2014-06-05 6:55 ` Xiao Guangrong
2014-06-05 6:55 ` Xiao Guangrong
2014-06-05 19:09 ` Mario Smarduch
2014-06-05 19:09 ` Mario Smarduch
2014-06-06 5:52 ` Xiao Guangrong
2014-06-06 5:52 ` Xiao Guangrong
2014-06-06 17:36 ` Mario Smarduch
2014-06-06 17:36 ` Mario Smarduch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B6D66B.9070608@redhat.com \
--to=pbonzini@redhat.com \
--cc=christoffer.dall@linaro.org \
--cc=gavin.guo@canonical.com \
--cc=jays.lee@samsung.com \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=m.smarduch@samsung.com \
--cc=marc.zyngier@arm.com \
--cc=peter.maydell@linaro.org \
--cc=steve.capper@arm.com \
--cc=sungjinn.chung@samsung.com \
--cc=xiaoguangrong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.