All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Tobias Jakobi <liquid.acid@gmx.net>,
	Thomas Abraham <thomas.ab@samsung.com>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: linux-samsung-soc@vger.kernel.org, mturquette@linaro.org,
	kgene.kim@samsung.com, t.figa@samsung.com,
	l.majewski@samsung.com, viresh.kumar@linaro.org, heiko@sntech.de,
	cw00.choi@samsung.com
Subject: Re: [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
Date: Sat, 19 Jul 2014 22:54:06 +0200	[thread overview]
Message-ID: <53CADAEE.2070009@gmail.com> (raw)
In-Reply-To: <53CAC4FB.9030703@gmx.net>

Tobias,

On 19.07.2014 21:20, Tobias Jakobi wrote:
> Hello,
> 
> I have a question concerning an older version of this patchset, the one
> which still included exynos4x12 support and where the clocking data was
> provided through DT.
> 
> I tried to get this working for my ODROID-X2, which does work well,
> including the usage of the boost frequences. Since the X2 has an
> Exynos4412 Prime I added additional clocking data and operating points.
> 
> clocking data (comes from the vendor kernel):
> <1704000 3 7 0 6 1 2 7 0 7>
> <1600000 3 7 0 6 1 2 6 0 7>
> 
> operating points (again from vendor kernel):
> 1704000 1375000
> 1600000 1350000
> 
> Doing this I get correct output from scaling_available_frequencies and
> scaling_boost_frequencies and the driver seems to select these
> frequences. However when reading from cpufreq_cur_freq, which I think
> returns the frequency of the armclk, the maximum freq never exceeds
> 1.5GHz. So effectively the additional clocking data and opps are not used.
> 
> I wonder this happens? Is there some kind of limit enforced?

Have you also extended the array of allowed APLL settings in
drivers/clk/clk-exynos4.c?

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms
Date: Sat, 19 Jul 2014 22:54:06 +0200	[thread overview]
Message-ID: <53CADAEE.2070009@gmail.com> (raw)
In-Reply-To: <53CAC4FB.9030703@gmx.net>

Tobias,

On 19.07.2014 21:20, Tobias Jakobi wrote:
> Hello,
> 
> I have a question concerning an older version of this patchset, the one
> which still included exynos4x12 support and where the clocking data was
> provided through DT.
> 
> I tried to get this working for my ODROID-X2, which does work well,
> including the usage of the boost frequences. Since the X2 has an
> Exynos4412 Prime I added additional clocking data and operating points.
> 
> clocking data (comes from the vendor kernel):
> <1704000 3 7 0 6 1 2 7 0 7>
> <1600000 3 7 0 6 1 2 6 0 7>
> 
> operating points (again from vendor kernel):
> 1704000 1375000
> 1600000 1350000
> 
> Doing this I get correct output from scaling_available_frequencies and
> scaling_boost_frequencies and the driver seems to select these
> frequences. However when reading from cpufreq_cur_freq, which I think
> returns the frequency of the armclk, the maximum freq never exceeds
> 1.5GHz. So effectively the additional clocking data and opps are not used.
> 
> I wonder this happens? Is there some kind of limit enforced?

Have you also extended the array of allowed APLL settings in
drivers/clk/clk-exynos4.c?

Best regards,
Tomasz

  reply	other threads:[~2014-07-19 20:54 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-14 13:38 [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham
2014-07-14 13:38 ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 1/6] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 12:55   ` Tomasz Figa
2014-07-19 12:55     ` Tomasz Figa
2014-07-29  5:35     ` Thomas Abraham
2014-07-29  5:35       ` Thomas Abraham
2014-07-29  9:57       ` Tomasz Figa
2014-07-29  9:57         ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 2/6] clk: samsung: register exynos5420 apll/kpll configuration data Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 12:57   ` Tomasz Figa
2014-07-19 12:57     ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 3/6] clk: exynos: use cpu-clock provider type to represent arm clock Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:06   ` Tomasz Figa
2014-07-19 13:06     ` Tomasz Figa
2014-07-14 13:38 ` [PATCH v7 4/6] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:18   ` Tomasz Figa
2014-07-19 13:18     ` Tomasz Figa
2014-07-29  5:36     ` Thomas Abraham
2014-07-29  5:36       ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 5/6] ARM: Exynos: switch to using generic cpufreq driver for exynos4210/5250/5420 Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:27   ` Tomasz Figa
2014-07-19 13:27     ` Tomasz Figa
2014-07-29  5:37     ` Thomas Abraham
2014-07-29  5:37       ` Thomas Abraham
2014-07-14 13:38 ` [PATCH v7 6/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support Thomas Abraham
2014-07-14 13:38   ` Thomas Abraham
2014-07-19 13:29   ` Tomasz Figa
2014-07-19 13:29     ` Tomasz Figa
2014-07-29  5:53     ` Thomas Abraham
2014-07-29  5:53       ` Thomas Abraham
2014-07-15  3:50 ` [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham
2014-07-15  3:50   ` Thomas Abraham
2014-07-17  5:58   ` Thomas Abraham
2014-07-17  5:58     ` Thomas Abraham
2014-07-18  0:44     ` Chanwoo Choi
2014-07-18  0:44       ` Chanwoo Choi
2014-07-18  2:04       ` Thomas Abraham
2014-07-18  2:04         ` Thomas Abraham
2014-07-19 19:20 ` Tobias Jakobi
2014-07-19 19:20   ` Tobias Jakobi
2014-07-19 20:54   ` Tomasz Figa [this message]
2014-07-19 20:54     ` Tomasz Figa
2014-07-19 21:17     ` Tobias Jakobi
2014-07-19 21:17       ` Tobias Jakobi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53CADAEE.2070009@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=cw00.choi@samsung.com \
    --cc=heiko@sntech.de \
    --cc=kgene.kim@samsung.com \
    --cc=l.majewski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=liquid.acid@gmx.net \
    --cc=mturquette@linaro.org \
    --cc=t.figa@samsung.com \
    --cc=thomas.ab@samsung.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.