From: Thomas Abraham <ta.omasab@gmail.com> To: Tomasz Figa <tomasz.figa@gmail.com> Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Lukasz Majewski" <l.majewski@samsung.com>, "Kukjin Kim" <kgene.kim@samsung.com>, "Mike Turquette" <mturquette@linaro.org>, "Heiko Stübner" <heiko@sntech.de>, "Viresh Kumar" <viresh.kumar@linaro.org>, "Tomasz Figa" <t.figa@samsung.com>, "Chanwoo Choi" <cw00.choi@samsung.com>, "linux-samsung-soc@vger.kernel.org" <linux-samsung-soc@vger.kernel.org> Subject: Re: [PATCH v7 4/6] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Date: Tue, 29 Jul 2014 11:06:56 +0530 [thread overview] Message-ID: <CAJuA9aiuDVWqzx6-w4U7QTKnXgREr5xeqwc6ReGo32pboKpYYQ@mail.gmail.com> (raw) In-Reply-To: <53CA7008.7000106@gmail.com> Hi Tomasz, On Sat, Jul 19, 2014 at 6:48 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Thomas, > > Please see my comments inline. > > On 14.07.2014 15:38, Thomas Abraham wrote: >> From: Thomas Abraham <thomas.ab@samsung.com> >> >> For Exynos 4210/5250/5420 based platforms, add CPU nodes, operating points and >> cpu clock data for migrating from Exynos specific cpufreq driver to using >> generic cpufreq drivers. > > [snip] > >> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi >> index ee3001f..c3a73bf 100644 >> --- a/arch/arm/boot/dts/exynos4210.dtsi >> +++ b/arch/arm/boot/dts/exynos4210.dtsi >> @@ -31,6 +31,33 @@ >> pinctrl2 = &pinctrl_2; >> }; >> >> + cpus { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cpu@0 { > > nit: Missing blank line after last property. > > The cluster ID field of MPIDR on Exynos4210 is 0x9 not zero, which means > that this should be cpu@900. > >> + device_type = "cpu"; >> + compatible = "arm,cortex-a9"; >> + reg = <0>; > > reg = <0x900>; > >> + clocks = <&clock CLK_ARM_CLK>; >> + clock-names = "cpu"; >> + >> + operating-points = < >> + 1200000 1250000 >> + 1000000 1150000 >> + 800000 1075000 >> + 500000 975000 >> + 400000 975000 >> + 200000 950000 >> + >; >> + }; >> + >> + cpu@1 { > > cpu@901 > >> + device_type = "cpu"; >> + compatible = "arm,cortex-a9"; >> + reg = <1>; > > reg = <0x901>; > >> + }; > > In general this wouldn't have even booted, because there were several > places where code relied on CPUs being 0, 1, 2... However I have sent > necessary fixes and they should hit linux-next in few days. > >> + }; >> + >> sysram@02020000 { >> compatible = "mmio-sram"; >> reg = <0x02020000 0x20000>; > > [snip] > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 834fb5a..66b0f98 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -63,6 +63,29 @@ >> compatible = "arm,cortex-a15"; >> reg = <0>; >> clock-frequency = <1700000000>; >> + >> + clocks = <&clock CLK_ARM_CLK>; >> + clock-names = "cpu"; >> + >> + operating-points = < >> + 1700000 1300000 >> + 1600000 1250000 >> + 1500000 1225000 >> + 1400000 1200000 >> + 1300000 1150000 >> + 1200000 1125000 >> + 1100000 1100000 >> + 1000000 1075000 >> + 900000 1050000 >> + 800000 1025000 >> + 700000 1012500 >> + 600000 1000000 >> + 500000 975000 >> + 400000 950000 >> + 300000 937500 >> + 200000 925000 >> + >; >> + clock-latency = <200000>; > > I don't see this property specified for Exynos4210. Have you missed it > there? Okay, I have specified this for Exynos4210 as well. Thanks, Thomas. > > Best regards, > Tomasz > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: ta.omasab@gmail.com (Thomas Abraham) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v7 4/6] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Date: Tue, 29 Jul 2014 11:06:56 +0530 [thread overview] Message-ID: <CAJuA9aiuDVWqzx6-w4U7QTKnXgREr5xeqwc6ReGo32pboKpYYQ@mail.gmail.com> (raw) In-Reply-To: <53CA7008.7000106@gmail.com> Hi Tomasz, On Sat, Jul 19, 2014 at 6:48 PM, Tomasz Figa <tomasz.figa@gmail.com> wrote: > Hi Thomas, > > Please see my comments inline. > > On 14.07.2014 15:38, Thomas Abraham wrote: >> From: Thomas Abraham <thomas.ab@samsung.com> >> >> For Exynos 4210/5250/5420 based platforms, add CPU nodes, operating points and >> cpu clock data for migrating from Exynos specific cpufreq driver to using >> generic cpufreq drivers. > > [snip] > >> diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi >> index ee3001f..c3a73bf 100644 >> --- a/arch/arm/boot/dts/exynos4210.dtsi >> +++ b/arch/arm/boot/dts/exynos4210.dtsi >> @@ -31,6 +31,33 @@ >> pinctrl2 = &pinctrl_2; >> }; >> >> + cpus { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + cpu at 0 { > > nit: Missing blank line after last property. > > The cluster ID field of MPIDR on Exynos4210 is 0x9 not zero, which means > that this should be cpu at 900. > >> + device_type = "cpu"; >> + compatible = "arm,cortex-a9"; >> + reg = <0>; > > reg = <0x900>; > >> + clocks = <&clock CLK_ARM_CLK>; >> + clock-names = "cpu"; >> + >> + operating-points = < >> + 1200000 1250000 >> + 1000000 1150000 >> + 800000 1075000 >> + 500000 975000 >> + 400000 975000 >> + 200000 950000 >> + >; >> + }; >> + >> + cpu at 1 { > > cpu at 901 > >> + device_type = "cpu"; >> + compatible = "arm,cortex-a9"; >> + reg = <1>; > > reg = <0x901>; > >> + }; > > In general this wouldn't have even booted, because there were several > places where code relied on CPUs being 0, 1, 2... However I have sent > necessary fixes and they should hit linux-next in few days. > >> + }; >> + >> sysram at 02020000 { >> compatible = "mmio-sram"; >> reg = <0x02020000 0x20000>; > > [snip] > >> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi >> index 834fb5a..66b0f98 100644 >> --- a/arch/arm/boot/dts/exynos5250.dtsi >> +++ b/arch/arm/boot/dts/exynos5250.dtsi >> @@ -63,6 +63,29 @@ >> compatible = "arm,cortex-a15"; >> reg = <0>; >> clock-frequency = <1700000000>; >> + >> + clocks = <&clock CLK_ARM_CLK>; >> + clock-names = "cpu"; >> + >> + operating-points = < >> + 1700000 1300000 >> + 1600000 1250000 >> + 1500000 1225000 >> + 1400000 1200000 >> + 1300000 1150000 >> + 1200000 1125000 >> + 1100000 1100000 >> + 1000000 1075000 >> + 900000 1050000 >> + 800000 1025000 >> + 700000 1012500 >> + 600000 1000000 >> + 500000 975000 >> + 400000 950000 >> + 300000 937500 >> + 200000 925000 >> + >; >> + clock-latency = <200000>; > > I don't see this property specified for Exynos4210. Have you missed it > there? Okay, I have specified this for Exynos4210 as well. Thanks, Thomas. > > Best regards, > Tomasz > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel at lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2014-07-29 5:36 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-14 13:38 [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-14 13:38 ` [PATCH v7 1/6] clk: samsung: add infrastructure to register cpu clocks Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 12:55 ` Tomasz Figa 2014-07-19 12:55 ` Tomasz Figa 2014-07-29 5:35 ` Thomas Abraham 2014-07-29 5:35 ` Thomas Abraham 2014-07-29 9:57 ` Tomasz Figa 2014-07-29 9:57 ` Tomasz Figa 2014-07-14 13:38 ` [PATCH v7 2/6] clk: samsung: register exynos5420 apll/kpll configuration data Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 12:57 ` Tomasz Figa 2014-07-19 12:57 ` Tomasz Figa 2014-07-14 13:38 ` [PATCH v7 3/6] clk: exynos: use cpu-clock provider type to represent arm clock Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 13:06 ` Tomasz Figa 2014-07-19 13:06 ` Tomasz Figa 2014-07-14 13:38 ` [PATCH v7 4/6] ARM: dts: Exynos: add cpu nodes, opp and cpu clock configuration data Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 13:18 ` Tomasz Figa 2014-07-19 13:18 ` Tomasz Figa 2014-07-29 5:36 ` Thomas Abraham [this message] 2014-07-29 5:36 ` Thomas Abraham 2014-07-14 13:38 ` [PATCH v7 5/6] ARM: Exynos: switch to using generic cpufreq driver for exynos4210/5250/5420 Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 13:27 ` Tomasz Figa 2014-07-19 13:27 ` Tomasz Figa 2014-07-29 5:37 ` Thomas Abraham 2014-07-29 5:37 ` Thomas Abraham 2014-07-14 13:38 ` [PATCH v7 6/6] cpufreq: exynos: remove exynos4210/5250 specific cpufreq driver support Thomas Abraham 2014-07-14 13:38 ` Thomas Abraham 2014-07-19 13:29 ` Tomasz Figa 2014-07-19 13:29 ` Tomasz Figa 2014-07-29 5:53 ` Thomas Abraham 2014-07-29 5:53 ` Thomas Abraham 2014-07-15 3:50 ` [PATCH v7 0/6] cpufreq: use generic cpufreq drivers for exynos platforms Thomas Abraham 2014-07-15 3:50 ` Thomas Abraham 2014-07-17 5:58 ` Thomas Abraham 2014-07-17 5:58 ` Thomas Abraham 2014-07-18 0:44 ` Chanwoo Choi 2014-07-18 0:44 ` Chanwoo Choi 2014-07-18 2:04 ` Thomas Abraham 2014-07-18 2:04 ` Thomas Abraham 2014-07-19 19:20 ` Tobias Jakobi 2014-07-19 19:20 ` Tobias Jakobi 2014-07-19 20:54 ` Tomasz Figa 2014-07-19 20:54 ` Tomasz Figa 2014-07-19 21:17 ` Tobias Jakobi 2014-07-19 21:17 ` Tobias Jakobi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAJuA9aiuDVWqzx6-w4U7QTKnXgREr5xeqwc6ReGo32pboKpYYQ@mail.gmail.com \ --to=ta.omasab@gmail.com \ --cc=cw00.choi@samsung.com \ --cc=heiko@sntech.de \ --cc=kgene.kim@samsung.com \ --cc=l.majewski@samsung.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-pm@vger.kernel.org \ --cc=linux-samsung-soc@vger.kernel.org \ --cc=mturquette@linaro.org \ --cc=t.figa@samsung.com \ --cc=tomasz.figa@gmail.com \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.