From: Alexander Graf <agraf@suse.de> To: Mario Smarduch <m.smarduch@samsung.com>, kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com, christoffer.dall@linaro.org, pbonzini@redhat.com, gleb@kernel.org, xiantao.zhang@intel.com, borntraeger@de.ibm.com, cornelia.huck@de.ibm.com Cc: xiaoguangrong@linux.vnet.ibm.com, steve.capper@arm.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, jays.lee@samsung.com, sungjinn.chung@samsung.com Subject: Re: [PATCH v9 1/4] arm: add ARMv7 HYP API to flush VM TLBs, change generic TLB flush to support arch flush Date: Fri, 25 Jul 2014 08:12:07 +0200 [thread overview] Message-ID: <53D1F537.2070306@suse.de> (raw) In-Reply-To: <1406249768-25315-2-git-send-email-m.smarduch@samsung.com> On 25.07.14 02:56, Mario Smarduch wrote: > Patch adds HYP interface for global VM TLB invalidation without address > parameter. Generic VM TLB flush calls ARMv7 arch defined TLB flush function. > > Signed-off-by: Mario Smarduch <m.smarduch@samsung.com> > --- > arch/arm/include/asm/kvm_asm.h | 1 + > arch/arm/include/asm/kvm_host.h | 1 + > arch/arm/kvm/Kconfig | 1 + > arch/arm/kvm/interrupts.S | 12 ++++++++++++ > arch/arm/kvm/mmu.c | 17 +++++++++++++++++ > virt/kvm/Kconfig | 3 +++ > virt/kvm/kvm_main.c | 4 ++++ > 7 files changed, 39 insertions(+) > > diff --git a/arch/arm/include/asm/kvm_asm.h b/arch/arm/include/asm/kvm_asm.h > index 53b3c4a..21bc519 100644 > --- a/arch/arm/include/asm/kvm_asm.h > +++ b/arch/arm/include/asm/kvm_asm.h > @@ -78,6 +78,7 @@ extern char __kvm_hyp_code_end[]; > > extern void __kvm_flush_vm_context(void); > extern void __kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa); > +extern void __kvm_tlb_flush_vmid(struct kvm *kvm); > > extern int __kvm_vcpu_run(struct kvm_vcpu *vcpu); > #endif > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > index 193ceaf..042206f 100644 > --- a/arch/arm/include/asm/kvm_host.h > +++ b/arch/arm/include/asm/kvm_host.h > @@ -230,5 +230,6 @@ int kvm_perf_teardown(void); > > u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid); > int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value); > +void kvm_arch_flush_remote_tlbs(struct kvm *); > > #endif /* __ARM_KVM_HOST_H__ */ > diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig > index 466bd29..44d3b6f 100644 > --- a/arch/arm/kvm/Kconfig > +++ b/arch/arm/kvm/Kconfig > @@ -22,6 +22,7 @@ config KVM > select ANON_INODES > select HAVE_KVM_CPU_RELAX_INTERCEPT > select KVM_MMIO > + select HAVE_KVM_ARCH_TLB_FLUSH_ALL > select KVM_ARM_HOST > depends on ARM_VIRT_EXT && ARM_LPAE > ---help--- > diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S > index 0d68d40..1258d46 100644 > --- a/arch/arm/kvm/interrupts.S > +++ b/arch/arm/kvm/interrupts.S > @@ -66,6 +66,18 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) > bx lr > ENDPROC(__kvm_tlb_flush_vmid_ipa) > > +/** > + * void __kvm_tlb_flush_vmid(struct kvm *kvm) - Flush per-VMID TLBs > + * > + * Reuses __kvm_tlb_flush_vmid_ipa() for ARMv7, without passing address > + * parameter > + */ > + > +ENTRY(__kvm_tlb_flush_vmid) > + b __kvm_tlb_flush_vmid_ipa > +ENDPROC(__kvm_tlb_flush_vmid) > + > + > /******************************************************************** > * Flush TLBs and instruction caches of all CPUs inside the inner-shareable > * domain, for all VMIDs > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 2ac9588..35254c6 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -56,6 +56,23 @@ static void kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa) > kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, kvm, ipa); > } > > +#ifdef CONFIG_ARM Why the ifdef? We're in ARM code here, no? > +/** > + * kvm_arch_flush_remote_tlbs() - flush all VM TLB entries > + * @kvm: pointer to kvm structure. > + * > + * Interface to HYP function to flush all VM TLB entries without address > + * parameter. In HYP mode reuses __kvm_tlb_flush_vmid_ipa() function used by > + * kvm_tlb_flush_vmid_ipa(). > + */ > +void kvm_arch_flush_remote_tlbs(struct kvm *kvm) > +{ > + if (kvm) > + kvm_call_hyp(__kvm_tlb_flush_vmid, kvm); I don't see why we should ever call this function with kvm==NULL. Alex
WARNING: multiple messages have this Message-ID (diff)
From: agraf@suse.de (Alexander Graf) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v9 1/4] arm: add ARMv7 HYP API to flush VM TLBs, change generic TLB flush to support arch flush Date: Fri, 25 Jul 2014 08:12:07 +0200 [thread overview] Message-ID: <53D1F537.2070306@suse.de> (raw) In-Reply-To: <1406249768-25315-2-git-send-email-m.smarduch@samsung.com> On 25.07.14 02:56, Mario Smarduch wrote: > Patch adds HYP interface for global VM TLB invalidation without address > parameter. Generic VM TLB flush calls ARMv7 arch defined TLB flush function. > > Signed-off-by: Mario Smarduch <m.smarduch@samsung.com> > --- > arch/arm/include/asm/kvm_asm.h | 1 + > arch/arm/include/asm/kvm_host.h | 1 + > arch/arm/kvm/Kconfig | 1 + > arch/arm/kvm/interrupts.S | 12 ++++++++++++ > arch/arm/kvm/mmu.c | 17 +++++++++++++++++ > virt/kvm/Kconfig | 3 +++ > virt/kvm/kvm_main.c | 4 ++++ > 7 files changed, 39 insertions(+) > > diff --git a/arch/arm/include/asm/kvm_asm.h b/arch/arm/include/asm/kvm_asm.h > index 53b3c4a..21bc519 100644 > --- a/arch/arm/include/asm/kvm_asm.h > +++ b/arch/arm/include/asm/kvm_asm.h > @@ -78,6 +78,7 @@ extern char __kvm_hyp_code_end[]; > > extern void __kvm_flush_vm_context(void); > extern void __kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa); > +extern void __kvm_tlb_flush_vmid(struct kvm *kvm); > > extern int __kvm_vcpu_run(struct kvm_vcpu *vcpu); > #endif > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > index 193ceaf..042206f 100644 > --- a/arch/arm/include/asm/kvm_host.h > +++ b/arch/arm/include/asm/kvm_host.h > @@ -230,5 +230,6 @@ int kvm_perf_teardown(void); > > u64 kvm_arm_timer_get_reg(struct kvm_vcpu *, u64 regid); > int kvm_arm_timer_set_reg(struct kvm_vcpu *, u64 regid, u64 value); > +void kvm_arch_flush_remote_tlbs(struct kvm *); > > #endif /* __ARM_KVM_HOST_H__ */ > diff --git a/arch/arm/kvm/Kconfig b/arch/arm/kvm/Kconfig > index 466bd29..44d3b6f 100644 > --- a/arch/arm/kvm/Kconfig > +++ b/arch/arm/kvm/Kconfig > @@ -22,6 +22,7 @@ config KVM > select ANON_INODES > select HAVE_KVM_CPU_RELAX_INTERCEPT > select KVM_MMIO > + select HAVE_KVM_ARCH_TLB_FLUSH_ALL > select KVM_ARM_HOST > depends on ARM_VIRT_EXT && ARM_LPAE > ---help--- > diff --git a/arch/arm/kvm/interrupts.S b/arch/arm/kvm/interrupts.S > index 0d68d40..1258d46 100644 > --- a/arch/arm/kvm/interrupts.S > +++ b/arch/arm/kvm/interrupts.S > @@ -66,6 +66,18 @@ ENTRY(__kvm_tlb_flush_vmid_ipa) > bx lr > ENDPROC(__kvm_tlb_flush_vmid_ipa) > > +/** > + * void __kvm_tlb_flush_vmid(struct kvm *kvm) - Flush per-VMID TLBs > + * > + * Reuses __kvm_tlb_flush_vmid_ipa() for ARMv7, without passing address > + * parameter > + */ > + > +ENTRY(__kvm_tlb_flush_vmid) > + b __kvm_tlb_flush_vmid_ipa > +ENDPROC(__kvm_tlb_flush_vmid) > + > + > /******************************************************************** > * Flush TLBs and instruction caches of all CPUs inside the inner-shareable > * domain, for all VMIDs > diff --git a/arch/arm/kvm/mmu.c b/arch/arm/kvm/mmu.c > index 2ac9588..35254c6 100644 > --- a/arch/arm/kvm/mmu.c > +++ b/arch/arm/kvm/mmu.c > @@ -56,6 +56,23 @@ static void kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa) > kvm_call_hyp(__kvm_tlb_flush_vmid_ipa, kvm, ipa); > } > > +#ifdef CONFIG_ARM Why the ifdef? We're in ARM code here, no? > +/** > + * kvm_arch_flush_remote_tlbs() - flush all VM TLB entries > + * @kvm: pointer to kvm structure. > + * > + * Interface to HYP function to flush all VM TLB entries without address > + * parameter. In HYP mode reuses __kvm_tlb_flush_vmid_ipa() function used by > + * kvm_tlb_flush_vmid_ipa(). > + */ > +void kvm_arch_flush_remote_tlbs(struct kvm *kvm) > +{ > + if (kvm) > + kvm_call_hyp(__kvm_tlb_flush_vmid, kvm); I don't see why we should ever call this function with kvm==NULL. Alex
next prev parent reply other threads:[~2014-07-25 6:12 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-07-25 0:56 [PATCH v9 0/4] arm: dirty page logging support for ARMv7 Mario Smarduch 2014-07-25 0:56 ` Mario Smarduch 2014-07-25 0:56 ` [PATCH v9 1/4] arm: add ARMv7 HYP API to flush VM TLBs, change generic TLB flush to support arch flush Mario Smarduch 2014-07-25 0:56 ` Mario Smarduch 2014-07-25 6:12 ` Alexander Graf [this message] 2014-07-25 6:12 ` Alexander Graf 2014-07-25 17:37 ` Mario Smarduch 2014-07-25 17:37 ` Mario Smarduch 2014-08-08 17:50 ` [PATCH v9 1/4] arm: add ARMv7 HYP API to flush VM TLBs ... - looking for comments Mario Smarduch 2014-08-08 17:50 ` Mario Smarduch 2014-08-11 19:12 ` [PATCH v9 1/4] arm: add ARMv7 HYP API to flush VM TLBs, change generic TLB flush to support arch flush Christoffer Dall 2014-08-11 19:12 ` Christoffer Dall 2014-08-11 23:54 ` Mario Smarduch 2014-08-11 23:54 ` Mario Smarduch 2014-07-25 0:56 ` [PATCH v9 2/4] arm: ARMv7 dirty page logging inital mem region write protect (w/no huge PUD support) Mario Smarduch 2014-07-25 0:56 ` Mario Smarduch 2014-07-25 6:16 ` Alexander Graf 2014-07-25 6:16 ` Alexander Graf 2014-07-25 17:45 ` Mario Smarduch 2014-07-25 17:45 ` Mario Smarduch 2014-08-11 19:12 ` Christoffer Dall 2014-08-11 19:12 ` Christoffer Dall 2014-08-12 0:16 ` Mario Smarduch 2014-08-12 0:16 ` Mario Smarduch 2014-08-12 9:32 ` Christoffer Dall 2014-08-12 9:32 ` Christoffer Dall 2014-08-12 23:17 ` Mario Smarduch 2014-08-12 23:17 ` Mario Smarduch 2014-08-12 1:36 ` Mario Smarduch 2014-08-12 1:36 ` Mario Smarduch 2014-08-12 9:36 ` Christoffer Dall 2014-08-12 9:36 ` Christoffer Dall 2014-08-12 21:08 ` Mario Smarduch 2014-08-12 21:08 ` Mario Smarduch 2014-07-25 0:56 ` [PATCH v9 3/4] arm: dirty log write protect mgmt. Moved x86, armv7 to generic, set armv8 ia64 mips powerpc s390 arch specific Mario Smarduch 2014-07-25 0:56 ` Mario Smarduch 2014-08-11 19:13 ` Christoffer Dall 2014-08-11 19:13 ` Christoffer Dall 2014-08-12 0:24 ` Mario Smarduch 2014-08-12 0:24 ` Mario Smarduch 2014-07-25 0:56 ` [PATCH v9 4/4] arm: ARMv7 dirty page logging 2nd stage page fault handling support Mario Smarduch 2014-07-25 0:56 ` Mario Smarduch 2014-08-11 19:13 ` Christoffer Dall 2014-08-11 19:13 ` Christoffer Dall 2014-08-12 1:25 ` Mario Smarduch 2014-08-12 1:25 ` Mario Smarduch 2014-08-12 9:50 ` Christoffer Dall 2014-08-12 9:50 ` Christoffer Dall 2014-08-13 1:27 ` Mario Smarduch 2014-08-13 1:27 ` Mario Smarduch 2014-08-13 7:30 ` Christoffer Dall 2014-08-13 7:30 ` Christoffer Dall 2014-08-14 1:20 ` Mario Smarduch 2014-08-14 1:20 ` Mario Smarduch 2014-08-15 0:01 ` Mario Smarduch 2014-08-15 0:01 ` Mario Smarduch 2014-08-18 12:51 ` Christoffer Dall 2014-08-18 12:51 ` Christoffer Dall 2014-08-18 17:42 ` Mario Smarduch 2014-08-18 17:42 ` Mario Smarduch
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53D1F537.2070306@suse.de \ --to=agraf@suse.de \ --cc=borntraeger@de.ibm.com \ --cc=christoffer.dall@linaro.org \ --cc=cornelia.huck@de.ibm.com \ --cc=gleb@kernel.org \ --cc=jays.lee@samsung.com \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=m.smarduch@samsung.com \ --cc=marc.zyngier@arm.com \ --cc=pbonzini@redhat.com \ --cc=steve.capper@arm.com \ --cc=sungjinn.chung@samsung.com \ --cc=xiantao.zhang@intel.com \ --cc=xiaoguangrong@linux.vnet.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.