All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
@ 2014-07-20 21:36 ` Himangi Saraogi
  0 siblings, 0 replies; 8+ messages in thread
From: Himangi Saraogi @ 2014-07-20 21:36 UTC (permalink / raw)
  To: Julia Lawall, Gilles Muller, Nicolas Palix, Michal Marek, cocci,
	linux-kernel

This script detects cases where BUG() follows an if condition on an
expression and replaces the if condition and BUG() with a BUG_ON having
the conditional expression of the if statement as argument.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
 scripts/coccinelle/misc/bugon.cocci | 62 +++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 scripts/coccinelle/misc/bugon.cocci

diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
new file mode 100644
index 0000000..556456c
--- /dev/null
+++ b/scripts/coccinelle/misc/bugon.cocci
@@ -0,0 +1,62 @@
+/// Use BUG_ON instead of a if condition followed by BUG.
+///
+//# This makes an effort to find cases where BUG() follows an if
+//# condition on an expression and replaces the if condition and BUG()
+//# with a BUG_ON having the conditional expression of the if statement
+//# as argument.
+//
+// Confidence: High
+// Copyright: (C) 2014 Himangi Saraogi.  GPLv2.
+// Comments:
+// Options: --no-includes, --include-headers
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+//  For context mode
+//----------------------------------------------------------
+
+@depends on context@
+expression e;
+@@
+
+*if (e) BUG();
+
+//----------------------------------------------------------
+//  For patch mode
+//----------------------------------------------------------
+
+@depends on patch@
+expression e;
+@@
+
+-if (e) BUG();
++BUG_ON(e);
+
+//----------------------------------------------------------
+//  For org and report mode
+//----------------------------------------------------------
+
+@r@
+expression e;
+position p;
+@@
+
+ if (e) BUG@p ();
+
+@script:python depends on org@
+p << r.p;
+@@
+
+coccilib.org.print_todo(p[0], "WARNING use BUG_ON")
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg="WARNING: Use BUG_ON"
+coccilib.report.print_report(p[0], msg)
+
-- 
1.9.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
@ 2014-07-20 21:36 ` Himangi Saraogi
  0 siblings, 0 replies; 8+ messages in thread
From: Himangi Saraogi @ 2014-07-20 21:36 UTC (permalink / raw)
  To: cocci

This script detects cases where BUG() follows an if condition on an
expression and replaces the if condition and BUG() with a BUG_ON having
the conditional expression of the if statement as argument.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
---
 scripts/coccinelle/misc/bugon.cocci | 62 +++++++++++++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)
 create mode 100644 scripts/coccinelle/misc/bugon.cocci

diff --git a/scripts/coccinelle/misc/bugon.cocci b/scripts/coccinelle/misc/bugon.cocci
new file mode 100644
index 0000000..556456c
--- /dev/null
+++ b/scripts/coccinelle/misc/bugon.cocci
@@ -0,0 +1,62 @@
+/// Use BUG_ON instead of a if condition followed by BUG.
+///
+//# This makes an effort to find cases where BUG() follows an if
+//# condition on an expression and replaces the if condition and BUG()
+//# with a BUG_ON having the conditional expression of the if statement
+//# as argument.
+//
+// Confidence: High
+// Copyright: (C) 2014 Himangi Saraogi.  GPLv2.
+// Comments:
+// Options: --no-includes, --include-headers
+
+virtual patch
+virtual context
+virtual org
+virtual report
+
+//----------------------------------------------------------
+//  For context mode
+//----------------------------------------------------------
+
+ at depends on context@
+expression e;
+@@
+
+*if (e) BUG();
+
+//----------------------------------------------------------
+//  For patch mode
+//----------------------------------------------------------
+
+ at depends on patch@
+expression e;
+@@
+
+-if (e) BUG();
++BUG_ON(e);
+
+//----------------------------------------------------------
+//  For org and report mode
+//----------------------------------------------------------
+
+ at r@
+expression e;
+position p;
+@@
+
+ if (e) BUG at p ();
+
+ at script:python depends on org@
+p << r.p;
+@@
+
+coccilib.org.print_todo(p[0], "WARNING use BUG_ON")
+
+@script:python depends on report@
+p << r.p;
+@@
+
+msg="WARNING: Use BUG_ON"
+coccilib.report.print_report(p[0], msg)
+
-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
  2014-07-20 21:36 ` [Cocci] " Himangi Saraogi
@ 2014-08-05 14:27   ` Michal Marek
  -1 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2014-08-05 14:27 UTC (permalink / raw)
  To: Himangi Saraogi
  Cc: Julia Lawall, Gilles Muller, Nicolas Palix, cocci, linux-kernel

On 2014-07-20 23:36, Himangi Saraogi wrote:
> This script detects cases where BUG() follows an if condition on an
> expression and replaces the if condition and BUG() with a BUG_ON having
> the conditional expression of the if statement as argument.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Is this a result of some internal review, or where does Julia's Acked-by
come from? I'm just wondering, because I haven't seen any previous
version of this patch.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
@ 2014-08-05 14:27   ` Michal Marek
  0 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2014-08-05 14:27 UTC (permalink / raw)
  To: cocci

On 2014-07-20 23:36, Himangi Saraogi wrote:
> This script detects cases where BUG() follows an if condition on an
> expression and replaces the if condition and BUG() with a BUG_ON having
> the conditional expression of the if statement as argument.
> 
> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> Acked-by: Julia Lawall <julia.lawall@lip6.fr>

Is this a result of some internal review, or where does Julia's Acked-by
come from? I'm just wondering, because I haven't seen any previous
version of this patch.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
  2014-08-05 14:27   ` [Cocci] " Michal Marek
@ 2014-08-05 18:16     ` Julia Lawall
  -1 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2014-08-05 18:16 UTC (permalink / raw)
  To: Michal Marek
  Cc: Himangi Saraogi, Gilles Muller, Nicolas Palix, cocci, linux-kernel



On Tue, 5 Aug 2014, Michal Marek wrote:

> On 2014-07-20 23:36, Himangi Saraogi wrote:
> > This script detects cases where BUG() follows an if condition on an
> > expression and replaces the if condition and BUG() with a BUG_ON having
> > the conditional expression of the if statement as argument.
> > 
> > Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> Is this a result of some internal review, or where does Julia's Acked-by
> come from? I'm just wondering, because I haven't seen any previous
> version of this patch.

She sent it to me first.  It's OK with me.

julia

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
@ 2014-08-05 18:16     ` Julia Lawall
  0 siblings, 0 replies; 8+ messages in thread
From: Julia Lawall @ 2014-08-05 18:16 UTC (permalink / raw)
  To: cocci



On Tue, 5 Aug 2014, Michal Marek wrote:

> On 2014-07-20 23:36, Himangi Saraogi wrote:
> > This script detects cases where BUG() follows an if condition on an
> > expression and replaces the if condition and BUG() with a BUG_ON having
> > the conditional expression of the if statement as argument.
> > 
> > Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
> > Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> 
> Is this a result of some internal review, or where does Julia's Acked-by
> come from? I'm just wondering, because I haven't seen any previous
> version of this patch.

She sent it to me first.  It's OK with me.

julia

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
  2014-08-05 18:16     ` [Cocci] " Julia Lawall
@ 2014-08-06  9:34       ` Michal Marek
  -1 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2014-08-06  9:34 UTC (permalink / raw)
  To: Julia Lawall
  Cc: Himangi Saraogi, Gilles Muller, Nicolas Palix, cocci, linux-kernel

On 2014-08-05 20:16, Julia Lawall wrote:
> 
> 
> On Tue, 5 Aug 2014, Michal Marek wrote:
> 
>> On 2014-07-20 23:36, Himangi Saraogi wrote:
>>> This script detects cases where BUG() follows an if condition on an
>>> expression and replaces the if condition and BUG() with a BUG_ON having
>>> the conditional expression of the if statement as argument.
>>>
>>> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
>>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> Is this a result of some internal review, or where does Julia's Acked-by
>> come from? I'm just wondering, because I haven't seen any previous
>> version of this patch.
> 
> She sent it to me first.  It's OK with me.

OK, thanks for confirming. I'm going to merge this and the previous
patches by Himangi.

Michal

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [Cocci] [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON
@ 2014-08-06  9:34       ` Michal Marek
  0 siblings, 0 replies; 8+ messages in thread
From: Michal Marek @ 2014-08-06  9:34 UTC (permalink / raw)
  To: cocci

On 2014-08-05 20:16, Julia Lawall wrote:
> 
> 
> On Tue, 5 Aug 2014, Michal Marek wrote:
> 
>> On 2014-07-20 23:36, Himangi Saraogi wrote:
>>> This script detects cases where BUG() follows an if condition on an
>>> expression and replaces the if condition and BUG() with a BUG_ON having
>>> the conditional expression of the if statement as argument.
>>>
>>> Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
>>> Acked-by: Julia Lawall <julia.lawall@lip6.fr>
>>
>> Is this a result of some internal review, or where does Julia's Acked-by
>> come from? I'm just wondering, because I haven't seen any previous
>> version of this patch.
> 
> She sent it to me first.  It's OK with me.

OK, thanks for confirming. I'm going to merge this and the previous
patches by Himangi.

Michal

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2014-08-06  9:34 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-20 21:36 [PATCH] Coccinelle: Script to replace if and BUG with BUG_ON Himangi Saraogi
2014-07-20 21:36 ` [Cocci] " Himangi Saraogi
2014-08-05 14:27 ` Michal Marek
2014-08-05 14:27   ` [Cocci] " Michal Marek
2014-08-05 18:16   ` Julia Lawall
2014-08-05 18:16     ` [Cocci] " Julia Lawall
2014-08-06  9:34     ` Michal Marek
2014-08-06  9:34       ` [Cocci] " Michal Marek

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.