All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Figa <tomasz.figa@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Naveen Krishna Chatradhi <ch.naveen@samsung.com>
Cc: Naveen Krishna <naveenkrishna.ch@gmail.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	"cpgs ." <cpgs@samsung.com>,
	Thomas Abraham <thomas.ab@samsung.com>
Subject: Re: [PATCH 05/14] pinctrl: exynos: Add driver data for Exynos7
Date: Tue, 02 Sep 2014 14:41:14 +0200	[thread overview]
Message-ID: <5405BAEA.9030100@gmail.com> (raw)
In-Reply-To: <CACRpkdZc=d+pr1ofEEp+1MoZUah8T7_LOfwM8bT-TsT+VoDgwQ@mail.gmail.com>

Hi Linus,

On 02.09.2014 14:38, Linus Walleij wrote:
> On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
> 
>> This patch adds driver data for Exynos7
>> to pinctrl-exynos driver. Exynos7 includes 229 multi-functional
>> input/output ports. There are 40 general port groups.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: linus.walleij@linaro.org
>> Cc: Thomas Abraham <thomas.ab@samsung.com>
> 
> Tomasz can you have a look at this (from your private mail...)?

Sure. In fact I already took a look last week, and this patch in
particular looks good. However I'm waiting for replies to my other
comments in this thread, as some of them affect also this patch.

Best regards,
Tomasz

WARNING: multiple messages have this Message-ID (diff)
From: tomasz.figa@gmail.com (Tomasz Figa)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/14] pinctrl: exynos: Add driver data for Exynos7
Date: Tue, 02 Sep 2014 14:41:14 +0200	[thread overview]
Message-ID: <5405BAEA.9030100@gmail.com> (raw)
In-Reply-To: <CACRpkdZc=d+pr1ofEEp+1MoZUah8T7_LOfwM8bT-TsT+VoDgwQ@mail.gmail.com>

Hi Linus,

On 02.09.2014 14:38, Linus Walleij wrote:
> On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
> 
>> This patch adds driver data for Exynos7
>> to pinctrl-exynos driver. Exynos7 includes 229 multi-functional
>> input/output ports. There are 40 general port groups.
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: linus.walleij at linaro.org
>> Cc: Thomas Abraham <thomas.ab@samsung.com>
> 
> Tomasz can you have a look at this (from your private mail...)?

Sure. In fact I already took a look last week, and this patch in
particular looks good. However I'm waiting for replies to my other
comments in this thread, as some of them affect also this patch.

Best regards,
Tomasz

  reply	other threads:[~2014-09-02 12:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27  9:48 [PATCH 01/14] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi
2014-08-27  9:48 ` Naveen Krishna Chatradhi
2014-08-27  9:48 ` [PATCH 02/14] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi
2014-08-27  9:48   ` Naveen Krishna Chatradhi
2014-08-27 10:15   ` Naveen Krishna Ch
2014-08-27 10:15     ` Naveen Krishna Ch
2014-08-27  9:48 ` [PATCH 03/14] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi
2014-08-27  9:48   ` Naveen Krishna Chatradhi
2014-08-27  9:48 ` [PATCH 04/14] clk: samsung: Add clock description for basic CMU blocks Naveen Krishna Chatradhi
2014-08-27  9:48   ` Naveen Krishna Chatradhi
2014-08-27 12:35   ` Tomasz Figa
2014-08-27 12:35     ` Tomasz Figa
2014-09-03  7:40     ` Naveen Krishna Ch
2014-09-03  7:40       ` Naveen Krishna Ch
2014-08-27  9:48 ` [PATCH 05/14] pinctrl: exynos: Add driver data for Exynos7 Naveen Krishna Chatradhi
2014-08-27  9:48   ` Naveen Krishna Chatradhi
2014-09-02 12:38   ` Linus Walleij
2014-09-02 12:38     ` Linus Walleij
2014-09-02 12:41     ` Tomasz Figa [this message]
2014-09-02 12:41       ` Tomasz Figa
2014-08-27  9:48 ` [PATCH 06/14] pinctrl: samsung: use CONFIG_PINCTRL_SAMSUNG symbol in makefile Naveen Krishna Chatradhi
2014-08-27  9:48   ` Naveen Krishna Chatradhi
2014-08-29 12:37   ` Linus Walleij
2014-08-29 12:37     ` Linus Walleij
2014-09-03  7:41     ` Naveen Krishna Ch
2014-09-03  7:41       ` Naveen Krishna Ch
2014-08-27 12:10 ` [PATCH 01/14] clk: samsung: add support for 145xx and 1460x PLLs Tomasz Figa
2014-08-27 12:10   ` Tomasz Figa
2014-09-03  7:37   ` Naveen Krishna Ch
2014-09-03  7:37     ` Naveen Krishna Ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5405BAEA.9030100@gmail.com \
    --to=tomasz.figa@gmail.com \
    --cc=ch.naveen@samsung.com \
    --cc=cpgs@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=naveenkrishna.ch@gmail.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.