From: Naveen Krishna Ch <naveenkrishna.ch@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
Tomasz Figa <t.figa@samsung.com>,
Thomas Abraham <thomas.ab@samsung.com>,
"cpgs ." <cpgs@samsung.com>,
Naveen Krishna Chatradhi <ch.naveen@samsung.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 06/14] pinctrl: samsung: use CONFIG_PINCTRL_SAMSUNG symbol in makefile
Date: Wed, 3 Sep 2014 13:11:43 +0530 [thread overview]
Message-ID: <CAHfPSqCND6QsuxiJjy7+jUb2PV3AVb=OtsGE=FL_mN5jJm6q0Q@mail.gmail.com> (raw)
In-Reply-To: <CACRpkda=LCT_P7czZ6mNX_7eS9nyKwxZrzXO2AAQ8W5RrehCcw@mail.gmail.com>
On 29 August 2014 18:07, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>
>> Samsung Exynos7 is a ARM64bit processor. Which does not select
>> the CONFIG_PLAT_SAMSUNG symbol. CONFIG_PINCTRL_SAMSUNG is being
>> selected for both PLAT_SAMSUNG and ARCH_EXYNOS7 symbols.
>>
>> This patch modifes the pinctrl/Makefile to use
>> CONFIG_PINCTRL_SAMSUNG symbol to compile the pinctrl/samsung/*.c
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: linus.walleij@linaro.org
>> Cc: Thomas Abraham <thomas.ab@samsung.com>
>
> Excellent catch, thanks, patch applied!
Thanks Linus.
>
> I should use this pattern on more places in the Makefile,
> I was confused by logically thinking that Kconfig symbols
> used in Makefile cannot be from a Kconfig one level below.
>
> Yours,
> Linus Walleij
--
Shine bright,
(: Nav :)
WARNING: multiple messages have this Message-ID (diff)
From: naveenkrishna.ch@gmail.com (Naveen Krishna Ch)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 06/14] pinctrl: samsung: use CONFIG_PINCTRL_SAMSUNG symbol in makefile
Date: Wed, 3 Sep 2014 13:11:43 +0530 [thread overview]
Message-ID: <CAHfPSqCND6QsuxiJjy7+jUb2PV3AVb=OtsGE=FL_mN5jJm6q0Q@mail.gmail.com> (raw)
In-Reply-To: <CACRpkda=LCT_P7czZ6mNX_7eS9nyKwxZrzXO2AAQ8W5RrehCcw@mail.gmail.com>
On 29 August 2014 18:07, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Aug 27, 2014 at 11:48 AM, Naveen Krishna Chatradhi
> <ch.naveen@samsung.com> wrote:
>
>> Samsung Exynos7 is a ARM64bit processor. Which does not select
>> the CONFIG_PLAT_SAMSUNG symbol. CONFIG_PINCTRL_SAMSUNG is being
>> selected for both PLAT_SAMSUNG and ARCH_EXYNOS7 symbols.
>>
>> This patch modifes the pinctrl/Makefile to use
>> CONFIG_PINCTRL_SAMSUNG symbol to compile the pinctrl/samsung/*.c
>>
>> Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> Cc: Tomasz Figa <t.figa@samsung.com>
>> Cc: linus.walleij at linaro.org
>> Cc: Thomas Abraham <thomas.ab@samsung.com>
>
> Excellent catch, thanks, patch applied!
Thanks Linus.
>
> I should use this pattern on more places in the Makefile,
> I was confused by logically thinking that Kconfig symbols
> used in Makefile cannot be from a Kconfig one level below.
>
> Yours,
> Linus Walleij
--
Shine bright,
(: Nav :)
next prev parent reply other threads:[~2014-09-03 7:41 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-27 9:48 [PATCH 01/14] clk: samsung: add support for 145xx and 1460x PLLs Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-08-27 9:48 ` [PATCH 02/14] clk: samsung: Factor out the common code to clk.c Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-08-27 10:15 ` Naveen Krishna Ch
2014-08-27 10:15 ` Naveen Krishna Ch
2014-08-27 9:48 ` [PATCH 03/14] clk: samsung: Add fixed_factor_clocks field to struct exynos_cmu_info Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-08-27 9:48 ` [PATCH 04/14] clk: samsung: Add clock description for basic CMU blocks Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-08-27 12:35 ` Tomasz Figa
2014-08-27 12:35 ` Tomasz Figa
2014-09-03 7:40 ` Naveen Krishna Ch
2014-09-03 7:40 ` Naveen Krishna Ch
2014-08-27 9:48 ` [PATCH 05/14] pinctrl: exynos: Add driver data for Exynos7 Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-09-02 12:38 ` Linus Walleij
2014-09-02 12:38 ` Linus Walleij
2014-09-02 12:41 ` Tomasz Figa
2014-09-02 12:41 ` Tomasz Figa
2014-08-27 9:48 ` [PATCH 06/14] pinctrl: samsung: use CONFIG_PINCTRL_SAMSUNG symbol in makefile Naveen Krishna Chatradhi
2014-08-27 9:48 ` Naveen Krishna Chatradhi
2014-08-29 12:37 ` Linus Walleij
2014-08-29 12:37 ` Linus Walleij
2014-09-03 7:41 ` Naveen Krishna Ch [this message]
2014-09-03 7:41 ` Naveen Krishna Ch
2014-08-27 12:10 ` [PATCH 01/14] clk: samsung: add support for 145xx and 1460x PLLs Tomasz Figa
2014-08-27 12:10 ` Tomasz Figa
2014-09-03 7:37 ` Naveen Krishna Ch
2014-09-03 7:37 ` Naveen Krishna Ch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHfPSqCND6QsuxiJjy7+jUb2PV3AVb=OtsGE=FL_mN5jJm6q0Q@mail.gmail.com' \
--to=naveenkrishna.ch@gmail.com \
--cc=ch.naveen@samsung.com \
--cc=cpgs@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=t.figa@samsung.com \
--cc=thomas.ab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.