From: Murali Karicheri <m-karicheri2@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pci@vger.kernel.org>, Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kumar Gala <galak@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Fri, 5 Sep 2014 14:33:54 -0400 [thread overview]
Message-ID: <540A0212.6060303@ti.com> (raw)
In-Reply-To: <7260053.FoBVhTXVfj@wuerfel>
On 09/05/2014 01:54 PM, Arnd Bergmann wrote:
> On Friday 05 September 2014 13:39:42 Murali Karicheri wrote:
>> +
>> /* enable RC mode in devcfg */
>> val = readl(reg_p);
>> - val&= ~PCIE_MODE_MASK;
>> - val |= PCIE_RC_MODE;
>> + port_id<<= 1;
>> + val&= ~(PCIE_MODE_MASK<< port_id);
>> + val |= (PCIE_RC_MODE<< port_id);
>> writel(val, reg_p);
>> + devm_iounmap(dev, reg_p);
>> + devm_release_mem_region(dev, res->start, resource_size(res));
>
> This looks like it's a shared register of some sort that doesn't
> really belong into the registers of a particular port. Could it
> be that it's actually for the PHY?
>
> Arnd
Arnd,
This a shared device configuration register between the two ports the
desciption states it is bootstrap configuration of the PCIe module as
Endpoint or Root complex and Not Phy. Hope below text will help.
Table 3-23 Device Configuration Register (DEVCFG)
PCIESSMODE[1:0] 00b PCIESSMODE is used to control the
functionality of PCIESS module out of
reset. This MMR output is connected to
DEVTYPE input of PCIESS
(Changes from
Nysh) : Note that in Nysh this value came
from a bootstrap pin.
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserved
PCIESS_1_MODE[1:0
]
00b PCIESSMODE is used to control the
functionality of PCIE_1 module out of
reset. This MMR output is connected to
DEVTYPE input of PCIE_1
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserv
WARNING: multiple messages have this Message-ID (diff)
From: Murali Karicheri <m-karicheri2@ti.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kumar Gala <galak@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Fri, 5 Sep 2014 14:33:54 -0400 [thread overview]
Message-ID: <540A0212.6060303@ti.com> (raw)
In-Reply-To: <7260053.FoBVhTXVfj@wuerfel>
On 09/05/2014 01:54 PM, Arnd Bergmann wrote:
> On Friday 05 September 2014 13:39:42 Murali Karicheri wrote:
>> +
>> /* enable RC mode in devcfg */
>> val = readl(reg_p);
>> - val&= ~PCIE_MODE_MASK;
>> - val |= PCIE_RC_MODE;
>> + port_id<<= 1;
>> + val&= ~(PCIE_MODE_MASK<< port_id);
>> + val |= (PCIE_RC_MODE<< port_id);
>> writel(val, reg_p);
>> + devm_iounmap(dev, reg_p);
>> + devm_release_mem_region(dev, res->start, resource_size(res));
>
> This looks like it's a shared register of some sort that doesn't
> really belong into the registers of a particular port. Could it
> be that it's actually for the PHY?
>
> Arnd
Arnd,
This a shared device configuration register between the two ports the
desciption states it is bootstrap configuration of the PCIe module as
Endpoint or Root complex and Not Phy. Hope below text will help.
Table 3-23 Device Configuration Register (DEVCFG)
PCIESSMODE[1:0] 00b PCIESSMODE is used to control the
functionality of PCIESS module out of
reset. This MMR output is connected to
DEVTYPE input of PCIESS
(Changes from
Nysh) : Note that in Nysh this value came
from a bootstrap pin.
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserved
PCIESS_1_MODE[1:0
]
00b PCIESSMODE is used to control the
functionality of PCIE_1 module out of
reset. This MMR output is connected to
DEVTYPE input of PCIE_1
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserv
WARNING: multiple messages have this Message-ID (diff)
From: m-karicheri2@ti.com (Murali Karicheri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Fri, 5 Sep 2014 14:33:54 -0400 [thread overview]
Message-ID: <540A0212.6060303@ti.com> (raw)
In-Reply-To: <7260053.FoBVhTXVfj@wuerfel>
On 09/05/2014 01:54 PM, Arnd Bergmann wrote:
> On Friday 05 September 2014 13:39:42 Murali Karicheri wrote:
>> +
>> /* enable RC mode in devcfg */
>> val = readl(reg_p);
>> - val&= ~PCIE_MODE_MASK;
>> - val |= PCIE_RC_MODE;
>> + port_id<<= 1;
>> + val&= ~(PCIE_MODE_MASK<< port_id);
>> + val |= (PCIE_RC_MODE<< port_id);
>> writel(val, reg_p);
>> + devm_iounmap(dev, reg_p);
>> + devm_release_mem_region(dev, res->start, resource_size(res));
>
> This looks like it's a shared register of some sort that doesn't
> really belong into the registers of a particular port. Could it
> be that it's actually for the PHY?
>
> Arnd
Arnd,
This a shared device configuration register between the two ports the
desciption states it is bootstrap configuration of the PCIe module as
Endpoint or Root complex and Not Phy. Hope below text will help.
Table 3-23 Device Configuration Register (DEVCFG)
PCIESSMODE[1:0] 00b PCIESSMODE is used to control the
functionality of PCIESS module out of
reset. This MMR output is connected to
DEVTYPE input of PCIESS
(Changes from
Nysh) : Note that in Nysh this value came
from a bootstrap pin.
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserved
PCIESS_1_MODE[1:0
]
00b PCIESSMODE is used to control the
functionality of PCIE_1 module out of
reset. This MMR output is connected to
DEVTYPE input of PCIE_1
00 : Endpoint
01 : Legacy Endpoint
10 : Rootcomplex
11 : Reserv
next prev parent reply other threads:[~2014-09-05 18:34 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:39 [PATCH] PCI: keystone: update to support multiple pci ports Murali Karicheri
2014-09-05 17:39 ` Murali Karicheri
2014-09-05 17:39 ` Murali Karicheri
2014-09-05 17:54 ` Arnd Bergmann
2014-09-05 17:54 ` Arnd Bergmann
2014-09-05 18:33 ` Murali Karicheri [this message]
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 21:11 ` Arnd Bergmann
2014-09-05 21:11 ` Arnd Bergmann
2014-09-08 15:52 ` Murali Karicheri
2014-09-08 15:52 ` Murali Karicheri
2014-09-08 15:52 ` Murali Karicheri
2014-09-09 10:24 ` Arnd Bergmann
2014-09-09 10:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=540A0212.6060303@ti.com \
--to=m-karicheri2@ti.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.