From: Arnd Bergmann <arnd@arndb.de>
To: Murali Karicheri <m-karicheri2@ti.com>
Cc: linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Santosh Shilimkar <santosh.shilimkar@ti.com>,
Kumar Gala <galak@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>
Subject: Re: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Tue, 09 Sep 2014 12:24:48 +0200 [thread overview]
Message-ID: <5974944.bS5MvrslRo@wuerfel> (raw)
In-Reply-To: <540DD0CF.4000501@ti.com>
On Monday 08 September 2014 11:52:47 Murali Karicheri wrote:
> On 09/05/2014 05:11 PM, Arnd Bergmann wrote:
> > But the driver can only do root complex mode, and we would probably
> > want a completely different driver if we were to start supporting
> > endpoint mode.
>
> Good point! I will drop index#2 handling in the driver code and will
> handle the same in boot loader. But I have a question though. The
> original driver which is queued up for merge to v3.18 has index #2 for
> this reg offset and is documented in the DT documentation as
>
> index 2 is the base address and length of PCI mode configuration
> register.
> index 3 is the base address and length of PCI device ID register.
>
>
> Will this create any issue in terms of backward compatibility if I
> remove it and move index3 to index2 and update the code for the same? I
> assume since this patch also will likely be on the next branch soon, and
> gets merged together with original driver to v3.18, this should be fine.
> But for some reason, if this patch doesn't make to v3.18, then won't
> this break the backward compatibility?
>
> I think the other option is document index2 as obsolete and update the
> document and remove the code for handling it. Any suggestion?
Since the driver is not merged into Linus' tree yet and (more importantly)
has not been in a release yet, we can still fix it. Please just send a
patch on top to remove it now, it's not too late yet.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] PCI: keystone: update to support multiple pci ports
Date: Tue, 09 Sep 2014 12:24:48 +0200 [thread overview]
Message-ID: <5974944.bS5MvrslRo@wuerfel> (raw)
In-Reply-To: <540DD0CF.4000501@ti.com>
On Monday 08 September 2014 11:52:47 Murali Karicheri wrote:
> On 09/05/2014 05:11 PM, Arnd Bergmann wrote:
> > But the driver can only do root complex mode, and we would probably
> > want a completely different driver if we were to start supporting
> > endpoint mode.
>
> Good point! I will drop index#2 handling in the driver code and will
> handle the same in boot loader. But I have a question though. The
> original driver which is queued up for merge to v3.18 has index #2 for
> this reg offset and is documented in the DT documentation as
>
> index 2 is the base address and length of PCI mode configuration
> register.
> index 3 is the base address and length of PCI device ID register.
>
>
> Will this create any issue in terms of backward compatibility if I
> remove it and move index3 to index2 and update the code for the same? I
> assume since this patch also will likely be on the next branch soon, and
> gets merged together with original driver to v3.18, this should be fine.
> But for some reason, if this patch doesn't make to v3.18, then won't
> this break the backward compatibility?
>
> I think the other option is document index2 as obsolete and update the
> document and remove the code for handling it. Any suggestion?
Since the driver is not merged into Linus' tree yet and (more importantly)
has not been in a release yet, we can still fix it. Please just send a
patch on top to remove it now, it's not too late yet.
Arnd
next prev parent reply other threads:[~2014-09-09 10:25 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 17:39 [PATCH] PCI: keystone: update to support multiple pci ports Murali Karicheri
2014-09-05 17:39 ` Murali Karicheri
2014-09-05 17:39 ` Murali Karicheri
2014-09-05 17:54 ` Arnd Bergmann
2014-09-05 17:54 ` Arnd Bergmann
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 18:33 ` Murali Karicheri
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 19:00 ` Arnd Bergmann
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 20:37 ` Murali Karicheri
2014-09-05 21:11 ` Arnd Bergmann
2014-09-05 21:11 ` Arnd Bergmann
2014-09-08 15:52 ` Murali Karicheri
2014-09-08 15:52 ` Murali Karicheri
2014-09-08 15:52 ` Murali Karicheri
2014-09-09 10:24 ` Arnd Bergmann [this message]
2014-09-09 10:24 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5974944.bS5MvrslRo@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.