All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Liviu Dudau <Liviu.Dudau@arm.com>,
	Rob Herring <robherring2@gmail.com>,
	Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh+dt@kernel.org>,
	"Jason Gunthorpe" <jgunthorpe@obsidianresearch.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	"Will Deacon" <Will.Deacon@arm.com>,
	Russell King <linux@arm.linux.org.uk>,
	linux-pci <linux-pci@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Tanmay Inamdar <tinamdar@apm.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Sinan Kaya <okaya@codeaurora.org>,
	Jingoo Han <jg1.han@samsung.com>,
	Kukjin Kim <kgene.kim@samsung.com>,
	"Suravee Suthikulanit" <suravee.suthikulpanit@amd.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Device Tree ML" <devicetree@vger.kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>
Subject: Re: [PATCH v10 07/10] OF: Introduce helper function for getting PCI domain_nr
Date: Wed, 10 Sep 2014 09:55:48 +0800	[thread overview]
Message-ID: <540FAFA4.1080008@huawei.com> (raw)
In-Reply-To: <CAErSpo4cAfom2=07NYDRfTCdHO22M0v+ueiaZuG6v2Xd18wEnQ@mail.gmail.com>

>> OK. Sorry, I have one last question, because domain will be used to calculate the address used to
>> access PCI hardware config registers. So if DTS file doesn't report the domain, how do we know
>> we would access the right registers when we use the auto increment domain vaule ?
>> Has there a mechanism to make sure system can access the correct registers by the domain ?
> 
> I think you're referring to config access via ECAM (PCIe r3.0, sec
> 7.2.2).  In that case, I don't think the domain should be used to
> compute the memory-mapped configuration address.  Each host bridge is
> in exactly one domain, and each host bridge has an associated ECAM
> area base.  The address calculation uses the bus number, device
> number, function number, and register number to compute an offset into
> the ECAM area.
> 
> So as long as the DT tells you the ECAM information for each host
> bridge, that should be sufficient.  The domain number is then just a
> Linux convenience and is not tied to the platform as it is on ia64.

Hi Bjorn, you are right, thanks for your detailed explanation! :)

Thanks!
Yijing.

> 
> Bjorn
> 
> .
> 


-- 
Thanks!
Yijing


WARNING: multiple messages have this Message-ID (diff)
From: Yijing Wang <wangyijing@huawei.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Catalin Marinas <Catalin.Marinas@arm.com>,
	linux-pci <linux-pci@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <Liviu.Dudau@arm.com>,
	Grant Likely <grant.likely@secretlab.ca>,
	Tanmay Inamdar <tinamdar@apm.com>,
	linux-arch <linux-arch@vger.kernel.org>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Russell King <linux@arm.linux.org.uk>,
	Jingoo Han <jg1.han@samsung.com>,
	Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"grant.likely@linaro.org" <grant.likely@linaro.org>,
	Device Tree ML <devicetree@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>, Will Deacon <Will.Deacon@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	LAKML <linux-arm-kernel@lists.infradead.org>,
	Sinan Kaya <okaya@codeaurora.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Suravee Suthikulanit <suravee.suthikulpanit@amd.com>
Subject: Re: [PATCH v10 07/10] OF: Introduce helper function for getting PCI domain_nr
Date: Wed, 10 Sep 2014 09:55:48 +0800	[thread overview]
Message-ID: <540FAFA4.1080008@huawei.com> (raw)
In-Reply-To: <CAErSpo4cAfom2=07NYDRfTCdHO22M0v+ueiaZuG6v2Xd18wEnQ@mail.gmail.com>

>> OK. Sorry, I have one last question, because domain will be used to calculate the address used to
>> access PCI hardware config registers. So if DTS file doesn't report the domain, how do we know
>> we would access the right registers when we use the auto increment domain vaule ?
>> Has there a mechanism to make sure system can access the correct registers by the domain ?
> 
> I think you're referring to config access via ECAM (PCIe r3.0, sec
> 7.2.2).  In that case, I don't think the domain should be used to
> compute the memory-mapped configuration address.  Each host bridge is
> in exactly one domain, and each host bridge has an associated ECAM
> area base.  The address calculation uses the bus number, device
> number, function number, and register number to compute an offset into
> the ECAM area.
> 
> So as long as the DT tells you the ECAM information for each host
> bridge, that should be sufficient.  The domain number is then just a
> Linux convenience and is not tied to the platform as it is on ia64.

Hi Bjorn, you are right, thanks for your detailed explanation! :)

Thanks!
Yijing.

> 
> Bjorn
> 
> .
> 


-- 
Thanks!
Yijing

WARNING: multiple messages have this Message-ID (diff)
From: wangyijing@huawei.com (Yijing Wang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 07/10] OF: Introduce helper function for getting PCI domain_nr
Date: Wed, 10 Sep 2014 09:55:48 +0800	[thread overview]
Message-ID: <540FAFA4.1080008@huawei.com> (raw)
In-Reply-To: <CAErSpo4cAfom2=07NYDRfTCdHO22M0v+ueiaZuG6v2Xd18wEnQ@mail.gmail.com>

>> OK. Sorry, I have one last question, because domain will be used to calculate the address used to
>> access PCI hardware config registers. So if DTS file doesn't report the domain, how do we know
>> we would access the right registers when we use the auto increment domain vaule ?
>> Has there a mechanism to make sure system can access the correct registers by the domain ?
> 
> I think you're referring to config access via ECAM (PCIe r3.0, sec
> 7.2.2).  In that case, I don't think the domain should be used to
> compute the memory-mapped configuration address.  Each host bridge is
> in exactly one domain, and each host bridge has an associated ECAM
> area base.  The address calculation uses the bus number, device
> number, function number, and register number to compute an offset into
> the ECAM area.
> 
> So as long as the DT tells you the ECAM information for each host
> bridge, that should be sufficient.  The domain number is then just a
> Linux convenience and is not tied to the platform as it is on ia64.

Hi Bjorn, you are right, thanks for your detailed explanation! :)

Thanks!
Yijing.

> 
> Bjorn
> 
> .
> 


-- 
Thanks!
Yijing

  parent reply	other threads:[~2014-09-10  2:01 UTC|newest]

Thread overview: 121+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-08 13:54 [PATCH v10 00/10] Support for creating generic PCI host bridges from DT Liviu Dudau
2014-09-08 13:54 ` Liviu Dudau
2014-09-08 13:54 ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 01/10] Fix ioport_map() for !CONFIG_GENERIC_IOMAP cases Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 02/10] PCI: Introduce helper functions to deal with PCI I/O ranges Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 03/10] ARM: Define PCI_IOBASE as the base of virtual PCI IO space Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 04/10] PCI: OF: Fix the conversion of IO ranges into IO resources Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 05/10] PCI: Create pci_host_bridge before its associated bus in pci_create_root_bus Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 06/10] PCI: Introduce generic domain handling for PCI busses Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 14:03   ` Catalin Marinas
2014-09-08 14:03     ` Catalin Marinas
2014-09-08 14:05     ` Liviu Dudau
2014-09-08 14:05       ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 07/10] OF: Introduce helper function for getting PCI domain_nr Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 14:27   ` Rob Herring
2014-09-08 14:27     ` Rob Herring
2014-09-08 14:54     ` Liviu Dudau
2014-09-08 14:54       ` Liviu Dudau
2014-09-08 15:27       ` Rob Herring
2014-09-08 15:27         ` Rob Herring
2014-09-08 15:59         ` Liviu Dudau
2014-09-08 15:59           ` Liviu Dudau
2014-09-08 16:39           ` Jason Gunthorpe
2014-09-08 16:39             ` Jason Gunthorpe
2014-09-09  5:54           ` Yijing Wang
2014-09-09  5:54             ` Yijing Wang
2014-09-09  8:46             ` Liviu Dudau
2014-09-09  8:46               ` Liviu Dudau
2014-09-09  8:46               ` Liviu Dudau
2014-09-09  9:16               ` Arnd Bergmann
2014-09-09  9:16                 ` Arnd Bergmann
2014-09-09  9:16                 ` Arnd Bergmann
2014-09-09 11:20                 ` Catalin Marinas
2014-09-09 11:20                   ` Catalin Marinas
2014-09-09 11:20                   ` Catalin Marinas
2014-09-10 18:19                   ` Arnd Bergmann
2014-09-10 18:19                     ` Arnd Bergmann
2014-09-10 18:19                     ` Arnd Bergmann
2014-09-11 14:11                     ` Phil Edworthy
2014-09-11 14:11                       ` Phil Edworthy
2014-09-11 14:49                       ` Arnd Bergmann
2014-09-11 14:49                         ` Arnd Bergmann
2014-09-11 14:49                         ` Arnd Bergmann
2014-09-09 14:17                 ` Bjorn Helgaas
2014-09-09 14:17                   ` Bjorn Helgaas
2014-09-09 14:17                   ` Bjorn Helgaas
2014-09-09  9:30               ` Yijing Wang
2014-09-09  9:30                 ` Yijing Wang
2014-09-09  9:30                 ` Yijing Wang
2014-09-09 14:11                 ` Liviu Dudau
2014-09-09 14:11                   ` Liviu Dudau
2014-09-09 14:11                   ` Liviu Dudau
2014-09-10  1:44                   ` Yijing Wang
2014-09-10  1:44                     ` Yijing Wang
2014-09-10  1:44                     ` Yijing Wang
2014-09-09 14:26                 ` Bjorn Helgaas
2014-09-09 14:26                   ` Bjorn Helgaas
2014-09-09 14:26                   ` Bjorn Helgaas
2014-09-09 15:41                   ` Jason Gunthorpe
2014-09-09 15:41                     ` Jason Gunthorpe
2014-09-09 15:41                     ` Jason Gunthorpe
2014-09-10  2:44                     ` Rob Herring
2014-09-10  2:44                       ` Rob Herring
2014-09-10  2:44                       ` Rob Herring
2014-09-10 16:32                       ` Jason Gunthorpe
2014-09-10 16:32                         ` Jason Gunthorpe
2014-09-10 16:32                         ` Jason Gunthorpe
2014-09-10 19:36                         ` Rob Herring
2014-09-10  1:55                   ` Yijing Wang [this message]
2014-09-10  1:55                     ` Yijing Wang
2014-09-10  1:55                     ` Yijing Wang
2014-09-10 13:04           ` Liviu Dudau
2014-09-10 13:04             ` Liviu Dudau
2014-09-10 13:04             ` Liviu Dudau
2014-09-10 13:04             ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 08/10] OF: PCI: Add support for parsing PCI host bridge resources from DT Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-09 13:35   ` Lorenzo Pieralisi
2014-09-09 13:35     ` Lorenzo Pieralisi
2014-09-10 14:22     ` Liviu Dudau
2014-09-10 14:22       ` Liviu Dudau
2014-09-10 15:10       ` Lorenzo Pieralisi
2014-09-10 15:10         ` Lorenzo Pieralisi
2014-09-10 15:32         ` Liviu Dudau
2014-09-10 15:32           ` Liviu Dudau
2014-09-10 16:37           ` Lorenzo Pieralisi
2014-09-10 16:37             ` Lorenzo Pieralisi
2014-09-10 16:53             ` Liviu Dudau
2014-09-10 16:53               ` Liviu Dudau
2014-09-10 16:53               ` Liviu Dudau
2014-09-10 17:06               ` Lorenzo Pieralisi
2014-09-10 17:06                 ` Lorenzo Pieralisi
2014-09-08 13:54 ` [PATCH v10 09/10] PCI: Assign unassigned bus resources in pci_scan_root_bus() Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-12 10:13   ` Suravee Suthikulpanit
2014-09-12 10:13     ` Suravee Suthikulpanit
2014-09-12 10:34     ` Liviu Dudau
2014-09-12 10:34       ` Liviu Dudau
2014-09-08 13:54 ` [PATCH v10 10/10] PCI: Introduce pci_remap_iospace() for remapping PCI I/O bus resources into CPU space Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 13:54   ` Liviu Dudau
2014-09-08 16:07 ` [PATCH v10 00/10] Support for creating generic PCI host bridges from DT Liviu Dudau
2014-09-08 16:07   ` Liviu Dudau
2014-09-08 16:07   ` Liviu Dudau
2014-09-12  8:25 ` Suravee Suthikulpanit
2014-09-12  8:25   ` Suravee Suthikulpanit
2014-09-12  9:30   ` Liviu Dudau
2014-09-12  9:30     ` Liviu Dudau
2014-09-12 10:00     ` Suravee Suthikulpanit
2014-09-12 10:00       ` Suravee Suthikulpanit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=540FAFA4.1080008@huawei.com \
    --to=wangyijing@huawei.com \
    --cc=Catalin.Marinas@arm.com \
    --cc=Liviu.Dudau@arm.com \
    --cc=Will.Deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=devicetree@vger.kernel.org \
    --cc=grant.likely@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jg1.han@samsung.com \
    --cc=jgunthorpe@obsidianresearch.com \
    --cc=kgene.kim@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=okaya@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=robherring2@gmail.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tinamdar@apm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.