All of lore.kernel.org
 help / color / mirror / Atom feed
From: Addy <addy.ke@rock-chips.com>
To: Doug Anderson <dianders@chromium.org>, Heiko Stuebner <heiko@sntech.de>
Cc: Chris Zhong <zyw@rock-chips.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, robh+dt@kernel.org,
	pawel.moll@arm.com, mark.rutland@arm.com,
	ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
	linux@arm.linux.org.uk, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808
Date: Thu, 11 Sep 2014 17:17:58 +0800	[thread overview]
Message-ID: <541168C6.2090603@rock-chips.com> (raw)
In-Reply-To: <1410409815-22200-1-git-send-email-dianders@chromium.org>


On 11 Sep 2014 12:30, Doug Anderson writes:
> We should be able to talk to the PMIC at 400kHz.  No need to talk at
> the slow 100kHz.
>
> As measured by ftrace (with a bunch of extra patches, since cpufreq
> for rk808 hasn't landed yet):
>   before this change: cpu0_set_target() => ~500us
>   after this change:  cpu0_set_target() => ~300us
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> index 36db177..ff522f8 100644
> --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
> +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> @@ -18,6 +18,7 @@
>  };
>  
>  &i2c0 {
> +	clock-frequency = <400000>;
>  	status = "okay";
>  
>  	rk808: pmic@1b {
I have tested on rk3288-pinky board, it work well. so

Reviewed-by Addy Ke <addy.ke@rock-chips.com>
Tested-by Addy Ke <addy.ke@rock-chips.com>



WARNING: multiple messages have this Message-ID

From: Addy <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
To: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
Cc: Chris Zhong <zyw-TNX95d0MmH7DzftRWevZcw@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
	pawel.moll-5wv7dgnIgG8@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
	galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808
Date: Thu, 11 Sep 2014 17:17:58 +0800	[thread overview]
Message-ID: <541168C6.2090603@rock-chips.com> (raw)
In-Reply-To: <1410409815-22200-1-git-send-email-dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>


On 11 Sep 2014 12:30, Doug Anderson writes:
> We should be able to talk to the PMIC at 400kHz.  No need to talk at
> the slow 100kHz.
>
> As measured by ftrace (with a bunch of extra patches, since cpufreq
> for rk808 hasn't landed yet):
>   before this change: cpu0_set_target() => ~500us
>   after this change:  cpu0_set_target() => ~300us
>
> Signed-off-by: Doug Anderson <dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> ---
>  arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> index 36db177..ff522f8 100644
> --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
> +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> @@ -18,6 +18,7 @@
>  };
>  
>  &i2c0 {
> +	clock-frequency = <400000>;
>  	status = "okay";
>  
>  	rk808: pmic@1b {
I have tested on rk3288-pinky board, it work well. so

Reviewed-by Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Tested-by Addy Ke <addy.ke-TNX95d0MmH7DzftRWevZcw@public.gmane.org>


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID

From: addy.ke@rock-chips.com (Addy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808
Date: Thu, 11 Sep 2014 17:17:58 +0800	[thread overview]
Message-ID: <541168C6.2090603@rock-chips.com> (raw)
In-Reply-To: <1410409815-22200-1-git-send-email-dianders@chromium.org>


On 11 Sep 2014 12:30, Doug Anderson writes:
> We should be able to talk to the PMIC at 400kHz.  No need to talk at
> the slow 100kHz.
>
> As measured by ftrace (with a bunch of extra patches, since cpufreq
> for rk808 hasn't landed yet):
>   before this change: cpu0_set_target() => ~500us
>   after this change:  cpu0_set_target() => ~300us
>
> Signed-off-by: Doug Anderson <dianders@chromium.org>
> ---
>  arch/arm/boot/dts/rk3288-evb-rk808.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb-rk808.dts b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> index 36db177..ff522f8 100644
> --- a/arch/arm/boot/dts/rk3288-evb-rk808.dts
> +++ b/arch/arm/boot/dts/rk3288-evb-rk808.dts
> @@ -18,6 +18,7 @@
>  };
>  
>  &i2c0 {
> +	clock-frequency = <400000>;
>  	status = "okay";
>  
>  	rk808: pmic at 1b {
I have tested on rk3288-pinky board, it work well. so

Reviewed-by Addy Ke <addy.ke@rock-chips.com>
Tested-by Addy Ke <addy.ke@rock-chips.com>

  reply	other threads:[~2014-09-11  9:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-11  4:30 Doug Anderson
2014-09-11  4:30 ` Doug Anderson
2014-09-11  9:17 ` Addy [this message]
2014-09-11  9:17   ` Addy
2014-09-11  9:17   ` Addy
2014-09-11  9:23 ` Heiko Stübner
2014-09-11  9:23   ` Heiko Stübner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541168C6.2090603@rock-chips.com \
    --to=addy.ke@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=galak@codeaurora.org \
    --cc=heiko@sntech.de \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=zyw@rock-chips.com \
    --subject='Re: [PATCH] ARM: dts: Switch i2c0 to 400kHz on rk3288-evb-rk808' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.