* [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
@ 2014-09-13 1:04 ` Jianqun
0 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-13 1:04 UTC (permalink / raw)
To: heiko, lgirdwood, broonie, perex, tiwai, linux-arm-kernel,
linux-rockchip, linux-kernel, alsa-devel
Cc: huangtao, cf, Jianqun
Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
Table 10-1 DMAC_BUS Request Mapping Table
Req number Source Polarity
0 I2S tx High level
1 I2S rx High level
Tested on RK3288 board.
Signed-off-by: Jianqun <jay.xu@rock-chips.com>
---
Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s@ff890000 {
#address-cells = <1>;
#size-cells = <0>;
dmas = <&pdma1 0>, <&pdma1 1>;
- dma-names = "rx", "tx";
+ dma-names = "tx", "rx";
clock-names = "i2s_hclk", "i2s_clk";
clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
@ 2014-09-13 1:04 ` Jianqun
0 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-13 1:04 UTC (permalink / raw)
To: linux-arm-kernel
Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
Table 10-1 DMAC_BUS Request Mapping Table
Req number Source Polarity
0 I2S tx High level
1 I2S rx High level
Tested on RK3288 board.
Signed-off-by: Jianqun <jay.xu@rock-chips.com>
---
Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s at ff890000 {
#address-cells = <1>;
#size-cells = <0>;
dmas = <&pdma1 0>, <&pdma1 1>;
- dma-names = "rx", "tx";
+ dma-names = "tx", "rx";
clock-names = "i2s_hclk", "i2s_clk";
clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
2014-09-13 1:04 ` Jianqun
@ 2014-09-13 16:40 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2014-09-13 16:40 UTC (permalink / raw)
To: Jianqun
Cc: heiko, lgirdwood, perex, tiwai, linux-arm-kernel, linux-rockchip,
linux-kernel, alsa-devel, huangtao, cf
[-- Attachment #1: Type: text/plain, Size: 406 bytes --]
On Sat, Sep 13, 2014 at 09:04:41AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
Applied, thanks. The changelog should've just noted that this is an
error in the example rather than the code or the binding, I was a bit
confused about this.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
@ 2014-09-13 16:40 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2014-09-13 16:40 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Sep 13, 2014 at 09:04:41AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
Applied, thanks. The changelog should've just noted that this is an
error in the example rather than the code or the binding, I was a bit
confused about this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140913/cbda250e/attachment-0001.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
2014-09-13 16:40 ` Mark Brown
@ 2014-09-14 2:29 ` Jianqun
-1 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-14 2:29 UTC (permalink / raw)
To: Mark Brown, Jianqun
Cc: heiko, lgirdwood, perex, tiwai, linux-arm-kernel, linux-rockchip,
linux-kernel, alsa-devel, huangtao, cf
在 09/14/2014 12:40 AM, Mark Brown 写道:
> On Sat, Sep 13, 2014 at 09:04:41AM +0800, Jianqun wrote:
>> Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
>> Table 10-1 DMAC_BUS Request Mapping Table
>> Req number Source Polarity
>> 0 I2S tx High level
>> 1 I2S rx High level
>
> Applied, thanks. The changelog should've just noted that this is an
> error in the example rather than the code or the binding, I was a bit
> confused about this.
>
ok, I will do it
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number
@ 2014-09-14 2:29 ` Jianqun
0 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-14 2:29 UTC (permalink / raw)
To: linux-arm-kernel
? 09/14/2014 12:40 AM, Mark Brown ??:
> On Sat, Sep 13, 2014 at 09:04:41AM +0800, Jianqun wrote:
>> Reference to RK3288 TRM, fix an error channel id for i2s tx and rx
>> Table 10-1 DMAC_BUS Request Mapping Table
>> Req number Source Polarity
>> 0 I2S tx High level
>> 1 I2S rx High level
>
> Applied, thanks. The changelog should've just noted that this is an
> error in the example rather than the code or the binding, I was a bit
> confused about this.
>
ok, I will do it
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
2014-09-13 1:04 ` Jianqun
@ 2014-09-14 3:39 ` Jianqun
-1 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-14 3:39 UTC (permalink / raw)
To: heiko, lgirdwood, broonie, perex, tiwai, linux-arm-kernel,
linux-rockchip, linux-kernel, alsa-devel
Cc: huangtao, cf, Jianqun
Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
Table 10-1 DMAC_BUS Request Mapping Table
Req number Source Polarity
0 I2S tx High level
1 I2S rx High level
Tested on RK3288 board.
Signed-off-by: Jianqun <jay.xu@rock-chips.com>
---
change since v1:
- modify patch's changelog as Mark's suggestion
Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s@ff890000 {
#address-cells = <1>;
#size-cells = <0>;
dmas = <&pdma1 0>, <&pdma1 1>;
- dma-names = "rx", "tx";
+ dma-names = "tx", "rx";
clock-names = "i2s_hclk", "i2s_clk";
clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
@ 2014-09-14 3:39 ` Jianqun
0 siblings, 0 replies; 10+ messages in thread
From: Jianqun @ 2014-09-14 3:39 UTC (permalink / raw)
To: linux-arm-kernel
Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
Table 10-1 DMAC_BUS Request Mapping Table
Req number Source Polarity
0 I2S tx High level
1 I2S rx High level
Tested on RK3288 board.
Signed-off-by: Jianqun <jay.xu@rock-chips.com>
---
change since v1:
- modify patch's changelog as Mark's suggestion
Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
index 6c55fcf..9b82c20 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt
@@ -31,7 +31,7 @@ i2s at ff890000 {
#address-cells = <1>;
#size-cells = <0>;
dmas = <&pdma1 0>, <&pdma1 1>;
- dma-names = "rx", "tx";
+ dma-names = "tx", "rx";
clock-names = "i2s_hclk", "i2s_clk";
clocks = <&cru HCLK_I2S0>, <&cru SCLK_I2S0>;
};
--
1.9.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
2014-09-14 3:39 ` Jianqun
@ 2014-09-15 16:45 ` Mark Brown
-1 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2014-09-15 16:45 UTC (permalink / raw)
To: Jianqun
Cc: heiko, lgirdwood, perex, tiwai, linux-arm-kernel, linux-rockchip,
linux-kernel, alsa-devel, huangtao, cf
[-- Attachment #1: Type: text/plain, Size: 651 bytes --]
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
>
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
>
> Tested on RK3288 board.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
> change since v1:
> - modify patch's changelog as Mark's suggestion
No, the patch has already been applied. Once a patch has been applied
don't resend it, it can't be re-applied. In this case the advice about
the changelog was something you should bear in mind for future
changelogs.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example
@ 2014-09-15 16:45 ` Mark Brown
0 siblings, 0 replies; 10+ messages in thread
From: Mark Brown @ 2014-09-15 16:45 UTC (permalink / raw)
To: linux-arm-kernel
On Sun, Sep 14, 2014 at 11:39:59AM +0800, Jianqun wrote:
> Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx".
>
> Table 10-1 DMAC_BUS Request Mapping Table
> Req number Source Polarity
> 0 I2S tx High level
> 1 I2S rx High level
>
> Tested on RK3288 board.
>
> Signed-off-by: Jianqun <jay.xu@rock-chips.com>
> ---
> change since v1:
> - modify patch's changelog as Mark's suggestion
No, the patch has already been applied. Once a patch has been applied
don't resend it, it can't be re-applied. In this case the advice about
the changelog was something you should bear in mind for future
changelogs.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140915/efad01ea/attachment.sig>
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2014-09-15 16:46 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-13 1:04 [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number Jianqun
2014-09-13 1:04 ` Jianqun
2014-09-13 16:40 ` Mark Brown
2014-09-13 16:40 ` Mark Brown
2014-09-14 2:29 ` Jianqun
2014-09-14 2:29 ` Jianqun
2014-09-14 3:39 ` [PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example Jianqun
2014-09-14 3:39 ` Jianqun
2014-09-15 16:45 ` Mark Brown
2014-09-15 16:45 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.