All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-usb <linux-usb@vger.kernel.org>,
	SCSI development list <linux-scsi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq
Date: Sun, 14 Sep 2014 11:41:40 +0200	[thread overview]
Message-ID: <541562D4.90801@redhat.com> (raw)
In-Reply-To: <20140913175047.GA28882@infradead.org>

Hi,

On 09/13/2014 07:50 PM, Christoph Hellwig wrote:
> On Sat, Sep 13, 2014 at 12:28:41PM +0200, Hans de Goede wrote:
>> Yes this one does the trick and fixes things. Note the git tree I used for
>> testing also had your previous fix to split up the blk_tcq union in 2
>> separate struct members. Let me know if you want me to re-test without that
>> fix.
> 
> I'm pretty sure that isn't needed, so double testing it indeed doesn't
> would be helpful.

I can confirm that things still work fine with the union left in place.

>  I'd like to add your Tested-by: tag after that, too.

Ack:

Tested-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans

  reply	other threads:[~2014-09-14  9:42 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-09  9:15 [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing Hans de Goede
2014-09-09 15:27 ` Christoph Hellwig
2014-09-10  7:21   ` Hans de Goede
2014-09-10 15:45     ` Christoph Hellwig
2014-09-10 15:45       ` Christoph Hellwig
2014-09-11 10:01       ` Hans de Goede
2014-09-11 10:01         ` Hans de Goede
2014-09-11 16:13         ` Christoph Hellwig
2014-09-12 19:49           ` Hans de Goede
2014-09-12 23:00             ` [PATCH] scsi: fix regression that accidentally disabled block-based tcq Christoph Hellwig
2014-09-13 10:28               ` Hans de Goede
2014-09-13 17:50                 ` Christoph Hellwig
2014-09-14  9:41                   ` Hans de Goede [this message]
2014-09-15 18:47                     ` review-ping: " Christoph Hellwig
2014-09-15 19:05               ` Webb Scales
2014-09-15 19:15               ` Hans de Goede
2014-09-15 19:39               ` Jeff Moyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541562D4.90801@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.