From: Hans de Goede <hdegoede@redhat.com> To: Christoph Hellwig <hch@infradead.org> Cc: linux-usb <linux-usb@vger.kernel.org>, SCSI development list <linux-scsi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing Date: Thu, 11 Sep 2014 12:01:13 +0200 [thread overview] Message-ID: <541172E9.8070309@redhat.com> (raw) In-Reply-To: <20140910154535.GA5102@infradead.org> Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: >> I've applied the patch, this results in the following new dmesg output >> when using uas: >> >> [ 120.602632] initialized host-wide tag map! >> >> Thank you for looking into this. > > So we're initializing the tag map, but scsi_activate_tcq doesn't pick it > up. I can't really come up with a good explanation for it, but there > even without that there is an elephant in the room: as part of the > scsi-mq series I moved the bqt field used for this into a union with the > new blk_mq_tag_set. Below is a patch to get rid of that union, can you > try if that fixes it? Unfortunately that does not fix it :| Regards, Hans > > > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index d0f69a3..bcffff2 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -584,10 +584,8 @@ struct Scsi_Host { > * Area to keep a shared tag map (if needed, will be > * NULL if not). > */ > - union { > - struct blk_queue_tag *bqt; > - struct blk_mq_tag_set tag_set; > - }; > + struct blk_queue_tag *bqt; > + struct blk_mq_tag_set tag_set; > > atomic_t host_busy; /* commands actually active on low-level */ > atomic_t host_blocked; >
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> To: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Cc: linux-usb <linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, SCSI development list <linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, Linux Kernel Mailing List <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: Re: [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing Date: Thu, 11 Sep 2014 12:01:13 +0200 [thread overview] Message-ID: <541172E9.8070309@redhat.com> (raw) In-Reply-To: <20140910154535.GA5102-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> Hi, On 09/10/2014 05:45 PM, Christoph Hellwig wrote: > On Wed, Sep 10, 2014 at 09:21:24AM +0200, Hans de Goede wrote: >> I've applied the patch, this results in the following new dmesg output >> when using uas: >> >> [ 120.602632] initialized host-wide tag map! >> >> Thank you for looking into this. > > So we're initializing the tag map, but scsi_activate_tcq doesn't pick it > up. I can't really come up with a good explanation for it, but there > even without that there is an elephant in the room: as part of the > scsi-mq series I moved the bqt field used for this into a union with the > new blk_mq_tag_set. Below is a patch to get rid of that union, can you > try if that fixes it? Unfortunately that does not fix it :| Regards, Hans > > > diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h > index d0f69a3..bcffff2 100644 > --- a/include/scsi/scsi_host.h > +++ b/include/scsi/scsi_host.h > @@ -584,10 +584,8 @@ struct Scsi_Host { > * Area to keep a shared tag map (if needed, will be > * NULL if not). > */ > - union { > - struct blk_queue_tag *bqt; > - struct blk_mq_tag_set tag_set; > - }; > + struct blk_queue_tag *bqt; > + struct blk_mq_tag_set tag_set; > > atomic_t host_busy; /* commands actually active on low-level */ > atomic_t host_blocked; > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-09-11 10:01 UTC|newest] Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-09-09 9:15 [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing Hans de Goede 2014-09-09 15:27 ` Christoph Hellwig 2014-09-10 7:21 ` Hans de Goede 2014-09-10 15:45 ` Christoph Hellwig 2014-09-10 15:45 ` Christoph Hellwig 2014-09-11 10:01 ` Hans de Goede [this message] 2014-09-11 10:01 ` Hans de Goede 2014-09-11 16:13 ` Christoph Hellwig 2014-09-12 19:49 ` Hans de Goede 2014-09-12 23:00 ` [PATCH] scsi: fix regression that accidentally disabled block-based tcq Christoph Hellwig 2014-09-13 10:28 ` Hans de Goede 2014-09-13 17:50 ` Christoph Hellwig 2014-09-14 9:41 ` Hans de Goede 2014-09-15 18:47 ` review-ping: " Christoph Hellwig 2014-09-15 19:05 ` Webb Scales 2014-09-15 19:15 ` Hans de Goede 2014-09-15 19:39 ` Jeff Moyer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=541172E9.8070309@redhat.com \ --to=hdegoede@redhat.com \ --cc=hch@infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=linux-usb@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.