From: Webb Scales <webbnh@hp.com>
To: Christoph Hellwig <hch@infradead.org>,
Hans de Goede <hdegoede@redhat.com>
Cc: linux-usb <linux-usb@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] scsi: fix regression that accidentally disabled block-based tcq
Date: Mon, 15 Sep 2014 15:05:24 -0400 [thread overview]
Message-ID: <54173874.6080900@hp.com> (raw)
In-Reply-To: <20140912230032.GA21143@infradead.org>
On 9/12/14 7:00 PM, Christoph Hellwig wrote:
> Please try the fix below, looks like the commit broke TCQ for all drivers
> using block-level tagging.
>
> ---
> From 865a19b760d2786fe37d3b5c151a4ecea4c0e95e Mon Sep 17 00:00:00 2001
> From: Christoph Hellwig <hch@lst.de>
> Date: Fri, 12 Sep 2014 16:00:19 -0700
> Subject: scsi: fix regression that accidentally disabled block-based tcq
>
> The scsi blk-mq support accidentally flipped a conditional, which lead to
> never enabling block based tcq when using the legacy request path.
>
> Fixes: d285203cf647d7c9 scsi: add support for a blk-mq based I/O path.
> Reported-by: Hans de Goede <hdegoede@redhat.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> include/scsi/scsi_tcq.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/scsi/scsi_tcq.h b/include/scsi/scsi_tcq.h
> index cdcc90b..e645835 100644
> --- a/include/scsi/scsi_tcq.h
> +++ b/include/scsi/scsi_tcq.h
> @@ -68,7 +68,7 @@ static inline void scsi_activate_tcq(struct scsi_device *sdev, int depth)
> return;
>
> if (!shost_use_blk_mq(sdev->host) &&
> - blk_queue_tagged(sdev->request_queue))
> + !blk_queue_tagged(sdev->request_queue))
> blk_queue_init_tags(sdev->request_queue, depth,
> sdev->host->bqt);
>
Reviewed-by: Webb Scales <webbnh@hp.com>
next prev parent reply other threads:[~2014-09-15 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-09 9:15 [REGRESSION 3.17] scsi (uas) disks no longer using tagged command queuing Hans de Goede
2014-09-09 15:27 ` Christoph Hellwig
2014-09-10 7:21 ` Hans de Goede
2014-09-10 15:45 ` Christoph Hellwig
2014-09-10 15:45 ` Christoph Hellwig
2014-09-11 10:01 ` Hans de Goede
2014-09-11 10:01 ` Hans de Goede
2014-09-11 16:13 ` Christoph Hellwig
2014-09-12 19:49 ` Hans de Goede
2014-09-12 23:00 ` [PATCH] scsi: fix regression that accidentally disabled block-based tcq Christoph Hellwig
2014-09-13 10:28 ` Hans de Goede
2014-09-13 17:50 ` Christoph Hellwig
2014-09-14 9:41 ` Hans de Goede
2014-09-15 18:47 ` review-ping: " Christoph Hellwig
2014-09-15 19:05 ` Webb Scales [this message]
2014-09-15 19:15 ` Hans de Goede
2014-09-15 19:39 ` Jeff Moyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54173874.6080900@hp.com \
--to=webbnh@hp.com \
--cc=hch@infradead.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.