* Re: Adding selftest testdata dynamically into live tree
@ 2014-09-22 18:05 Janusz Użycki
[not found] ` <542064F1.4000601-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Janusz Użycki @ 2014-09-22 18:05 UTC (permalink / raw)
To: Gaurav Minocha, Grant Likely; +Cc: devicetree-u79uwXL29TY76Z2rM5mHXA
Hi.
On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
zImage is recreated every time I call "make" despite I've not done
any change in source files and zImage was the same.
This is caused by the rm line:
CALL scripts/checksyscalls.sh
CHK include/generated/compile.h
DTC drivers/of/testcase-data/testcases.dtb
DTB drivers/of/testcase-data/testcases.dtb.S
AS drivers/of/testcase-data/testcases.dtb.o
LD drivers/of/of_selftest.o
LD drivers/of/built-in.o
rm drivers/of/testcase-data/testcases.dtb.S
drivers/of/testcase-data/testcases.dtb
LD drivers/built-in.o
LINK vmlinux
LD vmlinux.o
best regards
Janusz
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
[not found] ` <542064F1.4000601-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
@ 2014-09-24 18:03 ` Gaurav Minocha
[not found] ` <CA+rpMbKkS1D=QYSMftgZyTMbHS9+O=YjR+OL_RvzjJPjo2Ox6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-26 12:09 ` Grant Likely
1 sibling, 1 reply; 7+ messages in thread
From: Gaurav Minocha @ 2014-09-24 18:03 UTC (permalink / raw)
To: Janusz Użycki; +Cc: Grant Likely, devicetree-u79uwXL29TY76Z2rM5mHXA
On Mon, Sep 22, 2014 at 11:05 AM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> Hi.
>
> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
> zImage is recreated every time I call "make" despite I've not done
> any change in source files and zImage was the same.
> This is caused by the rm line:
I believe the make rule compiles test data without checking
whether the test data dts files have been changed or not.
I am not sure how to fix it. So, either direct me or feel free to
pick it. Thanks!
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> DTC drivers/of/testcase-data/testcases.dtb
> DTB drivers/of/testcase-data/testcases.dtb.S
> AS drivers/of/testcase-data/testcases.dtb.o
> LD drivers/of/of_selftest.o
> LD drivers/of/built-in.o
> rm drivers/of/testcase-data/testcases.dtb.S
> drivers/of/testcase-data/testcases.dtb
> LD drivers/built-in.o
> LINK vmlinux
> LD vmlinux.o
>
> best regards
> Janusz
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
[not found] ` <CA+rpMbKkS1D=QYSMftgZyTMbHS9+O=YjR+OL_RvzjJPjo2Ox6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2014-09-24 18:05 ` Janusz Użycki
0 siblings, 0 replies; 7+ messages in thread
From: Janusz Użycki @ 2014-09-24 18:05 UTC (permalink / raw)
To: Gaurav Minocha; +Cc: Grant Likely, devicetree-u79uwXL29TY76Z2rM5mHXA
W dniu 2014-09-24 20:03, Gaurav Minocha pisze:
> On Mon, Sep 22, 2014 at 11:05 AM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
>> Hi.
>>
>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>> zImage is recreated every time I call "make" despite I've not done
>> any change in source files and zImage was the same.
>> This is caused by the rm line:
> I believe the make rule compiles test data without checking
> whether the test data dts files have been changed or not.
>
> I am not sure how to fix it. So, either direct me or feel free to
> pick it. Thanks!
I just disabled CONFIG_OF_SELFTEST now and it works for me.
best regards
Janusz
>
>> CALL scripts/checksyscalls.sh
>> CHK include/generated/compile.h
>> DTC drivers/of/testcase-data/testcases.dtb
>> DTB drivers/of/testcase-data/testcases.dtb.S
>> AS drivers/of/testcase-data/testcases.dtb.o
>> LD drivers/of/of_selftest.o
>> LD drivers/of/built-in.o
>> rm drivers/of/testcase-data/testcases.dtb.S
>> drivers/of/testcase-data/testcases.dtb
>> LD drivers/built-in.o
>> LINK vmlinux
>> LD vmlinux.o
>>
>> best regards
>> Janusz
>>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
[not found] ` <542064F1.4000601-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-24 18:03 ` Gaurav Minocha
@ 2014-09-26 12:09 ` Grant Likely
[not found] ` <20140926120917.B60B4C40FEB-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
1 sibling, 1 reply; 7+ messages in thread
From: Grant Likely @ 2014-09-26 12:09 UTC (permalink / raw)
To: Janusz Użycki, Gaurav Minocha; +Cc: devicetree-u79uwXL29TY76Z2rM5mHXA
On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> Hi.
>
> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
> zImage is recreated every time I call "make" despite I've not done
> any change in source files and zImage was the same.
> This is caused by the rm line:
> CALL scripts/checksyscalls.sh
> CHK include/generated/compile.h
> DTC drivers/of/testcase-data/testcases.dtb
> DTB drivers/of/testcase-data/testcases.dtb.S
> AS drivers/of/testcase-data/testcases.dtb.o
> LD drivers/of/of_selftest.o
> LD drivers/of/built-in.o
> rm drivers/of/testcase-data/testcases.dtb.S
> drivers/of/testcase-data/testcases.dtb
> LD drivers/built-in.o
> LINK vmlinux
> LD vmlinux.o
Try this change:
diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
index 260bf8acfce9..4555e2e1b4ed 100644
--- a/scripts/Makefile.lib
+++ b/scripts/Makefile.lib
@@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
-d $(depfile).dtc.tmp $(dtc-tmp) ; \
cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
-$(obj)/%.dtb: $(src)/%.dts FORCE
+$(obj)/%.dtb: $(src)/%.dts
$(call if_changed_dep,dtc)
dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
[not found] ` <20140926120917.B60B4C40FEB-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
@ 2014-09-26 13:36 ` Janusz Użycki
2014-09-26 15:07 ` Grant Likely
0 siblings, 1 reply; 7+ messages in thread
From: Janusz Użycki @ 2014-09-26 13:36 UTC (permalink / raw)
To: Grant Likely, Gaurav Minocha; +Cc: devicetree-u79uwXL29TY76Z2rM5mHXA
The patch didn't help. Exactly the same.
best regards
Janusz
W dniu 2014-09-26 14:09, Grant Likely pisze:
> On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
>> Hi.
>>
>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>> zImage is recreated every time I call "make" despite I've not done
>> any change in source files and zImage was the same.
>> This is caused by the rm line:
>> CALL scripts/checksyscalls.sh
>> CHK include/generated/compile.h
>> DTC drivers/of/testcase-data/testcases.dtb
>> DTB drivers/of/testcase-data/testcases.dtb.S
>> AS drivers/of/testcase-data/testcases.dtb.o
>> LD drivers/of/of_selftest.o
>> LD drivers/of/built-in.o
>> rm drivers/of/testcase-data/testcases.dtb.S
>> drivers/of/testcase-data/testcases.dtb
>> LD drivers/built-in.o
>> LINK vmlinux
>> LD vmlinux.o
> Try this change:
>
> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
> index 260bf8acfce9..4555e2e1b4ed 100644
> --- a/scripts/Makefile.lib
> +++ b/scripts/Makefile.lib
> @@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x assembler-with-cpp -o $(dtc-tmp) $< ; \
> -d $(depfile).dtc.tmp $(dtc-tmp) ; \
> cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
>
> -$(obj)/%.dtb: $(src)/%.dts FORCE
> +$(obj)/%.dtb: $(src)/%.dts
> $(call if_changed_dep,dtc)
>
> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
2014-09-26 13:36 ` Janusz Użycki
@ 2014-09-26 15:07 ` Grant Likely
0 siblings, 0 replies; 7+ messages in thread
From: Grant Likely @ 2014-09-26 15:07 UTC (permalink / raw)
To: Janusz Użycki; +Cc: Gaurav Minocha, devicetree, linux-kbuild, Michal Marek
On Fri, Sep 26, 2014 at 2:36 PM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> The patch didn't help. Exactly the same.
Odd it worked here. It's moot anyway though because it breaks checking
dependencies on .dts files. I need someone stronger on kbuild-foo to
figure this out out. I've cc'd Michal and the kbuild mailing list.
Hopefully someone there can help figure this out.
g.
>
> best regards
> Janusz
>
> W dniu 2014-09-26 14:09, Grant Likely pisze:
>
>> On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki
>> <j.uzycki@elproma.com.pl> wrote:
>>>
>>> Hi.
>>>
>>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>>> zImage is recreated every time I call "make" despite I've not done
>>> any change in source files and zImage was the same.
>>> This is caused by the rm line:
>>> CALL scripts/checksyscalls.sh
>>> CHK include/generated/compile.h
>>> DTC drivers/of/testcase-data/testcases.dtb
>>> DTB drivers/of/testcase-data/testcases.dtb.S
>>> AS drivers/of/testcase-data/testcases.dtb.o
>>> LD drivers/of/of_selftest.o
>>> LD drivers/of/built-in.o
>>> rm drivers/of/testcase-data/testcases.dtb.S
>>> drivers/of/testcase-data/testcases.dtb
>>> LD drivers/built-in.o
>>> LINK vmlinux
>>> LD vmlinux.o
>>
>> Try this change:
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 260bf8acfce9..4555e2e1b4ed 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x
>> assembler-with-cpp -o $(dtc-tmp) $< ; \
>> -d $(depfile).dtc.tmp $(dtc-tmp) ; \
>> cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
>> -$(obj)/%.dtb: $(src)/%.dts FORCE
>> +$(obj)/%.dtb: $(src)/%.dts
>> $(call if_changed_dep,dtc)
>> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: Adding selftest testdata dynamically into live tree
@ 2014-09-26 15:07 ` Grant Likely
0 siblings, 0 replies; 7+ messages in thread
From: Grant Likely @ 2014-09-26 15:07 UTC (permalink / raw)
To: Janusz Użycki; +Cc: Gaurav Minocha, devicetree, linux-kbuild, Michal Marek
On Fri, Sep 26, 2014 at 2:36 PM, Janusz Użycki <j.uzycki@elproma.com.pl> wrote:
> The patch didn't help. Exactly the same.
Odd it worked here. It's moot anyway though because it breaks checking
dependencies on .dts files. I need someone stronger on kbuild-foo to
figure this out out. I've cc'd Michal and the kbuild mailing list.
Hopefully someone there can help figure this out.
g.
>
> best regards
> Janusz
>
> W dniu 2014-09-26 14:09, Grant Likely pisze:
>
>> On Mon, 22 Sep 2014 20:05:37 +0200, Janusz Użycki
>> <j.uzycki@elproma.com.pl> wrote:
>>>
>>> Hi.
>>>
>>> On 3.17.0-rc6-next-20140922+ with CONFIG_OF_SELFTEST enabled
>>> zImage is recreated every time I call "make" despite I've not done
>>> any change in source files and zImage was the same.
>>> This is caused by the rm line:
>>> CALL scripts/checksyscalls.sh
>>> CHK include/generated/compile.h
>>> DTC drivers/of/testcase-data/testcases.dtb
>>> DTB drivers/of/testcase-data/testcases.dtb.S
>>> AS drivers/of/testcase-data/testcases.dtb.o
>>> LD drivers/of/of_selftest.o
>>> LD drivers/of/built-in.o
>>> rm drivers/of/testcase-data/testcases.dtb.S
>>> drivers/of/testcase-data/testcases.dtb
>>> LD drivers/built-in.o
>>> LINK vmlinux
>>> LD vmlinux.o
>>
>> Try this change:
>>
>> diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib
>> index 260bf8acfce9..4555e2e1b4ed 100644
>> --- a/scripts/Makefile.lib
>> +++ b/scripts/Makefile.lib
>> @@ -269,7 +269,7 @@ cmd_dtc = $(CPP) $(dtc_cpp_flags) -x
>> assembler-with-cpp -o $(dtc-tmp) $< ; \
>> -d $(depfile).dtc.tmp $(dtc-tmp) ; \
>> cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile)
>> -$(obj)/%.dtb: $(src)/%.dts FORCE
>> +$(obj)/%.dtb: $(src)/%.dts
>> $(call if_changed_dep,dtc)
>> dtc-tmp = $(subst $(comma),_,$(dot-target).dts.tmp)
>>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2014-09-26 15:07 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-22 18:05 Adding selftest testdata dynamically into live tree Janusz Użycki
[not found] ` <542064F1.4000601-9tnw74Q4ehaHKKo6LODCOg@public.gmane.org>
2014-09-24 18:03 ` Gaurav Minocha
[not found] ` <CA+rpMbKkS1D=QYSMftgZyTMbHS9+O=YjR+OL_RvzjJPjo2Ox6w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-09-24 18:05 ` Janusz Użycki
2014-09-26 12:09 ` Grant Likely
[not found] ` <20140926120917.B60B4C40FEB-WNowdnHR2B42iJbIjFUEsiwD8/FfD2ys@public.gmane.org>
2014-09-26 13:36 ` Janusz Użycki
2014-09-26 15:07 ` Grant Likely
2014-09-26 15:07 ` Grant Likely
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.