From: Markos Chandras <Markos.Chandras@imgtec.com>
To: <linux-mips@linux-mips.org>
Subject: Re: [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+
Date: Fri, 10 Oct 2014 15:40:26 +0100 [thread overview]
Message-ID: <5437EFDA.4060709@imgtec.com> (raw)
In-Reply-To: <5437EFB7.2020106@imgtec.com>
On 10/10/2014 03:39 PM, Markos Chandras wrote:
> On 08/25/2014 08:29 PM, Manuel Lauss wrote:
>> On Mon, Aug 25, 2014 at 4:27 PM, Maciej W. Rozycki <macro@linux-mips.org> wrote:
>>
>>> 1. Determine whether `-Wa,-msoft-float' and `.set hardfloat' are available
>>> (a single check will do, they were added to GAS both at the same time)
>>> and only enable them if supported by binutils being used to build the
>>> kernel, e.g. (for the `.set' part):
>>>
>>> #ifdef GAS_HAS_SET_HARDFLOAT
>>> #define SET_HARDFLOAT .set hardfloat
>>> #else
>>> #define SET_HARDFLOAT
>>> #endif
>>>
>>> Otherwise we'd have to bump the binutils requirement up to 2.19; this
>>
>> Do people really update their toolchain so rarely?
>>
>>
>>> 2. Use `.set hardfloat' only around the places that really require it,
>>> i.e.:
>>>
>>> .set push
>>> SET_HARDFLOAT
>>> # Do the FP stuff.
>>> .set pop
>>>
>>> (so the arch/mips/kernel/r4k_fpu.S piece is good except for maybe using
>>> a macro, depending on the outcome of #1 above, but the other ones are
>>> not).
>>
>> I'll update the patch.
>>
>> Thank you!
>> Manuel
>>
> Hi Manual,
>
> Just wanted to ping you about this patch. Do you intend to submit a new
> version including all the feedback from Ralf, Maciej and Matthew?
>
s/Manual/Manuel/ :)
sorry about that
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: linux-mips@linux-mips.org
Subject: Re: [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+
Date: Fri, 10 Oct 2014 15:40:26 +0100 [thread overview]
Message-ID: <5437EFDA.4060709@imgtec.com> (raw)
Message-ID: <20141010144026.RCzbsF9FP1oUE7rHfOaSNsO6o5fiVY_BCh6okhDz_vY@z> (raw)
In-Reply-To: <5437EFB7.2020106@imgtec.com>
On 10/10/2014 03:39 PM, Markos Chandras wrote:
> On 08/25/2014 08:29 PM, Manuel Lauss wrote:
>> On Mon, Aug 25, 2014 at 4:27 PM, Maciej W. Rozycki <macro@linux-mips.org> wrote:
>>
>>> 1. Determine whether `-Wa,-msoft-float' and `.set hardfloat' are available
>>> (a single check will do, they were added to GAS both at the same time)
>>> and only enable them if supported by binutils being used to build the
>>> kernel, e.g. (for the `.set' part):
>>>
>>> #ifdef GAS_HAS_SET_HARDFLOAT
>>> #define SET_HARDFLOAT .set hardfloat
>>> #else
>>> #define SET_HARDFLOAT
>>> #endif
>>>
>>> Otherwise we'd have to bump the binutils requirement up to 2.19; this
>>
>> Do people really update their toolchain so rarely?
>>
>>
>>> 2. Use `.set hardfloat' only around the places that really require it,
>>> i.e.:
>>>
>>> .set push
>>> SET_HARDFLOAT
>>> # Do the FP stuff.
>>> .set pop
>>>
>>> (so the arch/mips/kernel/r4k_fpu.S piece is good except for maybe using
>>> a macro, depending on the outcome of #1 above, but the other ones are
>>> not).
>>
>> I'll update the patch.
>>
>> Thank you!
>> Manuel
>>
> Hi Manual,
>
> Just wanted to ping you about this patch. Do you intend to submit a new
> version including all the feedback from Ralf, Maciej and Matthew?
>
s/Manual/Manuel/ :)
sorry about that
--
markos
next prev parent reply other threads:[~2014-10-10 14:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-19 16:27 [RFC PATCH V2] MIPS: fix build with binutils 2.24.51+ Manuel Lauss
2014-08-25 12:51 ` Ralf Baechle
2014-08-25 14:27 ` Maciej W. Rozycki
2014-08-25 19:29 ` Manuel Lauss
2014-08-25 19:57 ` Ralf Baechle
2014-08-25 19:57 ` Maciej W. Rozycki
2014-08-26 10:45 ` Matthew Fortune
2014-08-26 10:45 ` Matthew Fortune
2014-10-10 14:39 ` Markos Chandras
2014-10-10 14:39 ` Markos Chandras
2014-10-10 14:40 ` Markos Chandras [this message]
2014-10-10 14:40 ` Markos Chandras
2014-10-11 6:53 ` Manuel Lauss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437EFDA.4060709@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.