From: "Cédric Le Goater" <clg@kaod.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org, Stewart Smith <stewart@linux.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support
Date: Mon, 25 Feb 2019 11:11:58 +0100 [thread overview]
Message-ID: <543ff6a2-b892-6710-d218-6aed1414840f@kaod.org> (raw)
In-Reply-To: <87y364jzlz.fsf@concordia.ellerman.id.au>
On 2/25/19 4:50 AM, Michael Ellerman wrote:
> Cédric Le Goater <clg@kaod.org> writes:
>
>> The support for XIVE native exploitation mode in Linux/KVM needs a
>> couple more OPAL calls to configure the sPAPR guest and to get/set the
>> state of the XIVE internal structures.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> arch/powerpc/include/asm/opal-api.h | 11 ++-
>> arch/powerpc/include/asm/opal.h | 7 ++
>> arch/powerpc/include/asm/xive.h | 14 +++
>> arch/powerpc/sysdev/xive/native.c | 99 +++++++++++++++++++
>> .../powerpc/platforms/powernv/opal-wrappers.S | 3 +
>> 5 files changed, 130 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/opal-api.h b/arch/powerpc/include/asm/opal-api.h
>> index 870fb7b239ea..cdfc54f78101 100644
>> --- a/arch/powerpc/include/asm/opal-api.h
>> +++ b/arch/powerpc/include/asm/opal-api.h
>> @@ -186,8 +186,8 @@
>> #define OPAL_XIVE_FREE_IRQ 140
>> #define OPAL_XIVE_SYNC 141
>> #define OPAL_XIVE_DUMP 142
>> -#define OPAL_XIVE_RESERVED3 143
>> -#define OPAL_XIVE_RESERVED4 144
>> +#define OPAL_XIVE_GET_QUEUE_STATE 143
>> +#define OPAL_XIVE_SET_QUEUE_STATE 144
>> #define OPAL_SIGNAL_SYSTEM_RESET 145
>> #define OPAL_NPU_INIT_CONTEXT 146
>> #define OPAL_NPU_DESTROY_CONTEXT 147
>> @@ -209,8 +209,11 @@
>> #define OPAL_SENSOR_GROUP_ENABLE 163
>> #define OPAL_PCI_GET_PBCQ_TUNNEL_BAR 164
>> #define OPAL_PCI_SET_PBCQ_TUNNEL_BAR 165
>> -#define OPAL_NX_COPROC_INIT 167
>> -#define OPAL_LAST 167
>> +#define OPAL_HANDLE_HMI2 166
>> +#define OPAL_NX_COPROC_INIT 167
>> +#define OPAL_NPU_SET_RELAXED_ORDER 168
>> +#define OPAL_NPU_GET_RELAXED_ORDER 169
>> +#define OPAL_XIVE_GET_VP_STATE 170
>
> You should only be defining the calls you need, leaving gaps for other
> things, and you need to retain OPAL_LAST. So it should look more like:
>
> -#define OPAL_LAST 167
> +#define OPAL_XIVE_GET_VP_STATE 170
> +#define OPAL_LAST 170
>
>
> Also I can't merge this until it's merged into skiboot.
OK. Let's start with skiboot.
C.
WARNING: multiple messages have this Message-ID (diff)
From: "Cédric Le Goater" <clg@kaod.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
kvm-ppc@vger.kernel.org, Stewart Smith <stewart@linux.ibm.com>
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v2 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support
Date: Mon, 25 Feb 2019 10:11:58 +0000 [thread overview]
Message-ID: <543ff6a2-b892-6710-d218-6aed1414840f@kaod.org> (raw)
In-Reply-To: <87y364jzlz.fsf@concordia.ellerman.id.au>
On 2/25/19 4:50 AM, Michael Ellerman wrote:
> Cédric Le Goater <clg@kaod.org> writes:
>
>> The support for XIVE native exploitation mode in Linux/KVM needs a
>> couple more OPAL calls to configure the sPAPR guest and to get/set the
>> state of the XIVE internal structures.
>>
>> Signed-off-by: Cédric Le Goater <clg@kaod.org>
>> ---
>> arch/powerpc/include/asm/opal-api.h | 11 ++-
>> arch/powerpc/include/asm/opal.h | 7 ++
>> arch/powerpc/include/asm/xive.h | 14 +++
>> arch/powerpc/sysdev/xive/native.c | 99 +++++++++++++++++++
>> .../powerpc/platforms/powernv/opal-wrappers.S | 3 +
>> 5 files changed, 130 insertions(+), 4 deletions(-)
>>
>> diff --git a/arch/powerpc/include/asm/opal-api.h b/arch/powerpc/include/asm/opal-api.h
>> index 870fb7b239ea..cdfc54f78101 100644
>> --- a/arch/powerpc/include/asm/opal-api.h
>> +++ b/arch/powerpc/include/asm/opal-api.h
>> @@ -186,8 +186,8 @@
>> #define OPAL_XIVE_FREE_IRQ 140
>> #define OPAL_XIVE_SYNC 141
>> #define OPAL_XIVE_DUMP 142
>> -#define OPAL_XIVE_RESERVED3 143
>> -#define OPAL_XIVE_RESERVED4 144
>> +#define OPAL_XIVE_GET_QUEUE_STATE 143
>> +#define OPAL_XIVE_SET_QUEUE_STATE 144
>> #define OPAL_SIGNAL_SYSTEM_RESET 145
>> #define OPAL_NPU_INIT_CONTEXT 146
>> #define OPAL_NPU_DESTROY_CONTEXT 147
>> @@ -209,8 +209,11 @@
>> #define OPAL_SENSOR_GROUP_ENABLE 163
>> #define OPAL_PCI_GET_PBCQ_TUNNEL_BAR 164
>> #define OPAL_PCI_SET_PBCQ_TUNNEL_BAR 165
>> -#define OPAL_NX_COPROC_INIT 167
>> -#define OPAL_LAST 167
>> +#define OPAL_HANDLE_HMI2 166
>> +#define OPAL_NX_COPROC_INIT 167
>> +#define OPAL_NPU_SET_RELAXED_ORDER 168
>> +#define OPAL_NPU_GET_RELAXED_ORDER 169
>> +#define OPAL_XIVE_GET_VP_STATE 170
>
> You should only be defining the calls you need, leaving gaps for other
> things, and you need to retain OPAL_LAST. So it should look more like:
>
> -#define OPAL_LAST 167
> +#define OPAL_XIVE_GET_VP_STATE 170
> +#define OPAL_LAST 170
>
>
> Also I can't merge this until it's merged into skiboot.
OK. Let's start with skiboot.
C.
next prev parent reply other threads:[~2019-02-25 10:11 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-22 11:28 [PATCH v2 00/16] KVM: PPC: Book3S HV: add XIVE native exploitation mode Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-24 23:42 ` David Gibson
2019-02-24 23:42 ` David Gibson
2019-02-25 3:50 ` Michael Ellerman
2019-02-25 3:50 ` Michael Ellerman
2019-02-25 10:11 ` Cédric Le Goater [this message]
2019-02-25 10:11 ` Cédric Le Goater
2019-02-26 4:21 ` David Gibson
2019-02-26 4:21 ` David Gibson
2019-03-12 18:25 ` Cédric Le Goater
2019-03-12 18:25 ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 02/16] KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 0:08 ` David Gibson
2019-02-25 0:08 ` David Gibson
2019-03-12 11:14 ` Cédric Le Goater
2019-03-12 11:14 ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 0:35 ` David Gibson
2019-02-25 0:35 ` David Gibson
2019-02-25 4:59 ` Paul Mackerras
2019-02-25 4:59 ` Paul Mackerras
2019-03-12 14:10 ` Cédric Le Goater
2019-03-12 14:10 ` Cédric Le Goater
2019-03-12 14:03 ` Cédric Le Goater
2019-03-12 14:03 ` Cédric Le Goater
2019-03-13 4:05 ` David Gibson
2019-03-13 4:05 ` David Gibson
2019-02-25 4:35 ` Paul Mackerras
2019-02-25 4:35 ` Paul Mackerras
2019-03-13 8:34 ` Cédric Le Goater
2019-03-13 8:34 ` Cédric Le Goater
2019-03-14 2:29 ` David Gibson
2019-03-14 2:29 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 04/16] KVM: PPC: Book3S HV: XIVE: add a control to initialize a source Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:10 ` David Gibson
2019-02-25 2:10 ` David Gibson
2019-02-26 4:25 ` Paul Mackerras
2019-02-26 4:25 ` Paul Mackerras
2019-02-26 23:20 ` David Gibson
2019-02-26 23:20 ` David Gibson
2019-03-12 15:19 ` Cédric Le Goater
2019-03-12 15:19 ` Cédric Le Goater
2019-03-14 2:15 ` David Gibson
2019-03-14 2:15 ` David Gibson
2019-02-25 5:30 ` Paul Mackerras
2019-02-25 5:30 ` Paul Mackerras
2019-02-22 11:28 ` [PATCH v2 05/16] KVM: PPC: Book3S HV: XIVE: add a control to configure " Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:21 ` David Gibson
2019-02-25 2:21 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:39 ` David Gibson
2019-02-25 2:39 ` David Gibson
2019-03-12 17:00 ` Cédric Le Goater
2019-03-12 17:00 ` Cédric Le Goater
2019-03-13 4:03 ` David Gibson
2019-03-13 4:03 ` David Gibson
2019-03-13 8:46 ` Cédric Le Goater
2019-03-13 8:46 ` Cédric Le Goater
2019-03-14 3:29 ` David Gibson
2019-03-14 3:29 ` David Gibson
2019-02-26 5:24 ` Paul Mackerras
2019-02-26 5:24 ` Paul Mackerras
2019-03-13 9:40 ` Cédric Le Goater
2019-03-13 9:40 ` Cédric Le Goater
2019-03-14 2:32 ` David Gibson
2019-03-14 2:32 ` David Gibson
2019-03-14 7:11 ` Cédric Le Goater
2019-03-14 7:11 ` Cédric Le Goater
2019-03-15 0:29 ` David Gibson
2019-03-15 0:29 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 07/16] KVM: PPC: Book3S HV: XIVE: add a global reset control Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:43 ` David Gibson
2019-02-25 2:43 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 08/16] KVM: PPC: Book3S HV: XIVE: add a control to sync the sources Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:45 ` David Gibson
2019-02-25 2:45 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 09/16] KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 2:53 ` David Gibson
2019-02-25 2:53 ` David Gibson
2019-03-13 11:48 ` Cédric Le Goater
2019-03-13 11:48 ` Cédric Le Goater
2019-03-14 2:33 ` David Gibson
2019-03-14 2:33 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 10/16] KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 3:31 ` David Gibson
2019-02-25 3:31 ` David Gibson
2019-03-13 13:19 ` Cédric Le Goater
2019-03-13 13:19 ` Cédric Le Goater
2019-03-14 3:09 ` David Gibson
2019-03-14 3:09 ` David Gibson
2019-03-14 7:08 ` Cédric Le Goater
2019-03-14 7:08 ` Cédric Le Goater
2019-02-22 11:28 ` [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 3:33 ` David Gibson
2019-02-25 3:33 ` David Gibson
2019-02-25 10:57 ` Cédric Le Goater
2019-02-25 10:57 ` Cédric Le Goater
2019-02-26 12:52 ` Paolo Bonzini
2019-02-26 12:52 ` Paolo Bonzini
2019-02-26 23:22 ` David Gibson
2019-02-26 23:22 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 12/16] KVM: PPC: Book3S HV: XIVE: add a TIMA mapping Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 3:42 ` David Gibson
2019-02-25 3:42 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 13/16] KVM: PPC: Book3S HV: XIVE: add a mapping for the source ESB pages Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 3:47 ` David Gibson
2019-02-25 3:47 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 14/16] KVM: PPC: Book3S HV: XIVE: add passthrough support Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 4:13 ` David Gibson
2019-02-25 4:13 ` David Gibson
2019-02-22 11:28 ` [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 4:15 ` David Gibson
2019-02-25 4:15 ` David Gibson
2019-03-13 8:02 ` Cédric Le Goater
2019-03-13 8:02 ` Cédric Le Goater
2019-03-15 17:57 ` Paolo Bonzini
2019-03-15 17:57 ` Paolo Bonzini
2019-02-22 11:28 ` [PATCH v2 16/16] KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters Cédric Le Goater
2019-02-22 11:28 ` Cédric Le Goater
2019-02-25 4:18 ` David Gibson
2019-02-25 4:18 ` David Gibson
2019-03-13 8:17 ` Cédric Le Goater
2019-03-13 8:17 ` Cédric Le Goater
2019-03-14 2:26 ` David Gibson
2019-03-14 2:26 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543ff6a2-b892-6710-d218-6aed1414840f@kaod.org \
--to=clg@kaod.org \
--cc=david@gibson.dropbear.id.au \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=stewart@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.