From: "Cédric Le Goater" <clg@kaod.org> To: David Gibson <david@gibson.dropbear.id.au> Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Paolo Bonzini <pbonzini@redhat.com>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices Date: Mon, 25 Feb 2019 11:57:02 +0100 [thread overview] Message-ID: <c906cf13-fb2a-3a76-4382-2a7f98496c05@kaod.org> (raw) In-Reply-To: <20190225033309.GO7668@umbus.fritz.box> Hello Paolo, On 2/25/19 4:33 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:35PM +0100, Cédric Le Goater wrote: >> Some KVM devices will want to handle special mappings related to the >> underlying HW. For instance, the XIVE interrupt controller of the >> POWER9 processor has MMIO pages for thread interrupt management and >> for interrupt source control that need to be exposed to the guest when >> the OS has the required support. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Ah, when I suggested mmap() on the base device fd, I hadn't realized > there wasn't a facility for that yet. > > Have you discussed this with Paolo? Not yet. > We'll need some core KVM buy in to merge this. Here is an extension of the KVM device to allow special mappings. Something we would need for the support of the POWER9 XIVE interrupt controller. There are two MMIOs we need to expose to the guest : 1. HW MMIO controlling of the interrupt presenter registers (TIMA) 2. HW MMIO of the interrupt sources for interrupt management (ESB) The TIMA could have been exposed with a page offset in the vCPU mapping but as it only makes sense when the XIVE interrupt mode is active, we chose to use directly the KVM device fd for that. Is that ok ? An alternate solution is to use a device ioctl to allocate an anon fd and do the mapping, but that seems like extra fuss for the same result. Thanks, C. >> --- >> include/linux/kvm_host.h | 1 + >> virt/kvm/kvm_main.c | 11 +++++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> index c38cc5eb7e73..cbf81487b69f 100644 >> --- a/include/linux/kvm_host.h >> +++ b/include/linux/kvm_host.h >> @@ -1223,6 +1223,7 @@ struct kvm_device_ops { >> int (*has_attr)(struct kvm_device *dev, struct kvm_device_attr *attr); >> long (*ioctl)(struct kvm_device *dev, unsigned int ioctl, >> unsigned long arg); >> + int (*mmap)(struct kvm_device *dev, struct vm_area_struct *vma); >> }; >> >> void kvm_device_get(struct kvm_device *dev); >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 585845203db8..84717d8cb5e4 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -2878,6 +2878,16 @@ static long kvm_vcpu_compat_ioctl(struct file *filp, >> } >> #endif >> >> +static int kvm_device_mmap(struct file *filp, struct vm_area_struct *vma) >> +{ >> + struct kvm_device *dev = filp->private_data; >> + >> + if (dev->ops->mmap) >> + return dev->ops->mmap(dev, vma); >> + >> + return -ENODEV; >> +} >> + >> static int kvm_device_ioctl_attr(struct kvm_device *dev, >> int (*accessor)(struct kvm_device *dev, >> struct kvm_device_attr *attr), >> @@ -2927,6 +2937,7 @@ static const struct file_operations kvm_device_fops = { >> .unlocked_ioctl = kvm_device_ioctl, >> .release = kvm_device_release, >> KVM_COMPAT(kvm_device_ioctl), >> + .mmap = kvm_device_mmap, >> }; >> >> struct kvm_device *kvm_device_from_filp(struct file *filp) >
WARNING: multiple messages have this Message-ID (diff)
From: "Cédric Le Goater" <clg@kaod.org> To: David Gibson <david@gibson.dropbear.id.au> Cc: kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras <paulus@samba.org>, Paolo Bonzini <pbonzini@redhat.com>, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices Date: Mon, 25 Feb 2019 10:57:02 +0000 [thread overview] Message-ID: <c906cf13-fb2a-3a76-4382-2a7f98496c05@kaod.org> (raw) In-Reply-To: <20190225033309.GO7668@umbus.fritz.box> Hello Paolo, On 2/25/19 4:33 AM, David Gibson wrote: > On Fri, Feb 22, 2019 at 12:28:35PM +0100, Cédric Le Goater wrote: >> Some KVM devices will want to handle special mappings related to the >> underlying HW. For instance, the XIVE interrupt controller of the >> POWER9 processor has MMIO pages for thread interrupt management and >> for interrupt source control that need to be exposed to the guest when >> the OS has the required support. >> >> Signed-off-by: Cédric Le Goater <clg@kaod.org> > > Ah, when I suggested mmap() on the base device fd, I hadn't realized > there wasn't a facility for that yet. > > Have you discussed this with Paolo? Not yet. > We'll need some core KVM buy in to merge this. Here is an extension of the KVM device to allow special mappings. Something we would need for the support of the POWER9 XIVE interrupt controller. There are two MMIOs we need to expose to the guest : 1. HW MMIO controlling of the interrupt presenter registers (TIMA) 2. HW MMIO of the interrupt sources for interrupt management (ESB) The TIMA could have been exposed with a page offset in the vCPU mapping but as it only makes sense when the XIVE interrupt mode is active, we chose to use directly the KVM device fd for that. Is that ok ? An alternate solution is to use a device ioctl to allocate an anon fd and do the mapping, but that seems like extra fuss for the same result. Thanks, C. >> --- >> include/linux/kvm_host.h | 1 + >> virt/kvm/kvm_main.c | 11 +++++++++++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h >> index c38cc5eb7e73..cbf81487b69f 100644 >> --- a/include/linux/kvm_host.h >> +++ b/include/linux/kvm_host.h >> @@ -1223,6 +1223,7 @@ struct kvm_device_ops { >> int (*has_attr)(struct kvm_device *dev, struct kvm_device_attr *attr); >> long (*ioctl)(struct kvm_device *dev, unsigned int ioctl, >> unsigned long arg); >> + int (*mmap)(struct kvm_device *dev, struct vm_area_struct *vma); >> }; >> >> void kvm_device_get(struct kvm_device *dev); >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 585845203db8..84717d8cb5e4 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -2878,6 +2878,16 @@ static long kvm_vcpu_compat_ioctl(struct file *filp, >> } >> #endif >> >> +static int kvm_device_mmap(struct file *filp, struct vm_area_struct *vma) >> +{ >> + struct kvm_device *dev = filp->private_data; >> + >> + if (dev->ops->mmap) >> + return dev->ops->mmap(dev, vma); >> + >> + return -ENODEV; >> +} >> + >> static int kvm_device_ioctl_attr(struct kvm_device *dev, >> int (*accessor)(struct kvm_device *dev, >> struct kvm_device_attr *attr), >> @@ -2927,6 +2937,7 @@ static const struct file_operations kvm_device_fops = { >> .unlocked_ioctl = kvm_device_ioctl, >> .release = kvm_device_release, >> KVM_COMPAT(kvm_device_ioctl), >> + .mmap = kvm_device_mmap, >> }; >> >> struct kvm_device *kvm_device_from_filp(struct file *filp) >
next prev parent reply other threads:[~2019-02-25 10:57 UTC|newest] Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-22 11:28 [PATCH v2 00/16] KVM: PPC: Book3S HV: add XIVE native exploitation mode Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-22 11:28 ` [PATCH v2 01/16] powerpc/xive: add OPAL extensions for the XIVE native exploitation support Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-24 23:42 ` David Gibson 2019-02-24 23:42 ` David Gibson 2019-02-25 3:50 ` Michael Ellerman 2019-02-25 3:50 ` Michael Ellerman 2019-02-25 10:11 ` Cédric Le Goater 2019-02-25 10:11 ` Cédric Le Goater 2019-02-26 4:21 ` David Gibson 2019-02-26 4:21 ` David Gibson 2019-03-12 18:25 ` Cédric Le Goater 2019-03-12 18:25 ` Cédric Le Goater 2019-02-22 11:28 ` [PATCH v2 02/16] KVM: PPC: Book3S HV: add a new KVM device for the XIVE native exploitation mode Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 0:08 ` David Gibson 2019-02-25 0:08 ` David Gibson 2019-03-12 11:14 ` Cédric Le Goater 2019-03-12 11:14 ` Cédric Le Goater 2019-02-22 11:28 ` [PATCH v2 03/16] KVM: PPC: Book3S HV: XIVE: introduce a new capability KVM_CAP_PPC_IRQ_XIVE Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 0:35 ` David Gibson 2019-02-25 0:35 ` David Gibson 2019-02-25 4:59 ` Paul Mackerras 2019-02-25 4:59 ` Paul Mackerras 2019-03-12 14:10 ` Cédric Le Goater 2019-03-12 14:10 ` Cédric Le Goater 2019-03-12 14:03 ` Cédric Le Goater 2019-03-12 14:03 ` Cédric Le Goater 2019-03-13 4:05 ` David Gibson 2019-03-13 4:05 ` David Gibson 2019-02-25 4:35 ` Paul Mackerras 2019-02-25 4:35 ` Paul Mackerras 2019-03-13 8:34 ` Cédric Le Goater 2019-03-13 8:34 ` Cédric Le Goater 2019-03-14 2:29 ` David Gibson 2019-03-14 2:29 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 04/16] KVM: PPC: Book3S HV: XIVE: add a control to initialize a source Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:10 ` David Gibson 2019-02-25 2:10 ` David Gibson 2019-02-26 4:25 ` Paul Mackerras 2019-02-26 4:25 ` Paul Mackerras 2019-02-26 23:20 ` David Gibson 2019-02-26 23:20 ` David Gibson 2019-03-12 15:19 ` Cédric Le Goater 2019-03-12 15:19 ` Cédric Le Goater 2019-03-14 2:15 ` David Gibson 2019-03-14 2:15 ` David Gibson 2019-02-25 5:30 ` Paul Mackerras 2019-02-25 5:30 ` Paul Mackerras 2019-02-22 11:28 ` [PATCH v2 05/16] KVM: PPC: Book3S HV: XIVE: add a control to configure " Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:21 ` David Gibson 2019-02-25 2:21 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 06/16] KVM: PPC: Book3S HV: XIVE: add controls for the EQ configuration Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:39 ` David Gibson 2019-02-25 2:39 ` David Gibson 2019-03-12 17:00 ` Cédric Le Goater 2019-03-12 17:00 ` Cédric Le Goater 2019-03-13 4:03 ` David Gibson 2019-03-13 4:03 ` David Gibson 2019-03-13 8:46 ` Cédric Le Goater 2019-03-13 8:46 ` Cédric Le Goater 2019-03-14 3:29 ` David Gibson 2019-03-14 3:29 ` David Gibson 2019-02-26 5:24 ` Paul Mackerras 2019-02-26 5:24 ` Paul Mackerras 2019-03-13 9:40 ` Cédric Le Goater 2019-03-13 9:40 ` Cédric Le Goater 2019-03-14 2:32 ` David Gibson 2019-03-14 2:32 ` David Gibson 2019-03-14 7:11 ` Cédric Le Goater 2019-03-14 7:11 ` Cédric Le Goater 2019-03-15 0:29 ` David Gibson 2019-03-15 0:29 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 07/16] KVM: PPC: Book3S HV: XIVE: add a global reset control Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:43 ` David Gibson 2019-02-25 2:43 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 08/16] KVM: PPC: Book3S HV: XIVE: add a control to sync the sources Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:45 ` David Gibson 2019-02-25 2:45 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 09/16] KVM: PPC: Book3S HV: XIVE: add a control to dirty the XIVE EQ pages Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 2:53 ` David Gibson 2019-02-25 2:53 ` David Gibson 2019-03-13 11:48 ` Cédric Le Goater 2019-03-13 11:48 ` Cédric Le Goater 2019-03-14 2:33 ` David Gibson 2019-03-14 2:33 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 10/16] KVM: PPC: Book3S HV: XIVE: add get/set accessors for the VP XIVE state Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 3:31 ` David Gibson 2019-02-25 3:31 ` David Gibson 2019-03-13 13:19 ` Cédric Le Goater 2019-03-13 13:19 ` Cédric Le Goater 2019-03-14 3:09 ` David Gibson 2019-03-14 3:09 ` David Gibson 2019-03-14 7:08 ` Cédric Le Goater 2019-03-14 7:08 ` Cédric Le Goater 2019-02-22 11:28 ` [PATCH v2 11/16] KVM: introduce a 'mmap' method for KVM devices Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 3:33 ` David Gibson 2019-02-25 3:33 ` David Gibson 2019-02-25 10:57 ` Cédric Le Goater [this message] 2019-02-25 10:57 ` Cédric Le Goater 2019-02-26 12:52 ` Paolo Bonzini 2019-02-26 12:52 ` Paolo Bonzini 2019-02-26 23:22 ` David Gibson 2019-02-26 23:22 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 12/16] KVM: PPC: Book3S HV: XIVE: add a TIMA mapping Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 3:42 ` David Gibson 2019-02-25 3:42 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 13/16] KVM: PPC: Book3S HV: XIVE: add a mapping for the source ESB pages Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 3:47 ` David Gibson 2019-02-25 3:47 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 14/16] KVM: PPC: Book3S HV: XIVE: add passthrough support Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 4:13 ` David Gibson 2019-02-25 4:13 ` David Gibson 2019-02-22 11:28 ` [PATCH v2 15/16] KVM: introduce a KVM_DESTROY_DEVICE ioctl Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 4:15 ` David Gibson 2019-02-25 4:15 ` David Gibson 2019-03-13 8:02 ` Cédric Le Goater 2019-03-13 8:02 ` Cédric Le Goater 2019-03-15 17:57 ` Paolo Bonzini 2019-03-15 17:57 ` Paolo Bonzini 2019-02-22 11:28 ` [PATCH v2 16/16] KVM: PPC: Book3S HV: XIVE: clear the vCPU interrupt presenters Cédric Le Goater 2019-02-22 11:28 ` Cédric Le Goater 2019-02-25 4:18 ` David Gibson 2019-02-25 4:18 ` David Gibson 2019-03-13 8:17 ` Cédric Le Goater 2019-03-13 8:17 ` Cédric Le Goater 2019-03-14 2:26 ` David Gibson 2019-03-14 2:26 ` David Gibson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c906cf13-fb2a-3a76-4382-2a7f98496c05@kaod.org \ --to=clg@kaod.org \ --cc=david@gibson.dropbear.id.au \ --cc=kvm-ppc@vger.kernel.org \ --cc=kvm@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=paulus@samba.org \ --cc=pbonzini@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.