* [PATCH v3 1/6] riscv: dts: sifive unmatched: Name gpio lines
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Follow the pin descriptions given in the version 3 of the board schematics.
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 4f66919215f6..305a086e5207 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -245,4 +245,8 @@ &pwm1 {
&gpio {
status = "okay";
+ gpio-line-names = "J29.1", "PMICNTB", "PMICSHDN", "J8.1", "J8.3",
+ "PCIe_PWREN", "THERM", "UBRDG_RSTN", "PCIe_PERSTN",
+ "ULPI_RSTN", "J8.2", "UHUB_RSTN", "GEMGXL_RST", "J8.4",
+ "EN_VDD_SD", "SD_CD";
};
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 2/6] riscv: dts: sifive unmatched: Expose the board ID eeprom
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-19 22:55 ` Vincent Pelletier
-1 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Mark it as read-only as it is factory-programmed with identifying
information, and no executable nor configuration:
- eth MAC address
- board model (PCB version, BoM version)
- board serial number
Accidental modification would cause misidentification which could brick
the board, so marking read-only seem like both a safe and non-constraining
choice.
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 305a086e5207..cf8937708829 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -58,6 +58,16 @@ temperature-sensor@4c {
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
};
+ eeprom@54 {
+ compatible = "microchip,24c02", "atmel,24c02";
+ reg = <0x54>;
+ vcc-supply = <&vdd_bpro>;
+ label = "board-id";
+ pagesize = <16>;
+ read-only;
+ size = <256>;
+ };
+
pmic@58 {
compatible = "dlg,da9063";
reg = <0x58>;
--
2.33.1
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 2/6] riscv: dts: sifive unmatched: Expose the board ID eeprom
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Mark it as read-only as it is factory-programmed with identifying
information, and no executable nor configuration:
- eth MAC address
- board model (PCB version, BoM version)
- board serial number
Accidental modification would cause misidentification which could brick
the board, so marking read-only seem like both a safe and non-constraining
choice.
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 305a086e5207..cf8937708829 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -58,6 +58,16 @@ temperature-sensor@4c {
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
};
+ eeprom@54 {
+ compatible = "microchip,24c02", "atmel,24c02";
+ reg = <0x54>;
+ vcc-supply = <&vdd_bpro>;
+ label = "board-id";
+ pagesize = <16>;
+ read-only;
+ size = <256>;
+ };
+
pmic@58 {
compatible = "dlg,da9063";
reg = <0x58>;
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v3 2/6] riscv: dts: sifive unmatched: Expose the board ID eeprom
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-21 17:23 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:23 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Mark it as read-only as it is factory-programmed with identifying
> information, and no executable nor configuration:
> - eth MAC address
> - board model (PCB version, BoM version)
> - board serial number
> Accidental modification would cause misidentification which could brick
> the board, so marking read-only seem like both a safe and non-constraining
> choice.
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 2/6] riscv: dts: sifive unmatched: Expose the board ID eeprom
@ 2021-11-21 17:23 ` Krzysztof Kozlowski
0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:23 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Mark it as read-only as it is factory-programmed with identifying
> information, and no executable nor configuration:
> - eth MAC address
> - board model (PCB version, BoM version)
> - board serial number
> Accidental modification would cause misidentification which could brick
> the board, so marking read-only seem like both a safe and non-constraining
> choice.
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 3/6] riscv: dts: sifive unmatched: Expose the PMIC sub-functions
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-19 22:55 ` Vincent Pelletier
-1 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
These sub-functions are available in the chip revision on this board, so
expose them.
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index cf8937708829..270360b258b7 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -75,6 +75,18 @@ pmic@58 {
interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ };
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+
regulators {
vdd_bcore1: bcore1 {
regulator-min-microvolt = <900000>;
--
2.33.1
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 3/6] riscv: dts: sifive unmatched: Expose the PMIC sub-functions
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
These sub-functions are available in the chip revision on this board, so
expose them.
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index cf8937708829..270360b258b7 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -75,6 +75,18 @@ pmic@58 {
interrupts = <1 IRQ_TYPE_LEVEL_LOW>;
interrupt-controller;
+ onkey {
+ compatible = "dlg,da9063-onkey";
+ };
+
+ rtc {
+ compatible = "dlg,da9063-rtc";
+ };
+
+ wdt {
+ compatible = "dlg,da9063-watchdog";
+ };
+
regulators {
vdd_bcore1: bcore1 {
regulator-min-microvolt = <900000>;
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread
* [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-19 22:55 ` Vincent Pelletier
-1 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Provides monitoring of core voltage and current:
tps544b20-i2c-0-1e
Adapter: i2c-ocores
vout1: 906.00 mV
temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Note: checkpatch.pl complains about undocumented devicetree binding,
which is fixed by:
https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Added missing "ti," prefix in compatible string.
- Remove trailing "." on subject line.
- Rename tree node.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 270360b258b7..6e7775fdae32 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -51,6 +51,11 @@ &uart1 {
&i2c0 {
status = "okay";
+ regulator@1e {
+ compatible = "ti,tps544b20";
+ reg = <0x1e>;
+ };
+
temperature-sensor@4c {
compatible = "ti,tmp451";
reg = <0x4c>;
--
2.33.1
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Provides monitoring of core voltage and current:
tps544b20-i2c-0-1e
Adapter: i2c-ocores
vout1: 906.00 mV
temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Note: checkpatch.pl complains about undocumented devicetree binding,
which is fixed by:
https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Added missing "ti," prefix in compatible string.
- Remove trailing "." on subject line.
- Rename tree node.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 270360b258b7..6e7775fdae32 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -51,6 +51,11 @@ &uart1 {
&i2c0 {
status = "okay";
+ regulator@1e {
+ compatible = "ti,tps544b20";
+ reg = <0x1e>;
+ };
+
temperature-sensor@4c {
compatible = "ti,tmp451";
reg = <0x4c>;
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-21 17:24 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:24 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Provides monitoring of core voltage and current:
> tps544b20-i2c-0-1e
> Adapter: i2c-ocores
> vout1: 906.00 mV
> temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Note: checkpatch.pl complains about undocumented devicetree binding,
> which is fixed by:
> https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
>
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Added missing "ti," prefix in compatible string.
> - Remove trailing "." on subject line.
> - Rename tree node.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
@ 2021-11-21 17:24 ` Krzysztof Kozlowski
0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:24 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Provides monitoring of core voltage and current:
> tps544b20-i2c-0-1e
> Adapter: i2c-ocores
> vout1: 906.00 mV
> temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Note: checkpatch.pl complains about undocumented devicetree binding,
> which is fixed by:
> https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
>
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Added missing "ti," prefix in compatible string.
> - Remove trailing "." on subject line.
> - Rename tree node.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-12-17 5:35 ` Palmer Dabbelt
-1 siblings, 0 replies; 28+ messages in thread
From: Palmer Dabbelt @ 2021-12-17 5:35 UTC (permalink / raw)
To: plr.vincent
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov
On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> Provides monitoring of core voltage and current:
> tps544b20-i2c-0-1e
> Adapter: i2c-ocores
> vout1: 906.00 mV
> temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Note: checkpatch.pl complains about undocumented devicetree binding,
> which is fixed by:
> https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
>
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Added missing "ti," prefix in compatible string.
> - Remove trailing "." on subject line.
> - Rename tree node.
I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
TI DC-DC converters"), so I'm going to hold off on this one until the
bindings land.
I've put the others on fixes.
Thanks!
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 270360b258b7..6e7775fdae32 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -51,6 +51,11 @@ &uart1 {
> &i2c0 {
> status = "okay";
>
> + regulator@1e {
> + compatible = "ti,tps544b20";
> + reg = <0x1e>;
> + };
> +
> temperature-sensor@4c {
> compatible = "ti,tmp451";
> reg = <0x4c>;
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
@ 2021-12-17 5:35 ` Palmer Dabbelt
0 siblings, 0 replies; 28+ messages in thread
From: Palmer Dabbelt @ 2021-12-17 5:35 UTC (permalink / raw)
To: plr.vincent
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov
On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> Provides monitoring of core voltage and current:
> tps544b20-i2c-0-1e
> Adapter: i2c-ocores
> vout1: 906.00 mV
> temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Note: checkpatch.pl complains about undocumented devicetree binding,
> which is fixed by:
> https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
>
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Added missing "ti," prefix in compatible string.
> - Remove trailing "." on subject line.
> - Rename tree node.
I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
TI DC-DC converters"), so I'm going to hold off on this one until the
bindings land.
I've put the others on fixes.
Thanks!
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 270360b258b7..6e7775fdae32 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -51,6 +51,11 @@ &uart1 {
> &i2c0 {
> status = "okay";
>
> + regulator@1e {
> + compatible = "ti,tps544b20";
> + reg = <0x1e>;
> + };
> +
> temperature-sensor@4c {
> compatible = "ti,tmp451";
> reg = <0x4c>;
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
2021-12-17 5:35 ` Palmer Dabbelt
@ 2021-12-19 21:56 ` Heiko Stübner
-1 siblings, 0 replies; 28+ messages in thread
From: Heiko Stübner @ 2021-12-19 21:56 UTC (permalink / raw)
To: plr.vincent, linux-riscv
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov,
Palmer Dabbelt
Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt:
> On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> > Provides monitoring of core voltage and current:
> > tps544b20-i2c-0-1e
> > Adapter: i2c-ocores
> > vout1: 906.00 mV
> > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
> >
> > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> >
> > ---
> > Note: checkpatch.pl complains about undocumented devicetree binding,
> > which is fixed by:
> > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
> >
> > Changes since v2:
> > - Fix end-of-commit-message separator so change lists do not end up in them.
> > Changes since v1:
> > - Added missing "ti," prefix in compatible string.
> > - Remove trailing "." on subject line.
> > - Rename tree node.
>
> I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
> TI DC-DC converters"), so I'm going to hold off on this one until the
> bindings land.
Can't this patch then simply go into your for-next branch then?
The split is most times binding goes through the driver-tree
(or Rob's dt tree) and the dts patch through an arch or soc tree.
But in general once a maintainer accepts the binding it is ok
to also apply the dts patch for the same cycle (aka merge window)
the binding will be in.
Heiko
>
> I've put the others on fixes.
>
> Thanks!
>
> > ---
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 270360b258b7..6e7775fdae32 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -51,6 +51,11 @@ &uart1 {
> > &i2c0 {
> > status = "okay";
> >
> > + regulator@1e {
> > + compatible = "ti,tps544b20";
> > + reg = <0x1e>;
> > + };
> > +
> > temperature-sensor@4c {
> > compatible = "ti,tmp451";
> > reg = <0x4c>;
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
@ 2021-12-19 21:56 ` Heiko Stübner
0 siblings, 0 replies; 28+ messages in thread
From: Heiko Stübner @ 2021-12-19 21:56 UTC (permalink / raw)
To: plr.vincent, linux-riscv
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov,
Palmer Dabbelt
Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt:
> On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> > Provides monitoring of core voltage and current:
> > tps544b20-i2c-0-1e
> > Adapter: i2c-ocores
> > vout1: 906.00 mV
> > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
> >
> > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> >
> > ---
> > Note: checkpatch.pl complains about undocumented devicetree binding,
> > which is fixed by:
> > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
> >
> > Changes since v2:
> > - Fix end-of-commit-message separator so change lists do not end up in them.
> > Changes since v1:
> > - Added missing "ti," prefix in compatible string.
> > - Remove trailing "." on subject line.
> > - Rename tree node.
>
> I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
> TI DC-DC converters"), so I'm going to hold off on this one until the
> bindings land.
Can't this patch then simply go into your for-next branch then?
The split is most times binding goes through the driver-tree
(or Rob's dt tree) and the dts patch through an arch or soc tree.
But in general once a maintainer accepts the binding it is ok
to also apply the dts patch for the same cycle (aka merge window)
the binding will be in.
Heiko
>
> I've put the others on fixes.
>
> Thanks!
>
> > ---
> > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 270360b258b7..6e7775fdae32 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -51,6 +51,11 @@ &uart1 {
> > &i2c0 {
> > status = "okay";
> >
> > + regulator@1e {
> > + compatible = "ti,tps544b20";
> > + reg = <0x1e>;
> > + };
> > +
> > temperature-sensor@4c {
> > compatible = "ti,tmp451";
> > reg = <0x4c>;
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
2021-12-19 21:56 ` Heiko Stübner
@ 2021-12-19 22:14 ` Rob Herring
-1 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2021-12-19 22:14 UTC (permalink / raw)
To: Heiko Stübner
Cc: Vincent Pelletier, linux-riscv, Paul Walmsley, Albert Ou,
Krzysztof Kozlowski, qiuwenbo, devicetree, linux-kernel,
David Abdurachmanov, Palmer Dabbelt
On Sun, Dec 19, 2021 at 3:57 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt:
> > On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> > > Provides monitoring of core voltage and current:
> > > tps544b20-i2c-0-1e
> > > Adapter: i2c-ocores
> > > vout1: 906.00 mV
> > > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> > > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
> > >
> > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> > >
> > > ---
> > > Note: checkpatch.pl complains about undocumented devicetree binding,
> > > which is fixed by:
> > > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
> > >
> > > Changes since v2:
> > > - Fix end-of-commit-message separator so change lists do not end up in them.
> > > Changes since v1:
> > > - Added missing "ti," prefix in compatible string.
> > > - Remove trailing "." on subject line.
> > > - Rename tree node.
> >
> > I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
> > TI DC-DC converters"), so I'm going to hold off on this one until the
> > bindings land.
>
> Can't this patch then simply go into your for-next branch then?
Yes.
> The split is most times binding goes through the driver-tree
> (or Rob's dt tree) and the dts patch through an arch or soc tree.
>
> But in general once a maintainer accepts the binding it is ok
> to also apply the dts patch for the same cycle (aka merge window)
> the binding will be in.
Until there's issues with schema warnings showing up in specific
branches, going thru different trees isn't an issue. There's a lot of
warnings to fix first.
Rob
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 4/6] riscv: dts: sifive unmatched: Expose the FU740 core supply regulator
@ 2021-12-19 22:14 ` Rob Herring
0 siblings, 0 replies; 28+ messages in thread
From: Rob Herring @ 2021-12-19 22:14 UTC (permalink / raw)
To: Heiko Stübner
Cc: Vincent Pelletier, linux-riscv, Paul Walmsley, Albert Ou,
Krzysztof Kozlowski, qiuwenbo, devicetree, linux-kernel,
David Abdurachmanov, Palmer Dabbelt
On Sun, Dec 19, 2021 at 3:57 PM Heiko Stübner <heiko@sntech.de> wrote:
>
> Am Freitag, 17. Dezember 2021, 06:35:00 CET schrieb Palmer Dabbelt:
> > On Fri, 19 Nov 2021 14:55:40 PST (-0800), plr.vincent@gmail.com wrote:
> > > Provides monitoring of core voltage and current:
> > > tps544b20-i2c-0-1e
> > > Adapter: i2c-ocores
> > > vout1: 906.00 mV
> > > temp1: -40.0°C (high = +125.0°C, crit = +150.0°C)
> > > iout1: 5.06 A (max = +20.00 A, crit max = +26.00 A)
> > >
> > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> > >
> > > ---
> > > Note: checkpatch.pl complains about undocumented devicetree binding,
> > > which is fixed by:
> > > https://lore.kernel.org/linux-devicetree/20211116110207.68494-1-krzysztof.kozlowski@canonical.com/T/#u
> > >
> > > Changes since v2:
> > > - Fix end-of-commit-message separator so change lists do not end up in them.
> > > Changes since v1:
> > > - Added missing "ti," prefix in compatible string.
> > > - Remove trailing "." on subject line.
> > > - Rename tree node.
> >
> > I see this in Rob's for-next as 761de79adc2c ("dt-bindings: hwmon: add
> > TI DC-DC converters"), so I'm going to hold off on this one until the
> > bindings land.
>
> Can't this patch then simply go into your for-next branch then?
Yes.
> The split is most times binding goes through the driver-tree
> (or Rob's dt tree) and the dts patch through an arch or soc tree.
>
> But in general once a maintainer accepts the binding it is ok
> to also apply the dts patch for the same cycle (aka merge window)
> the binding will be in.
Until there's issues with schema warnings showing up in specific
branches, going thru different trees isn't an issue. There's a lot of
warnings to fix first.
Rob
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-19 22:55 ` Vincent Pelletier
-1 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
The existing values are rejected by the da9063 regulator driver, as they
are unachievable with the declared chip setup (non-merged vcore and bmem
are unable to provide the declared curent).
Fix voltages to match rev3 schematics, which also matches their boot-up
configuration within the chip's available precision.
Declare bcore1/bcore2 and bmem/bio as merged.
Set ldo09 and ldo10 as always-on as their consumers are not declared but
exist.
Drop ldo current limits as there is no current limit feature for these
regulators in the DA9063. Fixes warnings like:
DA9063_LDO3: Operation of current configuration missing
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
.../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
1 file changed, 24 insertions(+), 60 deletions(-)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 6e7775fdae32..1abad0eec02e 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -93,47 +93,31 @@ wdt {
};
regulators {
- vdd_bcore1: bcore1 {
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <900000>;
- regulator-min-microamp = <5000000>;
- regulator-max-microamp = <5000000>;
- regulator-always-on;
- };
-
- vdd_bcore2: bcore2 {
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <900000>;
- regulator-min-microamp = <5000000>;
- regulator-max-microamp = <5000000>;
+ vdd_bcore: bcores-merged {
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-min-microamp = <4800000>;
+ regulator-max-microamp = <4800000>;
regulator-always-on;
};
vdd_bpro: bpro {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <2500000>;
- regulator-max-microamp = <2500000>;
+ regulator-min-microamp = <2400000>;
+ regulator-max-microamp = <2400000>;
regulator-always-on;
};
vdd_bperi: bperi {
- regulator-min-microvolt = <1050000>;
- regulator-max-microvolt = <1050000>;
+ regulator-min-microvolt = <1060000>;
+ regulator-max-microvolt = <1060000>;
regulator-min-microamp = <1500000>;
regulator-max-microamp = <1500000>;
regulator-always-on;
};
- vdd_bmem: bmem {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-min-microamp = <3000000>;
- regulator-max-microamp = <3000000>;
- regulator-always-on;
- };
-
- vdd_bio: bio {
+ vdd_bmem_bio: bmem-bio-merged {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
regulator-min-microamp = <3000000>;
@@ -144,86 +128,66 @@ vdd_bio: bio {
vdd_ldo1: ldo1 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <100000>;
- regulator-max-microamp = <100000>;
regulator-always-on;
};
vdd_ldo2: ldo2 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
regulator-always-on;
};
vdd_ldo3: ldo3 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo4: ldo4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <2500000>;
regulator-always-on;
};
vdd_ldo5: ldo5 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <100000>;
- regulator-max-microamp = <100000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo6: ldo6 {
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-always-on;
};
vdd_ldo7: ldo7 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo8: ldo8 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ld09: ldo9 {
regulator-min-microvolt = <1050000>;
regulator-max-microvolt = <1050000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-always-on;
};
vdd_ldo10: ldo10 {
regulator-min-microvolt = <1000000>;
regulator-max-microvolt = <1000000>;
- regulator-min-microamp = <300000>;
- regulator-max-microamp = <300000>;
+ regulator-always-on;
};
vdd_ldo11: ldo11 {
regulator-min-microvolt = <2500000>;
regulator-max-microvolt = <2500000>;
- regulator-min-microamp = <300000>;
- regulator-max-microamp = <300000>;
regulator-always-on;
};
};
--
2.33.1
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
The existing values are rejected by the da9063 regulator driver, as they
are unachievable with the declared chip setup (non-merged vcore and bmem
are unable to provide the declared curent).
Fix voltages to match rev3 schematics, which also matches their boot-up
configuration within the chip's available precision.
Declare bcore1/bcore2 and bmem/bio as merged.
Set ldo09 and ldo10 as always-on as their consumers are not declared but
exist.
Drop ldo current limits as there is no current limit feature for these
regulators in the DA9063. Fixes warnings like:
DA9063_LDO3: Operation of current configuration missing
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
---
.../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
1 file changed, 24 insertions(+), 60 deletions(-)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 6e7775fdae32..1abad0eec02e 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -93,47 +93,31 @@ wdt {
};
regulators {
- vdd_bcore1: bcore1 {
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <900000>;
- regulator-min-microamp = <5000000>;
- regulator-max-microamp = <5000000>;
- regulator-always-on;
- };
-
- vdd_bcore2: bcore2 {
- regulator-min-microvolt = <900000>;
- regulator-max-microvolt = <900000>;
- regulator-min-microamp = <5000000>;
- regulator-max-microamp = <5000000>;
+ vdd_bcore: bcores-merged {
+ regulator-min-microvolt = <1050000>;
+ regulator-max-microvolt = <1050000>;
+ regulator-min-microamp = <4800000>;
+ regulator-max-microamp = <4800000>;
regulator-always-on;
};
vdd_bpro: bpro {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <2500000>;
- regulator-max-microamp = <2500000>;
+ regulator-min-microamp = <2400000>;
+ regulator-max-microamp = <2400000>;
regulator-always-on;
};
vdd_bperi: bperi {
- regulator-min-microvolt = <1050000>;
- regulator-max-microvolt = <1050000>;
+ regulator-min-microvolt = <1060000>;
+ regulator-max-microvolt = <1060000>;
regulator-min-microamp = <1500000>;
regulator-max-microamp = <1500000>;
regulator-always-on;
};
- vdd_bmem: bmem {
- regulator-min-microvolt = <1200000>;
- regulator-max-microvolt = <1200000>;
- regulator-min-microamp = <3000000>;
- regulator-max-microamp = <3000000>;
- regulator-always-on;
- };
-
- vdd_bio: bio {
+ vdd_bmem_bio: bmem-bio-merged {
regulator-min-microvolt = <1200000>;
regulator-max-microvolt = <1200000>;
regulator-min-microamp = <3000000>;
@@ -144,86 +128,66 @@ vdd_bio: bio {
vdd_ldo1: ldo1 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <100000>;
- regulator-max-microamp = <100000>;
regulator-always-on;
};
vdd_ldo2: ldo2 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
regulator-always-on;
};
vdd_ldo3: ldo3 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo4: ldo4 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <2500000>;
+ regulator-max-microvolt = <2500000>;
regulator-always-on;
};
vdd_ldo5: ldo5 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <100000>;
- regulator-max-microamp = <100000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo6: ldo6 {
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
regulator-always-on;
};
vdd_ldo7: ldo7 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ldo8: ldo8 {
- regulator-min-microvolt = <1800000>;
- regulator-max-microvolt = <1800000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-always-on;
};
vdd_ld09: ldo9 {
regulator-min-microvolt = <1050000>;
regulator-max-microvolt = <1050000>;
- regulator-min-microamp = <200000>;
- regulator-max-microamp = <200000>;
+ regulator-always-on;
};
vdd_ldo10: ldo10 {
regulator-min-microvolt = <1000000>;
regulator-max-microvolt = <1000000>;
- regulator-min-microamp = <300000>;
- regulator-max-microamp = <300000>;
+ regulator-always-on;
};
vdd_ldo11: ldo11 {
regulator-min-microvolt = <2500000>;
regulator-max-microvolt = <2500000>;
- regulator-min-microamp = <300000>;
- regulator-max-microamp = <300000>;
regulator-always-on;
};
};
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-12-02 21:42 ` Palmer Dabbelt
-1 siblings, 0 replies; 28+ messages in thread
From: Palmer Dabbelt @ 2021-12-02 21:42 UTC (permalink / raw)
To: plr.vincent
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov
On Fri, 19 Nov 2021 14:55:41 PST (-0800), plr.vincent@gmail.com wrote:
> The existing values are rejected by the da9063 regulator driver, as they
> are unachievable with the declared chip setup (non-merged vcore and bmem
> are unable to provide the declared curent).
>
> Fix voltages to match rev3 schematics, which also matches their boot-up
There's a few references to rev 3 here. I'm not sure if that means we
should have multiple device trees -- this one seems pretty benign, but
some of the regulator stuff worries me there, where anything rev 3
specific might not be safe on other revisions.
Did any previous revisions make it out of the lab?
> configuration within the chip's available precision.
> Declare bcore1/bcore2 and bmem/bio as merged.
> Set ldo09 and ldo10 as always-on as their consumers are not declared but
> exist.
> Drop ldo current limits as there is no current limit feature for these
> regulators in the DA9063. Fixes warnings like:
> DA9063_LDO3: Operation of current configuration missing
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> ---
> .../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
> 1 file changed, 24 insertions(+), 60 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 6e7775fdae32..1abad0eec02e 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -93,47 +93,31 @@ wdt {
> };
>
> regulators {
> - vdd_bcore1: bcore1 {
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <900000>;
> - regulator-min-microamp = <5000000>;
> - regulator-max-microamp = <5000000>;
> - regulator-always-on;
> - };
> -
> - vdd_bcore2: bcore2 {
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <900000>;
> - regulator-min-microamp = <5000000>;
> - regulator-max-microamp = <5000000>;
> + vdd_bcore: bcores-merged {
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + regulator-min-microamp = <4800000>;
> + regulator-max-microamp = <4800000>;
> regulator-always-on;
> };
>
> vdd_bpro: bpro {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <2500000>;
> - regulator-max-microamp = <2500000>;
> + regulator-min-microamp = <2400000>;
> + regulator-max-microamp = <2400000>;
> regulator-always-on;
> };
>
> vdd_bperi: bperi {
> - regulator-min-microvolt = <1050000>;
> - regulator-max-microvolt = <1050000>;
> + regulator-min-microvolt = <1060000>;
> + regulator-max-microvolt = <1060000>;
> regulator-min-microamp = <1500000>;
> regulator-max-microamp = <1500000>;
> regulator-always-on;
> };
>
> - vdd_bmem: bmem {
> - regulator-min-microvolt = <1200000>;
> - regulator-max-microvolt = <1200000>;
> - regulator-min-microamp = <3000000>;
> - regulator-max-microamp = <3000000>;
> - regulator-always-on;
> - };
> -
> - vdd_bio: bio {
> + vdd_bmem_bio: bmem-bio-merged {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> regulator-min-microamp = <3000000>;
> @@ -144,86 +128,66 @@ vdd_bio: bio {
> vdd_ldo1: ldo1 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <100000>;
> - regulator-max-microamp = <100000>;
> regulator-always-on;
> };
>
> vdd_ldo2: ldo2 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> regulator-always-on;
> };
>
> vdd_ldo3: ldo3 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo4: ldo4 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> regulator-always-on;
> };
>
> vdd_ldo5: ldo5 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <100000>;
> - regulator-max-microamp = <100000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo6: ldo6 {
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> regulator-always-on;
> };
>
> vdd_ldo7: ldo7 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo8: ldo8 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ld09: ldo9 {
> regulator-min-microvolt = <1050000>;
> regulator-max-microvolt = <1050000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-always-on;
> };
>
> vdd_ldo10: ldo10 {
> regulator-min-microvolt = <1000000>;
> regulator-max-microvolt = <1000000>;
> - regulator-min-microamp = <300000>;
> - regulator-max-microamp = <300000>;
> + regulator-always-on;
> };
>
> vdd_ldo11: ldo11 {
> regulator-min-microvolt = <2500000>;
> regulator-max-microvolt = <2500000>;
> - regulator-min-microamp = <300000>;
> - regulator-max-microamp = <300000>;
> regulator-always-on;
> };
> };
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
@ 2021-12-02 21:42 ` Palmer Dabbelt
0 siblings, 0 replies; 28+ messages in thread
From: Palmer Dabbelt @ 2021-12-02 21:42 UTC (permalink / raw)
To: plr.vincent
Cc: robh+dt, Paul Walmsley, aou, krzysztof.kozlowski, qiuwenbo,
devicetree, linux-riscv, linux-kernel, david.abdurachmanov
On Fri, 19 Nov 2021 14:55:41 PST (-0800), plr.vincent@gmail.com wrote:
> The existing values are rejected by the da9063 regulator driver, as they
> are unachievable with the declared chip setup (non-merged vcore and bmem
> are unable to provide the declared curent).
>
> Fix voltages to match rev3 schematics, which also matches their boot-up
There's a few references to rev 3 here. I'm not sure if that means we
should have multiple device trees -- this one seems pretty benign, but
some of the regulator stuff worries me there, where anything rev 3
specific might not be safe on other revisions.
Did any previous revisions make it out of the lab?
> configuration within the chip's available precision.
> Declare bcore1/bcore2 and bmem/bio as merged.
> Set ldo09 and ldo10 as always-on as their consumers are not declared but
> exist.
> Drop ldo current limits as there is no current limit feature for these
> regulators in the DA9063. Fixes warnings like:
> DA9063_LDO3: Operation of current configuration missing
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> ---
> .../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
> 1 file changed, 24 insertions(+), 60 deletions(-)
>
> diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> index 6e7775fdae32..1abad0eec02e 100644
> --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> @@ -93,47 +93,31 @@ wdt {
> };
>
> regulators {
> - vdd_bcore1: bcore1 {
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <900000>;
> - regulator-min-microamp = <5000000>;
> - regulator-max-microamp = <5000000>;
> - regulator-always-on;
> - };
> -
> - vdd_bcore2: bcore2 {
> - regulator-min-microvolt = <900000>;
> - regulator-max-microvolt = <900000>;
> - regulator-min-microamp = <5000000>;
> - regulator-max-microamp = <5000000>;
> + vdd_bcore: bcores-merged {
> + regulator-min-microvolt = <1050000>;
> + regulator-max-microvolt = <1050000>;
> + regulator-min-microamp = <4800000>;
> + regulator-max-microamp = <4800000>;
> regulator-always-on;
> };
>
> vdd_bpro: bpro {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <2500000>;
> - regulator-max-microamp = <2500000>;
> + regulator-min-microamp = <2400000>;
> + regulator-max-microamp = <2400000>;
> regulator-always-on;
> };
>
> vdd_bperi: bperi {
> - regulator-min-microvolt = <1050000>;
> - regulator-max-microvolt = <1050000>;
> + regulator-min-microvolt = <1060000>;
> + regulator-max-microvolt = <1060000>;
> regulator-min-microamp = <1500000>;
> regulator-max-microamp = <1500000>;
> regulator-always-on;
> };
>
> - vdd_bmem: bmem {
> - regulator-min-microvolt = <1200000>;
> - regulator-max-microvolt = <1200000>;
> - regulator-min-microamp = <3000000>;
> - regulator-max-microamp = <3000000>;
> - regulator-always-on;
> - };
> -
> - vdd_bio: bio {
> + vdd_bmem_bio: bmem-bio-merged {
> regulator-min-microvolt = <1200000>;
> regulator-max-microvolt = <1200000>;
> regulator-min-microamp = <3000000>;
> @@ -144,86 +128,66 @@ vdd_bio: bio {
> vdd_ldo1: ldo1 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <100000>;
> - regulator-max-microamp = <100000>;
> regulator-always-on;
> };
>
> vdd_ldo2: ldo2 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> regulator-always-on;
> };
>
> vdd_ldo3: ldo3 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo4: ldo4 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> regulator-always-on;
> };
>
> vdd_ldo5: ldo5 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <100000>;
> - regulator-max-microamp = <100000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo6: ldo6 {
> - regulator-min-microvolt = <3300000>;
> - regulator-max-microvolt = <3300000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> regulator-always-on;
> };
>
> vdd_ldo7: ldo7 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ldo8: ldo8 {
> - regulator-min-microvolt = <1800000>;
> - regulator-max-microvolt = <1800000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> regulator-always-on;
> };
>
> vdd_ld09: ldo9 {
> regulator-min-microvolt = <1050000>;
> regulator-max-microvolt = <1050000>;
> - regulator-min-microamp = <200000>;
> - regulator-max-microamp = <200000>;
> + regulator-always-on;
> };
>
> vdd_ldo10: ldo10 {
> regulator-min-microvolt = <1000000>;
> regulator-max-microvolt = <1000000>;
> - regulator-min-microamp = <300000>;
> - regulator-max-microamp = <300000>;
> + regulator-always-on;
> };
>
> vdd_ldo11: ldo11 {
> regulator-min-microvolt = <2500000>;
> regulator-max-microvolt = <2500000>;
> - regulator-min-microamp = <300000>;
> - regulator-max-microamp = <300000>;
> regulator-always-on;
> };
> };
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
2021-12-02 21:42 ` Palmer Dabbelt
@ 2021-12-03 3:55 ` David Abdurachmanov
-1 siblings, 0 replies; 28+ messages in thread
From: David Abdurachmanov @ 2021-12-03 3:55 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: plr.vincent, Rob Herring, Paul Walmsley, Albert Ou,
krzysztof.kozlowski, qiuwenbo, devicetree, linux-riscv,
linux-kernel@vger.kernel.org List, David Abdurachmanov
"
On Thu, Dec 2, 2021 at 11:45 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Fri, 19 Nov 2021 14:55:41 PST (-0800), plr.vincent@gmail.com wrote:
> > The existing values are rejected by the da9063 regulator driver, as they
> > are unachievable with the declared chip setup (non-merged vcore and bmem
> > are unable to provide the declared curent).
> >
> > Fix voltages to match rev3 schematics, which also matches their boot-up
>
> There's a few references to rev 3 here. I'm not sure if that means we
> should have multiple device trees -- this one seems pretty benign, but
> some of the regulator stuff worries me there, where anything rev 3
> specific might not be safe on other revisions.
As I mentioned some time before there is no such thing as Unmatched "A00".
The production boards is:
PCB revision: 3
BOM revision: B
BOM variant: 0
Or "3B0".
There are a few "3A0" boards out in the wild, but the changes are
minimal and the same DT applies.
>
> Did any previous revisions make it out of the lab?
>
> > configuration within the chip's available precision.
> > Declare bcore1/bcore2 and bmem/bio as merged.
> > Set ldo09 and ldo10 as always-on as their consumers are not declared but
> > exist.
> > Drop ldo current limits as there is no current limit feature for these
> > regulators in the DA9063. Fixes warnings like:
> > DA9063_LDO3: Operation of current configuration missing
> >
> > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> >
> > ---
> > Changes since v2:
> > - Fix end-of-commit-message separator so change lists do not end up in them.
> > Changes since v1:
> > - Remove trailing "." on subject line.
> > ---
> > .../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
> > 1 file changed, 24 insertions(+), 60 deletions(-)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 6e7775fdae32..1abad0eec02e 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -93,47 +93,31 @@ wdt {
> > };
> >
> > regulators {
> > - vdd_bcore1: bcore1 {
> > - regulator-min-microvolt = <900000>;
> > - regulator-max-microvolt = <900000>;
> > - regulator-min-microamp = <5000000>;
> > - regulator-max-microamp = <5000000>;
> > - regulator-always-on;
> > - };
> > -
> > - vdd_bcore2: bcore2 {
> > - regulator-min-microvolt = <900000>;
> > - regulator-max-microvolt = <900000>;
> > - regulator-min-microamp = <5000000>;
> > - regulator-max-microamp = <5000000>;
> > + vdd_bcore: bcores-merged {
> > + regulator-min-microvolt = <1050000>;
> > + regulator-max-microvolt = <1050000>;
> > + regulator-min-microamp = <4800000>;
> > + regulator-max-microamp = <4800000>;
> > regulator-always-on;
> > };
> >
> > vdd_bpro: bpro {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <2500000>;
> > - regulator-max-microamp = <2500000>;
> > + regulator-min-microamp = <2400000>;
> > + regulator-max-microamp = <2400000>;
> > regulator-always-on;
> > };
> >
> > vdd_bperi: bperi {
> > - regulator-min-microvolt = <1050000>;
> > - regulator-max-microvolt = <1050000>;
> > + regulator-min-microvolt = <1060000>;
> > + regulator-max-microvolt = <1060000>;
> > regulator-min-microamp = <1500000>;
> > regulator-max-microamp = <1500000>;
> > regulator-always-on;
> > };
> >
> > - vdd_bmem: bmem {
> > - regulator-min-microvolt = <1200000>;
> > - regulator-max-microvolt = <1200000>;
> > - regulator-min-microamp = <3000000>;
> > - regulator-max-microamp = <3000000>;
> > - regulator-always-on;
> > - };
> > -
> > - vdd_bio: bio {
> > + vdd_bmem_bio: bmem-bio-merged {
> > regulator-min-microvolt = <1200000>;
> > regulator-max-microvolt = <1200000>;
> > regulator-min-microamp = <3000000>;
> > @@ -144,86 +128,66 @@ vdd_bio: bio {
> > vdd_ldo1: ldo1 {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <100000>;
> > - regulator-max-microamp = <100000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo2: ldo2 {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo3: ldo3 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo4: ldo4 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <2500000>;
> > + regulator-max-microvolt = <2500000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo5: ldo5 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <100000>;
> > - regulator-max-microamp = <100000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo6: ldo6 {
> > - regulator-min-microvolt = <3300000>;
> > - regulator-max-microvolt = <3300000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo7: ldo7 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo8: ldo8 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ld09: ldo9 {
> > regulator-min-microvolt = <1050000>;
> > regulator-max-microvolt = <1050000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-always-on;
> > };
> >
> > vdd_ldo10: ldo10 {
> > regulator-min-microvolt = <1000000>;
> > regulator-max-microvolt = <1000000>;
> > - regulator-min-microamp = <300000>;
> > - regulator-max-microamp = <300000>;
> > + regulator-always-on;
> > };
> >
> > vdd_ldo11: ldo11 {
> > regulator-min-microvolt = <2500000>;
> > regulator-max-microvolt = <2500000>;
> > - regulator-min-microamp = <300000>;
> > - regulator-max-microamp = <300000>;
> > regulator-always-on;
> > };
> > };
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread* Re: [PATCH v3 5/6] riscv: dts: sifive unmatched: Fix regulator for board rev3
@ 2021-12-03 3:55 ` David Abdurachmanov
0 siblings, 0 replies; 28+ messages in thread
From: David Abdurachmanov @ 2021-12-03 3:55 UTC (permalink / raw)
To: Palmer Dabbelt
Cc: plr.vincent, Rob Herring, Paul Walmsley, Albert Ou,
krzysztof.kozlowski, qiuwenbo, devicetree, linux-riscv,
linux-kernel@vger.kernel.org List, David Abdurachmanov
"
On Thu, Dec 2, 2021 at 11:45 PM Palmer Dabbelt <palmer@dabbelt.com> wrote:
>
> On Fri, 19 Nov 2021 14:55:41 PST (-0800), plr.vincent@gmail.com wrote:
> > The existing values are rejected by the da9063 regulator driver, as they
> > are unachievable with the declared chip setup (non-merged vcore and bmem
> > are unable to provide the declared curent).
> >
> > Fix voltages to match rev3 schematics, which also matches their boot-up
>
> There's a few references to rev 3 here. I'm not sure if that means we
> should have multiple device trees -- this one seems pretty benign, but
> some of the regulator stuff worries me there, where anything rev 3
> specific might not be safe on other revisions.
As I mentioned some time before there is no such thing as Unmatched "A00".
The production boards is:
PCB revision: 3
BOM revision: B
BOM variant: 0
Or "3B0".
There are a few "3A0" boards out in the wild, but the changes are
minimal and the same DT applies.
>
> Did any previous revisions make it out of the lab?
>
> > configuration within the chip's available precision.
> > Declare bcore1/bcore2 and bmem/bio as merged.
> > Set ldo09 and ldo10 as always-on as their consumers are not declared but
> > exist.
> > Drop ldo current limits as there is no current limit feature for these
> > regulators in the DA9063. Fixes warnings like:
> > DA9063_LDO3: Operation of current configuration missing
> >
> > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
> >
> > ---
> > Changes since v2:
> > - Fix end-of-commit-message separator so change lists do not end up in them.
> > Changes since v1:
> > - Remove trailing "." on subject line.
> > ---
> > .../boot/dts/sifive/hifive-unmatched-a00.dts | 84 ++++++-------------
> > 1 file changed, 24 insertions(+), 60 deletions(-)
> >
> > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > index 6e7775fdae32..1abad0eec02e 100644
> > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
> > @@ -93,47 +93,31 @@ wdt {
> > };
> >
> > regulators {
> > - vdd_bcore1: bcore1 {
> > - regulator-min-microvolt = <900000>;
> > - regulator-max-microvolt = <900000>;
> > - regulator-min-microamp = <5000000>;
> > - regulator-max-microamp = <5000000>;
> > - regulator-always-on;
> > - };
> > -
> > - vdd_bcore2: bcore2 {
> > - regulator-min-microvolt = <900000>;
> > - regulator-max-microvolt = <900000>;
> > - regulator-min-microamp = <5000000>;
> > - regulator-max-microamp = <5000000>;
> > + vdd_bcore: bcores-merged {
> > + regulator-min-microvolt = <1050000>;
> > + regulator-max-microvolt = <1050000>;
> > + regulator-min-microamp = <4800000>;
> > + regulator-max-microamp = <4800000>;
> > regulator-always-on;
> > };
> >
> > vdd_bpro: bpro {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <2500000>;
> > - regulator-max-microamp = <2500000>;
> > + regulator-min-microamp = <2400000>;
> > + regulator-max-microamp = <2400000>;
> > regulator-always-on;
> > };
> >
> > vdd_bperi: bperi {
> > - regulator-min-microvolt = <1050000>;
> > - regulator-max-microvolt = <1050000>;
> > + regulator-min-microvolt = <1060000>;
> > + regulator-max-microvolt = <1060000>;
> > regulator-min-microamp = <1500000>;
> > regulator-max-microamp = <1500000>;
> > regulator-always-on;
> > };
> >
> > - vdd_bmem: bmem {
> > - regulator-min-microvolt = <1200000>;
> > - regulator-max-microvolt = <1200000>;
> > - regulator-min-microamp = <3000000>;
> > - regulator-max-microamp = <3000000>;
> > - regulator-always-on;
> > - };
> > -
> > - vdd_bio: bio {
> > + vdd_bmem_bio: bmem-bio-merged {
> > regulator-min-microvolt = <1200000>;
> > regulator-max-microvolt = <1200000>;
> > regulator-min-microamp = <3000000>;
> > @@ -144,86 +128,66 @@ vdd_bio: bio {
> > vdd_ldo1: ldo1 {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <100000>;
> > - regulator-max-microamp = <100000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo2: ldo2 {
> > regulator-min-microvolt = <1800000>;
> > regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo3: ldo3 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo4: ldo4 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <2500000>;
> > + regulator-max-microvolt = <2500000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo5: ldo5 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <100000>;
> > - regulator-max-microamp = <100000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo6: ldo6 {
> > - regulator-min-microvolt = <3300000>;
> > - regulator-max-microvolt = <3300000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo7: ldo7 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ldo8: ldo8 {
> > - regulator-min-microvolt = <1800000>;
> > - regulator-max-microvolt = <1800000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > regulator-always-on;
> > };
> >
> > vdd_ld09: ldo9 {
> > regulator-min-microvolt = <1050000>;
> > regulator-max-microvolt = <1050000>;
> > - regulator-min-microamp = <200000>;
> > - regulator-max-microamp = <200000>;
> > + regulator-always-on;
> > };
> >
> > vdd_ldo10: ldo10 {
> > regulator-min-microvolt = <1000000>;
> > regulator-max-microvolt = <1000000>;
> > - regulator-min-microamp = <300000>;
> > - regulator-max-microamp = <300000>;
> > + regulator-always-on;
> > };
> >
> > vdd_ldo11: ldo11 {
> > regulator-min-microvolt = <2500000>;
> > regulator-max-microvolt = <2500000>;
> > - regulator-min-microamp = <300000>;
> > - regulator-max-microamp = <300000>;
> > regulator-always-on;
> > };
> > };
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread
* [PATCH v3 6/6] riscv: dts: sifive unmatched: Link the tmp451 with its power supply
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-19 22:55 ` Vincent Pelletier
-1 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Fixes the following probe warning:
lm90 0-004c: Looking up vcc-supply from device tree
lm90 0-004c: Looking up vcc-supply property in node /soc/i2c@10030000/temperature-sensor@4c failed
lm90 0-004c: supply vcc not found, using dummy regulator
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
- Added a commit description.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 1abad0eec02e..1a952dec74bb 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -59,6 +59,7 @@ regulator@1e {
temperature-sensor@4c {
compatible = "ti,tmp451";
reg = <0x4c>;
+ vcc-supply = <&vdd_bpro>;
interrupt-parent = <&gpio>;
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
};
--
2.33.1
^ permalink raw reply related [flat|nested] 28+ messages in thread* [PATCH v3 6/6] riscv: dts: sifive unmatched: Link the tmp451 with its power supply
@ 2021-11-19 22:55 ` Vincent Pelletier
0 siblings, 0 replies; 28+ messages in thread
From: Vincent Pelletier @ 2021-11-19 22:55 UTC (permalink / raw)
To: Rob Herring, Paul Walmsley, Palmer Dabbelt, Albert Ou,
Krzysztof Kozlowski, Qiu Wenbo, devicetree, linux-riscv,
linux-kernel, David Abdurachmanov
Fixes the following probe warning:
lm90 0-004c: Looking up vcc-supply from device tree
lm90 0-004c: Looking up vcc-supply property in node /soc/i2c@10030000/temperature-sensor@4c failed
lm90 0-004c: supply vcc not found, using dummy regulator
Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
---
Changes since v2:
- Fix end-of-commit-message separator so change lists do not end up in them.
Changes since v1:
- Remove trailing "." on subject line.
- Added a commit description.
---
arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
index 1abad0eec02e..1a952dec74bb 100644
--- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
+++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts
@@ -59,6 +59,7 @@ regulator@1e {
temperature-sensor@4c {
compatible = "ti,tmp451";
reg = <0x4c>;
+ vcc-supply = <&vdd_bpro>;
interrupt-parent = <&gpio>;
interrupts = <6 IRQ_TYPE_LEVEL_LOW>;
};
--
2.33.1
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply related [flat|nested] 28+ messages in thread* Re: [PATCH v3 6/6] riscv: dts: sifive unmatched: Link the tmp451 with its power supply
2021-11-19 22:55 ` Vincent Pelletier
@ 2021-11-21 17:25 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:25 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Fixes the following probe warning:
> lm90 0-004c: Looking up vcc-supply from device tree
> lm90 0-004c: Looking up vcc-supply property in node /soc/i2c@10030000/temperature-sensor@4c failed
> lm90 0-004c: supply vcc not found, using dummy regulator
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> - Added a commit description.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 28+ messages in thread
* Re: [PATCH v3 6/6] riscv: dts: sifive unmatched: Link the tmp451 with its power supply
@ 2021-11-21 17:25 ` Krzysztof Kozlowski
0 siblings, 0 replies; 28+ messages in thread
From: Krzysztof Kozlowski @ 2021-11-21 17:25 UTC (permalink / raw)
To: Vincent Pelletier, Rob Herring, Paul Walmsley, Palmer Dabbelt,
Albert Ou, Qiu Wenbo, devicetree, linux-riscv, linux-kernel,
David Abdurachmanov
On 19/11/2021 23:55, Vincent Pelletier wrote:
> Fixes the following probe warning:
> lm90 0-004c: Looking up vcc-supply from device tree
> lm90 0-004c: Looking up vcc-supply property in node /soc/i2c@10030000/temperature-sensor@4c failed
> lm90 0-004c: supply vcc not found, using dummy regulator
>
> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com>
>
> ---
> Changes since v2:
> - Fix end-of-commit-message separator so change lists do not end up in them.
> Changes since v1:
> - Remove trailing "." on subject line.
> - Added a commit description.
> ---
> arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 1 +
> 1 file changed, 1 insertion(+)
>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Best regards,
Krzysztof
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
^ permalink raw reply [flat|nested] 28+ messages in thread