From: M. Braun <michael-dev@fami-braun.de>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] queue priority mapping
Date: Mon, 24 Nov 2014 10:10:28 +0100 [thread overview]
Message-ID: <5472F604.3020404@fami-braun.de> (raw)
In-Reply-To: <CAFfN3gX-Jtk2hh8tpBgvXkDgxbEjucOPevhJdYYXzt-0m-q9Dg@mail.gmail.com>
Hi,
Am 20.11.2014 um 19:00 schrieb Hubert Feurstein:
> in ath9k_init_queues are the AC levels mapped to the hardware-queues by
> this loop below. But doesn't this map the priorities in the wrong
> direction? The hardware queue 0 has the lowest priority, but is mapped to
> IEEE80211_AC_VO. And the hardware queue 3 (with higher priority) is mapped
> to IEEE80211_AC_BK. Shouldn't that be the other way around (as changed
> below) ?
I don't know about the hw priority stuff, but the change you propose
does not change the resulting data structure at all.
You'd likely need to change mac80211_qnum to be IEEE80211_NUM_ACS-1-i
(and maybe others) to change the mapping.
Regards,
M. Braun
>
> @@ -323,11 +323,12 @@ static int ath9k_init_queues(struct ath_softc *sc)
> sc->beacon.cabq = ath_txq_setup(sc, ATH9K_TX_QUEUE_CAB, 0);
> ath_cabq_update(sc);
>
> sc->tx.uapsdq = ath_txq_setup(sc, ATH9K_TX_QUEUE_UAPSD, 0);
>
> - for (i = 0; i < IEEE80211_NUM_ACS; i++) {
> + for (i = IEEE80211_NUM_ACS - 1; i >= 0; i--) {
> sc->tx.txq_map[i] = ath_txq_setup(sc, ATH9K_TX_QUEUE_DATA, i);
> sc->tx.txq_map[i]->mac80211_qnum = i;
> sc->tx.txq_max_pending[i] = ATH_MAX_QDEPTH;
> }
> return 0;
>
> Best regards
> Hubert
>
>
>
> _______________________________________________
> ath9k-devel mailing list
> ath9k-devel at lists.ath9k.org
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>
next prev parent reply other threads:[~2014-11-24 9:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 18:00 [ath9k-devel] queue priority mapping Hubert Feurstein
2014-11-24 9:10 ` M. Braun [this message]
2014-11-25 21:14 ` Hubert Feurstein
2014-11-25 21:22 ` Dave Taht
2014-11-26 7:46 ` M. Braun
2014-11-26 12:25 ` Sujith Manoharan
2014-11-27 12:04 ` Hubert Feurstein
2014-11-30 11:30 ` Thomas Hühn
2014-11-30 18:18 ` Sergey Ryazanov
2014-11-30 21:57 ` Thomas Hühn
2014-11-30 22:11 ` Sergey Ryazanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5472F604.3020404@fami-braun.de \
--to=michael-dev@fami-braun.de \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.