* [PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used
@ 2015-01-29 22:25 Rickard Strandqvist
2015-01-30 10:22 ` Ian Abbott
0 siblings, 1 reply; 2+ messages in thread
From: Rickard Strandqvist @ 2015-01-29 22:25 UTC (permalink / raw)
To: Ian Abbott, H Hartley Sweeten
Cc: Rickard Strandqvist, Greg Kroah-Hartman, Heena Sirwani, devel,
linux-kernel
Variable was assigned a value that was never used.
I have also removed all the code that thereby serves no purpose.
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
---
drivers/staging/comedi/drivers/mite.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
index ffc9e61..1e537a5 100644
--- a/drivers/staging/comedi/drivers/mite.c
+++ b/drivers/staging/comedi/drivers/mite.c
@@ -494,9 +494,7 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
unsigned mite_dma_tcr(struct mite_channel *mite_chan)
{
struct mite_struct *mite = mite_chan->mite;
- int lkar;
- lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
}
EXPORT_SYMBOL_GPL(mite_dma_tcr);
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used
2015-01-29 22:25 [PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used Rickard Strandqvist
@ 2015-01-30 10:22 ` Ian Abbott
0 siblings, 0 replies; 2+ messages in thread
From: Ian Abbott @ 2015-01-30 10:22 UTC (permalink / raw)
To: Rickard Strandqvist, H Hartley Sweeten
Cc: Greg Kroah-Hartman, Heena Sirwani, devel, linux-kernel
On 29/01/15 22:25, Rickard Strandqvist wrote:
> Variable was assigned a value that was never used.
> I have also removed all the code that thereby serves no purpose.
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> drivers/staging/comedi/drivers/mite.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/mite.c b/drivers/staging/comedi/drivers/mite.c
> index ffc9e61..1e537a5 100644
> --- a/drivers/staging/comedi/drivers/mite.c
> +++ b/drivers/staging/comedi/drivers/mite.c
> @@ -494,9 +494,7 @@ EXPORT_SYMBOL_GPL(mite_bytes_read_from_memory_ub);
> unsigned mite_dma_tcr(struct mite_channel *mite_chan)
> {
> struct mite_struct *mite = mite_chan->mite;
> - int lkar;
>
> - lkar = readl(mite->mite_io_addr + MITE_LKAR(mite_chan->channel));
> return readl(mite->mite_io_addr + MITE_TCR(mite_chan->channel));
> }
> EXPORT_SYMBOL_GPL(mite_dma_tcr);
>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-30 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-29 22:25 [PATCH v2] staging: comedi: drivers: mite: Removed variables that is never used Rickard Strandqvist
2015-01-30 10:22 ` Ian Abbott
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.