From: Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
Cc: linux-arm-msm
<linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Bjorn Andersson
<bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>,
linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Fri, 30 Jan 2015 13:37:50 -0800 [thread overview]
Message-ID: <54CBF9AE.6060902@codeaurora.org> (raw)
In-Reply-To: <B36DEAB1-2D89-4B6B-991E-C2EDBEB684D9-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
On 01/30/15 08:32, Kumar Gala wrote:
> On Jan 30, 2015, at 12:25 AM, Andy Gross <agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> wrote:
>
>> Required properties if child node exists:
>> - #address-cells: Must be 1
>> - #size-cells: Must be 1
>> - ranges: Must be present
>>
>> +Note: Each GSBI should have an alias correctly numbered in "aliases" node.
>> +
>> Properties for children:
>>
>> A GSBI controller node can contain 0 or more child nodes representing serial
>> @@ -37,6 +41,10 @@ Example for APQ8064:
>>
>> #include <dt-bindings/soc/qcom,gsbi.h>
>>
>> + aliases {
>> + gsbi4 = <&gsbi4>;
>> + };
> You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi’s for this purpose.
>
I thought cell-index was "deprecated" and referred more to things like
enumerating all the devices on a bus by assigning them a unique ID.
Aliases, on the other hand, allow us to enumerate a subset of devices
that share the same bus with other devices of different types. For
example, how would I know that a device is gsbi1 vs serial1 if they both
used cell-index and they both had the same parent node?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@codeaurora.org>
To: Kumar Gala <galak@codeaurora.org>, Andy Gross <agross@codeaurora.org>
Cc: linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@sonymobile.com>,
linux-soc@vger.kernel.org
Subject: Re: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Fri, 30 Jan 2015 13:37:50 -0800 [thread overview]
Message-ID: <54CBF9AE.6060902@codeaurora.org> (raw)
In-Reply-To: <B36DEAB1-2D89-4B6B-991E-C2EDBEB684D9@codeaurora.org>
On 01/30/15 08:32, Kumar Gala wrote:
> On Jan 30, 2015, at 12:25 AM, Andy Gross <agross@codeaurora.org> wrote:
>
>> Required properties if child node exists:
>> - #address-cells: Must be 1
>> - #size-cells: Must be 1
>> - ranges: Must be present
>>
>> +Note: Each GSBI should have an alias correctly numbered in "aliases" node.
>> +
>> Properties for children:
>>
>> A GSBI controller node can contain 0 or more child nodes representing serial
>> @@ -37,6 +41,10 @@ Example for APQ8064:
>>
>> #include <dt-bindings/soc/qcom,gsbi.h>
>>
>> + aliases {
>> + gsbi4 = <&gsbi4>;
>> + };
> You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi’s for this purpose.
>
I thought cell-index was "deprecated" and referred more to things like
enumerating all the devices on a bus by assigning them a unique ID.
Aliases, on the other hand, allow us to enumerate a subset of devices
that share the same bus with other devices of different types. For
example, how would I know that a device is gsbi1 vs serial1 if they both
used cell-index and they both had the same parent node?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing
Date: Fri, 30 Jan 2015 13:37:50 -0800 [thread overview]
Message-ID: <54CBF9AE.6060902@codeaurora.org> (raw)
In-Reply-To: <B36DEAB1-2D89-4B6B-991E-C2EDBEB684D9@codeaurora.org>
On 01/30/15 08:32, Kumar Gala wrote:
> On Jan 30, 2015, at 12:25 AM, Andy Gross <agross@codeaurora.org> wrote:
>
>> Required properties if child node exists:
>> - #address-cells: Must be 1
>> - #size-cells: Must be 1
>> - ranges: Must be present
>>
>> +Note: Each GSBI should have an alias correctly numbered in "aliases" node.
>> +
>> Properties for children:
>>
>> A GSBI controller node can contain 0 or more child nodes representing serial
>> @@ -37,6 +41,10 @@ Example for APQ8064:
>>
>> #include <dt-bindings/soc/qcom,gsbi.h>
>>
>> + aliases {
>> + gsbi4 = <&gsbi4>;
>> + };
> You appear to be using the alias name to determine a index number for the gsbi, if that is the case, than you should probably just add a cell-index node to the gsbi?s for this purpose.
>
I thought cell-index was "deprecated" and referred more to things like
enumerating all the devices on a bus by assigning them a unique ID.
Aliases, on the other hand, allow us to enumerate a subset of devices
that share the same bus with other devices of different types. For
example, how would I know that a device is gsbi1 vs serial1 if they both
used cell-index and they both had the same parent node?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-01-30 21:37 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-30 6:25 [Patch v2 0/6] GSBI CRCI Autoconfiguration Support Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` [Patch v2 1/6] soc: qcom: gsbi: Add support for ADM CRCI muxing Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 16:32 ` Kumar Gala
2015-01-30 16:32 ` Kumar Gala
[not found] ` <B36DEAB1-2D89-4B6B-991E-C2EDBEB684D9-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2015-01-30 21:37 ` Stephen Boyd [this message]
2015-01-30 21:37 ` Stephen Boyd
2015-01-30 21:37 ` Stephen Boyd
2015-01-30 21:48 ` Kumar Gala
2015-01-30 21:48 ` Kumar Gala
2015-02-03 2:05 ` Stephen Boyd
2015-02-03 2:05 ` Stephen Boyd
2015-01-30 6:25 ` [Patch v2 2/6] mfd: qcom,tcsr: Add device tree binding for TCSR Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` [Patch v2 3/6] ARM: DT: apq8064: Add TCSR support Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` [Patch v2 4/6] ARM: DT: ipq8064: " Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` [Patch v2 5/6] ARM: DT: msm8660: " Andy Gross
2015-01-30 6:25 ` Andy Gross
2015-01-30 6:25 ` [Patch v2 6/6] ARM: DT: msm8960: " Andy Gross
2015-01-30 6:25 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBF9AE.6060902@codeaurora.org \
--to=sboyd-sgv2jx0feol9jmxxk+q4oq@public.gmane.org \
--cc=agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.