All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] clocksource: davinci: avoid trailing '\n' hidden in pr_fmt()
Date: Thu, 9 Apr 2020 11:43:09 +0200	[thread overview]
Message-ID: <54def81a-5065-93d6-3397-5086f2d86994@linaro.org> (raw)
In-Reply-To: <20200409092543.14727-1-christophe.jaillet@wanadoo.fr>

On 09/04/2020 11:25, Christophe JAILLET wrote:
> pr_xxx() functions usually have '\n' at the end of the logging message.
> Here, this '\n' is added via the 'pr_fmt' macro.
> 
> In order to be more consistent with other files, use a more standard
> convention and put these '\n' back in the messages themselves and remove it
> from the pr_fmt macro.
> 
> While at it, remove a useless message in case of 'kzalloc' failure,
> especially with a __GFP_NOFAIL flag.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks

> ---
> Not sure that the __GFP_NOFAIL is relevant here.

No, it is not relevant.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

WARNING: multiple messages have this Message-ID (diff)
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>, tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] clocksource: davinci: avoid trailing '\n' hidden in pr_fmt()
Date: Thu, 09 Apr 2020 09:43:09 +0000	[thread overview]
Message-ID: <54def81a-5065-93d6-3397-5086f2d86994@linaro.org> (raw)
In-Reply-To: <20200409092543.14727-1-christophe.jaillet@wanadoo.fr>

On 09/04/2020 11:25, Christophe JAILLET wrote:
> pr_xxx() functions usually have '\n' at the end of the logging message.
> Here, this '\n' is added via the 'pr_fmt' macro.
> 
> In order to be more consistent with other files, use a more standard
> convention and put these '\n' back in the messages themselves and remove it
> from the pr_fmt macro.
> 
> While at it, remove a useless message in case of 'kzalloc' failure,
> especially with a __GFP_NOFAIL flag.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Applied, thanks

> ---
> Not sure that the __GFP_NOFAIL is relevant here.

No, it is not relevant.


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

  reply	other threads:[~2020-04-09  9:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09  9:25 [PATCH] clocksource: davinci: avoid trailing '\n' hidden in pr_fmt() Christophe JAILLET
2020-04-09  9:25 ` Christophe JAILLET
2020-04-09  9:43 ` Daniel Lezcano [this message]
2020-04-09  9:43   ` Daniel Lezcano
2020-06-01 13:11 ` [tip: timers/core] clocksource/drivers/davinci: Avoid " tip-bot2 for Christophe JAILLET

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54def81a-5065-93d6-3397-5086f2d86994@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.