All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver
Date: Mon, 20 Feb 2023 09:30:24 +0100	[thread overview]
Message-ID: <54ef0dee-30dc-3ba9-d2f7-8270204b5505@linaro.org> (raw)
In-Reply-To: <20230220061745.1973981-1-ryan_chen@aspeedtech.com>


On 20/02/2023 07:17, Ryan Chen wrote:
> This series add AST2600 i2cv2 new register set driver. The i2cv2 new
> register set have new clock divider option for more flexiable generation.

Typo: flexible

> And also have separate i2c master and slave register set for control.

Since several of my questions remained unanswered and quite frankly it's
fruitless... so let me read the commit msg directly - it's the same
device, just with different register layout. Having new compatible makes
sense, but this should be part of old binding.

Best regards,
Krzysztof


WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver
Date: Mon, 20 Feb 2023 09:30:24 +0100	[thread overview]
Message-ID: <54ef0dee-30dc-3ba9-d2f7-8270204b5505@linaro.org> (raw)
In-Reply-To: <20230220061745.1973981-1-ryan_chen@aspeedtech.com>


On 20/02/2023 07:17, Ryan Chen wrote:
> This series add AST2600 i2cv2 new register set driver. The i2cv2 new
> register set have new clock divider option for more flexiable generation.

Typo: flexible

> And also have separate i2c master and slave register set for control.

Since several of my questions remained unanswered and quite frankly it's
fruitless... so let me read the commit msg directly - it's the same
device, just with different register layout. Having new compatible makes
sense, but this should be part of old binding.

Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-02-20  8:31 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-20  6:17 [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen
2023-02-20  6:17 ` Ryan Chen
2023-02-20  6:17 ` [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Ryan Chen
2023-02-20  6:17   ` Ryan Chen
2023-02-20  8:28   ` Jeremy Kerr
2023-02-20  8:28     ` Jeremy Kerr
2023-02-20  9:50     ` Ryan Chen
2023-02-20  9:50       ` Ryan Chen
2023-02-20 10:43       ` Krzysztof Kozlowski
2023-02-20 10:43         ` Krzysztof Kozlowski
2023-02-20 11:24       ` Jeremy Kerr
2023-02-20 11:24         ` Jeremy Kerr
2023-02-21  3:32         ` Ryan Chen
2023-02-21  3:32           ` Ryan Chen
2023-02-21  9:43           ` Krzysztof Kozlowski
2023-02-21  9:43             ` Krzysztof Kozlowski
2023-02-22  1:14           ` Dhananjay Phadke
2023-02-22  1:14             ` Dhananjay Phadke
2023-02-22  1:30           ` Jeremy Kerr
2023-02-22  1:30             ` Jeremy Kerr
2023-02-20  8:35   ` Krzysztof Kozlowski
2023-02-20  8:35     ` Krzysztof Kozlowski
2023-02-21  2:43     ` Ryan Chen
2023-02-21  2:43       ` Ryan Chen
2023-02-21  9:40       ` Krzysztof Kozlowski
2023-02-21  9:40         ` Krzysztof Kozlowski
2023-02-21 10:42         ` Ryan Chen
2023-02-21 10:42           ` Ryan Chen
2023-02-21 11:04           ` Krzysztof Kozlowski
2023-02-21 11:04             ` Krzysztof Kozlowski
2023-02-22  2:59             ` Ryan Chen
2023-02-22  2:59               ` Ryan Chen
2023-02-22  8:25               ` Krzysztof Kozlowski
2023-02-22  8:25                 ` Krzysztof Kozlowski
2023-02-22 10:31                 ` Ryan Chen
2023-02-22 10:31                   ` Ryan Chen
2023-02-22 10:35                   ` Krzysztof Kozlowski
2023-02-22 10:35                     ` Krzysztof Kozlowski
2023-02-22 10:47                     ` Ryan Chen
2023-02-22 10:47                       ` Ryan Chen
2023-02-23  9:28                       ` Krzysztof Kozlowski
2023-02-23  9:28                         ` Krzysztof Kozlowski
2023-02-23 10:25                         ` Ryan Chen
2023-02-23 10:25                           ` Ryan Chen
2023-02-20  6:17 ` [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register mode driver Ryan Chen
2023-02-20  6:17   ` Ryan Chen
2023-02-20  8:43   ` Krzysztof Kozlowski
2023-02-20  8:43     ` Krzysztof Kozlowski
2023-02-20 10:44     ` Krzysztof Kozlowski
2023-02-20 10:44       ` Krzysztof Kozlowski
2023-02-22  3:36     ` Ryan Chen
2023-02-22  3:36       ` Ryan Chen
2023-02-22  8:28       ` Krzysztof Kozlowski
2023-02-22  8:28         ` Krzysztof Kozlowski
2023-02-23  0:58         ` Ryan Chen
2023-02-23  0:58           ` Ryan Chen
2023-02-23  9:30           ` Krzysztof Kozlowski
2023-02-23  9:30             ` Krzysztof Kozlowski
2023-02-20  8:30 ` Krzysztof Kozlowski [this message]
2023-02-20  8:30   ` [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Krzysztof Kozlowski
2023-02-20  9:56   ` Ryan Chen
2023-02-20  9:56     ` Ryan Chen
2023-02-20 10:35     ` Krzysztof Kozlowski
2023-02-20 10:35       ` Krzysztof Kozlowski
2023-02-21  1:12       ` Ryan Chen
2023-02-21  1:12         ` Ryan Chen
2023-02-21  9:38         ` Krzysztof Kozlowski
2023-02-21  9:38           ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54ef0dee-30dc-3ba9-d2f7-8270204b5505@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=andrew@aj.id.au \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=ryan_chen@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.