From: Ryan Chen <ryan_chen@aspeedtech.com> To: Jeremy Kerr <jk@codeconstruct.com.au>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Philipp Zabel <p.zabel@pengutronix.de>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Date: Mon, 20 Feb 2023 09:50:39 +0000 [thread overview] Message-ID: <TYZPR06MB5274714E58C319B4FE3B6E1BF2A49@TYZPR06MB5274.apcprd06.prod.outlook.com> (raw) In-Reply-To: <2141e513acc750bf26775f5b435f4dccd41244aa.camel@codeconstruct.com.au> Hello Jeremy, Thanks your review. > -----Original Message----- > From: Jeremy Kerr <jk@codeconstruct.com.au> > Sent: Monday, February 20, 2023 4:29 PM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Philipp Zabel <p.zabel@pengutronix.de>; > openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 > > Hi Ryan, > > > AST2600 support new register set for I2Cv2 controller, add bindings > > document to support driver of i2cv2 new register mode controller. > > Some comments inline: > > > + clock-frequency: > > + description: > > + Desired I2C bus clock frequency in Hz. default 100khz. > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > These are common to all i2c controllers, but I see that i2c-controller.yaml > doesn't include them (while i2c.text does). > > I assume we're OK to include these in the device bindings in the meantime. > But in that case, you may also want to include the common "smbus-alert" > property, which you consume in your driver. > Since i2c.text have multi-master, smbus-alert. I don't need those two right? > > + timeout: > > + type: boolean > > + description: Enable i2c bus timeout for master/slave (35ms) > > + > > + byte-mode: > > + type: boolean > > + description: Force i2c driver use byte mode transmit > > + > > + buff-mode: > > + type: boolean > > + description: Force i2c driver use buffer mode transmit > > These three aren't really a property of the hardware, more of the intended > driver configuration. Do they really belong in the DT? > Sorry, I am confused. This is hardware controller mode setting for each i2c transfer. So I add it in property for change different i2c transfer mode. Is my mis-understand the property setting? > [and how would a DT author know which modes to choose?] > > > + aspeed,gr: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of i2c global register node. > > We'll probably want this to be consistent with other instances of aspeed global > register references. I've used "aspeed,global-regs" in the proposed i3c binding: > > > https://lore.kernel.org/linux-devicetree/cover.1676532146.git.jk@codeconstruc > t.com.au/T/#mda2d005f77ca0c481b1f1edadb58fc1b007a5cc3 > > I'd argue that "global-regs" is a little more clear, but I'm okay with either way - > that change has been Acked but not been merged yet. > Whichever we choose though, it should be consistent. > Got it, will rename to aspeed,global-regs Best Regards, Ryan
WARNING: multiple messages have this Message-ID (diff)
From: Ryan Chen <ryan_chen@aspeedtech.com> To: Jeremy Kerr <jk@codeconstruct.com.au>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>, Philipp Zabel <p.zabel@pengutronix.de>, "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Date: Mon, 20 Feb 2023 09:50:39 +0000 [thread overview] Message-ID: <TYZPR06MB5274714E58C319B4FE3B6E1BF2A49@TYZPR06MB5274.apcprd06.prod.outlook.com> (raw) In-Reply-To: <2141e513acc750bf26775f5b435f4dccd41244aa.camel@codeconstruct.com.au> Hello Jeremy, Thanks your review. > -----Original Message----- > From: Jeremy Kerr <jk@codeconstruct.com.au> > Sent: Monday, February 20, 2023 4:29 PM > To: Ryan Chen <ryan_chen@aspeedtech.com>; Rob Herring > <robh+dt@kernel.org>; Krzysztof Kozlowski > <krzysztof.kozlowski+dt@linaro.org>; Joel Stanley <joel@jms.id.au>; Andrew > Jeffery <andrew@aj.id.au>; Philipp Zabel <p.zabel@pengutronix.de>; > openbmc@lists.ozlabs.org; linux-arm-kernel@lists.infradead.org; > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 > > Hi Ryan, > > > AST2600 support new register set for I2Cv2 controller, add bindings > > document to support driver of i2cv2 new register mode controller. > > Some comments inline: > > > + clock-frequency: > > + description: > > + Desired I2C bus clock frequency in Hz. default 100khz. > > + > > + multi-master: > > + type: boolean > > + description: > > + states that there is another master active on this bus > > These are common to all i2c controllers, but I see that i2c-controller.yaml > doesn't include them (while i2c.text does). > > I assume we're OK to include these in the device bindings in the meantime. > But in that case, you may also want to include the common "smbus-alert" > property, which you consume in your driver. > Since i2c.text have multi-master, smbus-alert. I don't need those two right? > > + timeout: > > + type: boolean > > + description: Enable i2c bus timeout for master/slave (35ms) > > + > > + byte-mode: > > + type: boolean > > + description: Force i2c driver use byte mode transmit > > + > > + buff-mode: > > + type: boolean > > + description: Force i2c driver use buffer mode transmit > > These three aren't really a property of the hardware, more of the intended > driver configuration. Do they really belong in the DT? > Sorry, I am confused. This is hardware controller mode setting for each i2c transfer. So I add it in property for change different i2c transfer mode. Is my mis-understand the property setting? > [and how would a DT author know which modes to choose?] > > > + aspeed,gr: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle of i2c global register node. > > We'll probably want this to be consistent with other instances of aspeed global > register references. I've used "aspeed,global-regs" in the proposed i3c binding: > > > https://lore.kernel.org/linux-devicetree/cover.1676532146.git.jk@codeconstruc > t.com.au/T/#mda2d005f77ca0c481b1f1edadb58fc1b007a5cc3 > > I'd argue that "global-regs" is a little more clear, but I'm okay with either way - > that change has been Acked but not been merged yet. > Whichever we choose though, it should be consistent. > Got it, will rename to aspeed,global-regs Best Regards, Ryan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-20 9:50 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-02-20 6:17 [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Ryan Chen 2023-02-20 6:17 ` Ryan Chen 2023-02-20 6:17 ` [PATCH v5 1/2] dt-bindings: i2c: Add support for ASPEED i2Cv2 Ryan Chen 2023-02-20 6:17 ` Ryan Chen 2023-02-20 8:28 ` Jeremy Kerr 2023-02-20 8:28 ` Jeremy Kerr 2023-02-20 9:50 ` Ryan Chen [this message] 2023-02-20 9:50 ` Ryan Chen 2023-02-20 10:43 ` Krzysztof Kozlowski 2023-02-20 10:43 ` Krzysztof Kozlowski 2023-02-20 11:24 ` Jeremy Kerr 2023-02-20 11:24 ` Jeremy Kerr 2023-02-21 3:32 ` Ryan Chen 2023-02-21 3:32 ` Ryan Chen 2023-02-21 9:43 ` Krzysztof Kozlowski 2023-02-21 9:43 ` Krzysztof Kozlowski 2023-02-22 1:14 ` Dhananjay Phadke 2023-02-22 1:14 ` Dhananjay Phadke 2023-02-22 1:30 ` Jeremy Kerr 2023-02-22 1:30 ` Jeremy Kerr 2023-02-20 8:35 ` Krzysztof Kozlowski 2023-02-20 8:35 ` Krzysztof Kozlowski 2023-02-21 2:43 ` Ryan Chen 2023-02-21 2:43 ` Ryan Chen 2023-02-21 9:40 ` Krzysztof Kozlowski 2023-02-21 9:40 ` Krzysztof Kozlowski 2023-02-21 10:42 ` Ryan Chen 2023-02-21 10:42 ` Ryan Chen 2023-02-21 11:04 ` Krzysztof Kozlowski 2023-02-21 11:04 ` Krzysztof Kozlowski 2023-02-22 2:59 ` Ryan Chen 2023-02-22 2:59 ` Ryan Chen 2023-02-22 8:25 ` Krzysztof Kozlowski 2023-02-22 8:25 ` Krzysztof Kozlowski 2023-02-22 10:31 ` Ryan Chen 2023-02-22 10:31 ` Ryan Chen 2023-02-22 10:35 ` Krzysztof Kozlowski 2023-02-22 10:35 ` Krzysztof Kozlowski 2023-02-22 10:47 ` Ryan Chen 2023-02-22 10:47 ` Ryan Chen 2023-02-23 9:28 ` Krzysztof Kozlowski 2023-02-23 9:28 ` Krzysztof Kozlowski 2023-02-23 10:25 ` Ryan Chen 2023-02-23 10:25 ` Ryan Chen 2023-02-20 6:17 ` [PATCH v5 2/2] i2c: aspeed: support ast2600 i2cv2 new register mode driver Ryan Chen 2023-02-20 6:17 ` Ryan Chen 2023-02-20 8:43 ` Krzysztof Kozlowski 2023-02-20 8:43 ` Krzysztof Kozlowski 2023-02-20 10:44 ` Krzysztof Kozlowski 2023-02-20 10:44 ` Krzysztof Kozlowski 2023-02-22 3:36 ` Ryan Chen 2023-02-22 3:36 ` Ryan Chen 2023-02-22 8:28 ` Krzysztof Kozlowski 2023-02-22 8:28 ` Krzysztof Kozlowski 2023-02-23 0:58 ` Ryan Chen 2023-02-23 0:58 ` Ryan Chen 2023-02-23 9:30 ` Krzysztof Kozlowski 2023-02-23 9:30 ` Krzysztof Kozlowski 2023-02-20 8:30 ` [PATCH v5 0/2] Add ASPEED AST2600 I2Cv2 controller driver Krzysztof Kozlowski 2023-02-20 8:30 ` Krzysztof Kozlowski 2023-02-20 9:56 ` Ryan Chen 2023-02-20 9:56 ` Ryan Chen 2023-02-20 10:35 ` Krzysztof Kozlowski 2023-02-20 10:35 ` Krzysztof Kozlowski 2023-02-21 1:12 ` Ryan Chen 2023-02-21 1:12 ` Ryan Chen 2023-02-21 9:38 ` Krzysztof Kozlowski 2023-02-21 9:38 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=TYZPR06MB5274714E58C319B4FE3B6E1BF2A49@TYZPR06MB5274.apcprd06.prod.outlook.com \ --to=ryan_chen@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=jk@codeconstruct.com.au \ --cc=joel@jms.id.au \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=openbmc@lists.ozlabs.org \ --cc=p.zabel@pengutronix.de \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.