All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Eric Blake <eblake@redhat.com>,
	Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com
Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com,
	tangchen@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error
Date: Mon, 13 Apr 2015 16:43:18 +0200	[thread overview]
Message-ID: <552BD606.5060406@redhat.com> (raw)
In-Reply-To: <552BD544.2030800@redhat.com>



On 13/04/2015 16:40, Eric Blake wrote:
>>>> +##
>>>> >>> +# @MEM_UNPLUG_ERROR
>>>> >>> +#
>>>> >>> +# Emitted when memory hot unplug error occurs.
>>>> >>> +#
>>>> >>> +# @device: device name
>>>> >>> +#
>>>> >>> +# @msg: Informative message
>>> >> Any reason you abbreviated instead of spelling it out as 'message'?
>> > 
>> > This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED
>> > in docs/qmp/qmp-events.txt.
> Just because existing code abbreviated does not mean that new code needs
> to copy the bad example.

To some extent it does; consistency is a good thing to have.  So I think
"msg" is okay here.

Paolo

  reply	other threads:[~2015-04-13 14:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-02  9:50 [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 2/8] acpi, mem-hotplug: add acpi_memory_slot_status() to get MemStatus Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 3/8] acpi, mem-hotplug: add unplug request cb for memory device Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 4/8] acpi, mem-hotplug: add unplug " Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 5/8] acpi: extend aml_field() to support UpdateRule Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 6/8] acpi: fix "Memory device control fields" register Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 7/8] acpi: add hardware implementation for memory hot unplug Zhu Guihua
2015-04-02  9:50 ` [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error Zhu Guihua
2015-04-10 15:37   ` Eric Blake
2015-04-13  1:56     ` Zhu Guihua
2015-04-13 14:40       ` Eric Blake
2015-04-13 14:43         ` Paolo Bonzini [this message]
2015-04-08  9:49 ` [Qemu-devel] [PATCH v6 0/8] QEMU memory hot unplug support Zhu Guihua
2015-04-08  9:52   ` Michael S. Tsirkin
2015-04-08 10:47     ` Paulo Ricardo Paz Vital
2015-04-09  1:16       ` Zhu Guihua
2015-04-09  8:28         ` Igor Mammedov
2015-04-09 10:01           ` Zhu Guihua
2015-04-10 15:17 ` Igor Mammedov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=552BD606.5060406@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=eblake@redhat.com \
    --cc=guz.fnst@cn.fujitsu.com \
    --cc=imammedo@redhat.com \
    --cc=izumi.taku@jp.fujitsu.com \
    --cc=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=tangchen@cn.fujitsu.com \
    --cc=zhugh.fnst@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.