Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error

From: Eric Blake <eblake@redhat.com>
To: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>,
	qemu-devel@nongnu.org, imammedo@redhat.com, mst@redhat.com,
	pbonzini@redhat.com
Cc: guz.fnst@cn.fujitsu.com, izumi.taku@jp.fujitsu.com,
	tangchen@cn.fujitsu.com
Subject: Re: [Qemu-devel] [PATCH v6 8/8] qmp-event: add event notification for memory hot unplug error
Date: Mon, 13 Apr 2015 08:40:04 -0600	[thread overview]
Message-ID: <552BD544.2030800@redhat.com> (raw)
In-Reply-To: <552B2247.70104@cn.fujitsu.com>

On 04/12/2015 07:56 PM, Zhu Guihua wrote:
> 
> On 04/10/2015 11:37 PM, Eric Blake wrote:
>> On 04/02/2015 03:50 AM, Zhu Guihua wrote:
>>> When memory hot unplug fails, this patch adds support to send
>>> QMP event to notify mgmt about this failure.
>>>
>>> Signed-off-by: Zhu Guihua <zhugh.fnst@cn.fujitsu.com>
>>> ---
>>>   docs/qmp/qmp-events.txt  | 17 +++++++++++++++++
>>>   hw/acpi/memory_hotplug.c | 10 +++++++++-
>>>   monitor.c                |  1 +
>>>   qapi/event.json          | 14 ++++++++++++++
>>>   trace-events             |  1 +
>>>   5 files changed, 42 insertions(+), 1 deletion(-)

>>> +##
>>> +# @MEM_UNPLUG_ERROR
>>> +#
>>> +# Emitted when memory hot unplug error occurs.
>>> +#
>>> +# @device: device name
>>> +#
>>> +# @msg: Informative message
>> Any reason you abbreviated instead of spelling it out as 'message'?
> 
> This only refer to the spelling of event BLOCK_IMAGE_CORRUPTED
> in docs/qmp/qmp-events.txt.

Just because existing code abbreviated does not mean that new code needs
to copy the bad example.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org