All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Suman Anna <s-anna@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	dt list <devicetree@vger.kernel.org>,
	linux-omap <linux-omap@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] bus: omap_l3_noc: Fix master id address decoding for OMAP5
Date: Fri, 24 Apr 2015 14:55:52 -0500	[thread overview]
Message-ID: <553A9FC8.8060405@ti.com> (raw)
In-Reply-To: <553A9F8B.7010205@ti.com>

On 04/24/2015 02:54 PM, Suman Anna wrote:
> On 04/24/2015 02:38 PM, Nishanth Menon wrote:
>> On Fri, Apr 24, 2015 at 2:10 PM, Suman Anna <s-anna@ti.com> wrote:
>>> On 04/24/2015 01:33 PM, Nishanth Menon wrote:
>>>> On 04/24/2015 12:54 PM, Suman Anna wrote:
>>
>> ...
>>>>> -static struct l3_target_data omap_l3_target_data_clk3[] = {
>>>>> -    {0x0100, "EMUSS",},
>>>>> -    {0x0300, "DEBUG SOURCE",},
>>>>> -    {0x0,   "HOST CLK3",},
>> ^^ this was HOST CLK3
>> ..
>>>>>
>>>>> +/* OMAP5 data */
>>>>> +static struct l3_target_data omap5_l3_target_data_clk3[] = {
>>>>> +    {0x0100, "L3INSTR",},
>>>>> +    {0x0300, "DEBUGSS",},
>>>>> +    {0x0,    "HOSTCLK3",},
>>>>
>>>> "HOST CLK"
>>>
>>> Why? I followed the convention used for the other two HOST CLKs for the
>>
>> so asked, if it should be HOST<space>CLK3
> 
> Aah ok, you missed the trailing number before. In anycase, this was

Sorry about that..

> intentional to match HOSTCLK1 and HOSTCLK2 on OMAP4/5. Overall, the
> names are somewhat non-standard, some use underscores and some others
> strip out the underscore and do not use any spaces in between either.
> "HOST CLK3" would be the only one to use a space for OMAP4, so I got rid
> of it, so hope that's ok with you.

would have been nice to cover that in commit message. no biggie for me.


-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] bus: omap_l3_noc: Fix master id address decoding for OMAP5
Date: Fri, 24 Apr 2015 14:55:52 -0500	[thread overview]
Message-ID: <553A9FC8.8060405@ti.com> (raw)
In-Reply-To: <553A9F8B.7010205@ti.com>

On 04/24/2015 02:54 PM, Suman Anna wrote:
> On 04/24/2015 02:38 PM, Nishanth Menon wrote:
>> On Fri, Apr 24, 2015 at 2:10 PM, Suman Anna <s-anna@ti.com> wrote:
>>> On 04/24/2015 01:33 PM, Nishanth Menon wrote:
>>>> On 04/24/2015 12:54 PM, Suman Anna wrote:
>>
>> ...
>>>>> -static struct l3_target_data omap_l3_target_data_clk3[] = {
>>>>> -    {0x0100, "EMUSS",},
>>>>> -    {0x0300, "DEBUG SOURCE",},
>>>>> -    {0x0,   "HOST CLK3",},
>> ^^ this was HOST CLK3
>> ..
>>>>>
>>>>> +/* OMAP5 data */
>>>>> +static struct l3_target_data omap5_l3_target_data_clk3[] = {
>>>>> +    {0x0100, "L3INSTR",},
>>>>> +    {0x0300, "DEBUGSS",},
>>>>> +    {0x0,    "HOSTCLK3",},
>>>>
>>>> "HOST CLK"
>>>
>>> Why? I followed the convention used for the other two HOST CLKs for the
>>
>> so asked, if it should be HOST<space>CLK3
> 
> Aah ok, you missed the trailing number before. In anycase, this was

Sorry about that..

> intentional to match HOSTCLK1 and HOSTCLK2 on OMAP4/5. Overall, the
> names are somewhat non-standard, some use underscores and some others
> strip out the underscore and do not use any spaces in between either.
> "HOST CLK3" would be the only one to use a space for OMAP4, so I got rid
> of it, so hope that's ok with you.

would have been nice to cover that in commit message. no biggie for me.


-- 
Regards,
Nishanth Menon

  reply	other threads:[~2015-04-24 19:55 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-24 17:54 [PATCH] bus: omap_l3_noc: Fix master id address decoding for OMAP5 Suman Anna
2015-04-24 17:54 ` Suman Anna
2015-04-24 18:33 ` Nishanth Menon
2015-04-24 18:33   ` Nishanth Menon
2015-04-24 19:10   ` Suman Anna
2015-04-24 19:10     ` Suman Anna
2015-04-24 19:38     ` Nishanth Menon
2015-04-24 19:38       ` Nishanth Menon
2015-04-24 19:54       ` Suman Anna
2015-04-24 19:54         ` Suman Anna
2015-04-24 19:55         ` Nishanth Menon [this message]
2015-04-24 19:55           ` Nishanth Menon
2015-05-04 16:31   ` Tony Lindgren
2015-05-04 16:31     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=553A9FC8.8060405@ti.com \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=s-anna@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.