From: Sagar Dharia <sdharia@codeaurora.org>
To: Mark Brown <broonie@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
bp@suse.de, poeschel@lemonage.de, treding@nvidia.com,
gong.chen@linux.intel.com, andreas.noever@gmail.com,
alan@linux.intel.com, mathieu.poirier@linaro.org,
daniel@ffwll.ch, oded.gabbay@amd.com, jkosina@suse.cz,
sharon.dvir1@mail.huji.ac.il, joe@perches.com,
davem@davemloft.net, james.hogan@imgtec.com,
michael.opdenacker@free-electrons.com,
daniel.thompson@linaro.org, nkaje@codeaurora.org,
kheitke@audience.com, mlocke@codeaurora.org,
agross@codeaurora.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] SLIMbus: Device management on SLIMbus
Date: Tue, 16 Jun 2015 09:22:31 -0600 [thread overview]
Message-ID: <55803F37.9050809@codeaurora.org> (raw)
In-Reply-To: <20150615105424.GJ18309@sirena.org.uk>
On 6/15/2015 4:54 AM, Mark Brown wrote:
> On Sat, Jun 13, 2015 at 11:49:16PM -0600, Sagar Dharia wrote:
Thanks for the comments. I will take care of most of the comments from
you, and Joe and upload V2 shortly.
I will also include a controller driver this time.
>
>> +void slim_ctrl_add_boarddevs(struct slim_controller *ctrl)
>> +{
> Why are these operations split?
Some slaves may choose to do expensive operations in their probes (or
wait for logical address assignment). That will delay/block controller
registration and further HW initialization of the controller.
I did not see any downside/side-effect in splitting them. I am open
however to have them combined if that's the preferred way.
Thanks
Sagar
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2015-06-16 15:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-14 5:49 [PATCH 0/3] Introduce framework for SLIMbus device drivers Sagar Dharia
2015-06-14 5:49 ` [PATCH 1/3] SLIMbus: Device management on SLIMbus Sagar Dharia
2015-06-15 10:54 ` Mark Brown
2015-06-16 15:22 ` Sagar Dharia [this message]
2015-06-17 11:45 ` Mark Brown
2015-06-17 17:10 ` Sagar Dharia
2015-06-18 21:23 ` Srinivas Kandagatla
2015-06-19 3:48 ` Sagar Dharia
2015-06-14 5:49 ` [PATCH 2/3] of/slimbus: OF helper for SLIMbus Sagar Dharia
2015-06-15 10:55 ` Mark Brown
2015-06-14 5:49 ` [PATCH 3/3] slimbus: Add messaging APIs to slimbus framework Sagar Dharia
2015-06-15 11:08 ` Mark Brown
2015-06-14 15:32 ` [PATCH 0/3] Introduce framework for SLIMbus device drivers Greg KH
2015-06-15 11:27 ` Mark Brown
[not found] <E1Z47g1-0006FM-D4@feisty.vs19.net>
2015-06-14 13:20 ` [PATCH 1/3] SLIMbus: Device management on SLIMbus Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55803F37.9050809@codeaurora.org \
--to=sdharia@codeaurora.org \
--cc=agross@codeaurora.org \
--cc=alan@linux.intel.com \
--cc=andreas.noever@gmail.com \
--cc=bp@suse.de \
--cc=broonie@kernel.org \
--cc=daniel.thompson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=gong.chen@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@imgtec.com \
--cc=jkosina@suse.cz \
--cc=joe@perches.com \
--cc=kheitke@audience.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=mlocke@codeaurora.org \
--cc=nkaje@codeaurora.org \
--cc=oded.gabbay@amd.com \
--cc=poeschel@lemonage.de \
--cc=sharon.dvir1@mail.huji.ac.il \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.