Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper

From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, edgar.iglesias@gmail.com,
	Peter Crosthwaite <crosthwaite.peter@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper
Date: Mon, 22 Jun 2015 19:31:22 +0200	[thread overview]
Message-ID: <5588466A.1030902@suse.de> (raw)
In-Reply-To: <00c96d447252bc1333e14e626611f4f5a58f9bf5.1434432813.git.crosthwaite.peter@gmail.com>

Am 16.06.2015 um 07:46 schrieb Peter Crosthwaite:
> Use the cpu_set_pc helper which will take care of CPUClass retrieval
> for us.
> 
> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
> ---
>  gdbstub.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/gdbstub.c b/gdbstub.c
> index 75563db..ceb60ac 100644
> --- a/gdbstub.c
> +++ b/gdbstub.c
> @@ -754,12 +754,9 @@ static void gdb_breakpoint_remove_all(void)
>  static void gdb_set_cpu_pc(GDBState *s, target_ulong pc)
>  {
>      CPUState *cpu = s->c_cpu;
> -    CPUClass *cc = CPU_GET_CLASS(cpu);
>  
>      cpu_synchronize_state(cpu);
> -    if (cc->set_pc) {
> -        cc->set_pc(cpu, pc);
> -    }
> +    cpu_set_pc(cpu, pc, NULL);

I believe this argument will probably go away; otherwise this should've
been &error_abort or something instead of NULL.

Regards,
Andreas

>  }
>  
>  static CPUState *find_cpu(uint32_t thread_id)
> 

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)