All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Maydell <peter.maydell@linaro.org>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
	"Peter Crosthwaite" <crosthwaitepeter@gmail.com>,
	"Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper
Date: Wed, 24 Jun 2015 11:01:30 +0100	[thread overview]
Message-ID: <CAFEAcA-N1hHEwigNR6qin3ma29ywhkXm7nFyoBLcsj1KugvrMQ@mail.gmail.com> (raw)
In-Reply-To: <CAEgOgz6DMgg6WABrAPB_273xJGaA56F44-_G2Z3Ck2zD_yi89Q@mail.gmail.com>

On 24 June 2015 at 03:50, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> On Mon, Jun 22, 2015 at 10:31 AM, Andreas Färber <afaerber@suse.de> wrote:
>> I believe this argument will probably go away; otherwise this should've
>> been &error_abort or something instead of NULL.
>>
>
> I'm not sure. As I don't see what is catching the case of a gdb 'c'
> packet for a CPU that doesn't implement set_pc. I'd rather preserve
> the existing behaviour, and have the qom wrapper do nothing if it is
> not implemented.

Well, this is one reason why every CPU needs to implement set_pc...

-- PMM

  reply	other threads:[~2015-06-24 10:01 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-16  5:46 [Qemu-devel] [PATCH v2 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders Peter Crosthwaite
2015-06-16  5:46 ` [Qemu-devel] [PATCH v2 1/4] qom: cpu: Add wrapper to the set-pc hook Peter Crosthwaite
2015-06-16 11:29   ` Peter Maydell
2015-06-22 17:27   ` Andreas Färber
2015-06-16  5:46 ` [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper Peter Crosthwaite
2015-06-22 17:31   ` Andreas Färber
2015-06-24  2:50     ` Peter Crosthwaite
2015-06-24 10:01       ` Peter Maydell [this message]
2015-06-24 17:04         ` Peter Crosthwaite
2015-06-24 17:16           ` Andreas Färber
2015-06-24 17:28             ` Peter Crosthwaite
2015-06-24 19:09             ` Peter Maydell
2015-06-16  5:46 ` [Qemu-devel] [PATCH v2 3/4] arm: boot: Use cpu_set_pc Peter Crosthwaite
2015-06-16 11:32   ` Peter Maydell
2015-06-22 17:33     ` Andreas Färber
2015-06-16  5:46 ` [Qemu-devel] [PATCH v2 4/4] microblaze: " Peter Crosthwaite
2015-06-16 11:33   ` Peter Maydell
2015-06-16 15:38     ` Peter Crosthwaite
2015-06-22 17:36   ` Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFEAcA-N1hHEwigNR6qin3ma29ywhkXm7nFyoBLcsj1KugvrMQ@mail.gmail.com \
    --to=peter.maydell@linaro.org \
    --cc=afaerber@suse.de \
    --cc=crosthwaite.peter@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=edgar.iglesias@gmail.com \
    --cc=peter.crosthwaite@xilinx.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.