From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Peter Crosthwaite <crosthwaite.peter@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] arm: boot: Use cpu_set_pc
Date: Mon, 22 Jun 2015 19:33:10 +0200 [thread overview]
Message-ID: <558846D6.4080602@suse.de> (raw)
In-Reply-To: <CAFEAcA8J5-XdVxW9SaO3-QLffpCmnQxRnG7cU5sQ8O+S9ZJk-A@mail.gmail.com>
Am 16.06.2015 um 13:32 schrieb Peter Maydell:
> On 16 June 2015 at 06:46, Peter Crosthwaite <crosthwaitepeter@gmail.com> wrote:
>> Use cpu_set_pc across the board for setting program counters. This
>> removes instances of system level code having to reach into the CPU
>> env.
>>
>> Signed-off-by: Peter Crosthwaite <crosthwaite.peter@gmail.com>
>> ---
>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Andreas Färber <afaerber@suse.de>
>
> though you'll want to drop the &error_abort argument to
> cpu_set_pc() (see my review on patch 1).
Regards,
Andreas
--
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Dilip Upmanyu, Graham Norton; HRB
21284 (AG Nürnberg)
next prev parent reply other threads:[~2015-06-22 17:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 5:46 [Qemu-devel] [PATCH v2 0/4] qom-cpu: Wrap set_pc hook and use in bootloaders Peter Crosthwaite
2015-06-16 5:46 ` [Qemu-devel] [PATCH v2 1/4] qom: cpu: Add wrapper to the set-pc hook Peter Crosthwaite
2015-06-16 11:29 ` Peter Maydell
2015-06-22 17:27 ` Andreas Färber
2015-06-16 5:46 ` [Qemu-devel] [PATCH v2 2/4] gdbstub: Use cpu_set_pc helper Peter Crosthwaite
2015-06-22 17:31 ` Andreas Färber
2015-06-24 2:50 ` Peter Crosthwaite
2015-06-24 10:01 ` Peter Maydell
2015-06-24 17:04 ` Peter Crosthwaite
2015-06-24 17:16 ` Andreas Färber
2015-06-24 17:28 ` Peter Crosthwaite
2015-06-24 19:09 ` Peter Maydell
2015-06-16 5:46 ` [Qemu-devel] [PATCH v2 3/4] arm: boot: Use cpu_set_pc Peter Crosthwaite
2015-06-16 11:32 ` Peter Maydell
2015-06-22 17:33 ` Andreas Färber [this message]
2015-06-16 5:46 ` [Qemu-devel] [PATCH v2 4/4] microblaze: " Peter Crosthwaite
2015-06-16 11:33 ` Peter Maydell
2015-06-16 15:38 ` Peter Crosthwaite
2015-06-22 17:36 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558846D6.4080602@suse.de \
--to=afaerber@suse.de \
--cc=crosthwaite.peter@gmail.com \
--cc=crosthwaitepeter@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.