From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Paul Durrant <paul.durrant@citrix.com>, xen-devel@lists.xenproject.org
Cc: Keir Fraser <keir@xen.org>, Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v4 13/17] x86/hvm: remove HVMIO_dispatched I/O state
Date: Thu, 25 Jun 2015 13:29:49 +0100 [thread overview]
Message-ID: <558BF43D.7010108@citrix.com> (raw)
In-Reply-To: <1435145089-21999-14-git-send-email-paul.durrant@citrix.com>
On 24/06/15 12:24, Paul Durrant wrote:
> +#define HVMIO_NEED_COMPLETION(_vio) \
> + ( ((_vio)->io_state == HVMIO_awaiting_completion) && \
> + !(_vio)->io_data_is_addr && \
> + ((_vio)->io_dir == IOREQ_READ) )
Please can this be a static inline which takes a const pointer.
~Andrew
next prev parent reply other threads:[~2015-06-25 12:29 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-24 11:24 [PATCH v4 00/17] x86/hvm: I/O emulation cleanup and fix Paul Durrant
2015-06-24 11:24 ` [PATCH v4 01/17] x86/hvm: simplify hvmemul_do_io() Paul Durrant
2015-06-24 11:24 ` [PATCH v4 02/17] x86/hvm: remove hvm_io_pending() check in hvmemul_do_io() Paul Durrant
2015-06-24 11:24 ` [PATCH v4 03/17] x86/hvm: remove extraneous parameter from hvmtrace_io_assist() Paul Durrant
2015-06-24 11:24 ` [PATCH v4 04/17] x86/hvm: remove multiple open coded 'chunking' loops Paul Durrant
2015-06-24 12:33 ` Jan Beulich
2015-06-24 12:59 ` Paul Durrant
2015-06-24 13:09 ` Jan Beulich
2015-06-24 11:24 ` [PATCH v4 05/17] x86/hvm: re-name struct hvm_mmio_handler to hvm_mmio_ops Paul Durrant
2015-06-24 11:24 ` [PATCH v4 06/17] x86/hvm: unify internal portio and mmio intercepts Paul Durrant
2015-06-24 11:24 ` [PATCH v4 07/17] x86/hvm: add length to mmio check op Paul Durrant
2015-06-24 13:08 ` Jan Beulich
2015-06-24 13:14 ` Paul Durrant
2015-06-24 13:25 ` Jan Beulich
2015-06-24 13:34 ` Paul Durrant
2015-06-24 14:01 ` Jan Beulich
2015-06-25 12:21 ` Andrew Cooper
2015-06-25 12:46 ` Jan Beulich
2015-06-25 13:08 ` Paul Durrant
2015-06-25 13:29 ` Jan Beulich
2015-06-25 13:30 ` Paul Durrant
2015-06-25 13:34 ` Andrew Cooper
2015-06-25 13:36 ` Paul Durrant
2015-06-25 13:37 ` Andrew Cooper
2015-06-25 13:38 ` Paul Durrant
2015-06-25 13:46 ` Andrew Cooper
2015-06-25 13:48 ` Paul Durrant
2015-06-25 13:47 ` Jan Beulich
2015-06-25 13:52 ` Paul Durrant
2015-06-25 14:46 ` Jan Beulich
2015-06-25 14:57 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 08/17] x86/hvm: unify dpci portio intercept with standard portio intercept Paul Durrant
2015-06-24 13:46 ` Jan Beulich
2015-06-24 11:24 ` [PATCH v4 09/17] x86/hvm: unify stdvga mmio intercept with standard mmio intercept Paul Durrant
2015-06-24 13:59 ` Jan Beulich
2015-06-24 14:12 ` Paul Durrant
2015-06-24 14:30 ` Jan Beulich
2015-06-24 14:43 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 10/17] x86/hvm: revert 82ed8716b "fix direct PCI port I/O emulation retry Paul Durrant
2015-06-24 15:21 ` Jan Beulich
2015-06-24 15:23 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 11/17] x86/hvm: only call hvm_io_assist() from hvm_wait_for_io() Paul Durrant
2015-06-24 15:36 ` Jan Beulich
2015-06-24 15:50 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 12/17] x86/hvm: split I/O completion handling from state model Paul Durrant
2015-06-25 9:40 ` Jan Beulich
2015-06-25 15:59 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 13/17] x86/hvm: remove HVMIO_dispatched I/O state Paul Durrant
2015-06-24 15:52 ` Jan Beulich
2015-06-24 16:00 ` Paul Durrant
2015-06-24 16:12 ` Jan Beulich
2015-06-24 17:00 ` Paul Durrant
2015-06-25 12:29 ` Andrew Cooper [this message]
2015-06-24 11:24 ` [PATCH v4 14/17] x86/hvm: remove hvm_io_state enumeration Paul Durrant
2015-06-25 9:43 ` Jan Beulich
2015-06-25 9:46 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 15/17] x86/hvm: use ioreq_t to track in-flight state Paul Durrant
2015-06-25 9:51 ` Jan Beulich
2015-06-25 10:17 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 16/17] x86/hvm: always re-emulate I/O from a buffer Paul Durrant
2015-06-25 9:57 ` Jan Beulich
2015-06-25 10:32 ` Paul Durrant
2015-06-25 10:50 ` Jan Beulich
2015-06-25 10:52 ` Paul Durrant
2015-06-24 11:24 ` [PATCH v4 17/17] x86/hvm: track large memory mapped accesses by buffer offset Paul Durrant
2015-06-25 10:46 ` Jan Beulich
2015-06-25 10:51 ` Paul Durrant
2015-06-25 11:05 ` Jan Beulich
2015-06-25 10:55 ` Paul Durrant
2015-06-25 11:08 ` Jan Beulich
2015-06-24 12:16 ` [PATCH v4 00/17] x86/hvm: I/O emulation cleanup and fix Jan Beulich
2015-06-24 12:52 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=558BF43D.7010108@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=paul.durrant@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.