From: "majun (F)" <majun258@huawei.com> To: Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <Catalin.Marinas@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Will Deacon <Will.Deacon@arm.com>, Mark Rutland <Mark.Rutland@arm.com>, "jason@lakedaemon.net" <jason@lakedaemon.net>, "tglx@linutronix.de" <tglx@linutronix.de>, "lizefan@huawei.com" <lizefan@huawei.com>, "huxinwei@huawei.com" <huxinwei@huawei.com> Subject: Re: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt Date: Fri, 26 Jun 2015 20:04:42 +0800 [thread overview] Message-ID: <558D3FDA.6000903@huawei.com> (raw) In-Reply-To: <558D2C1A.3070702@arm.com> 在 2015/6/26 18:40, Marc Zyngier 写道: > > My opinion is that we need to be able to lookup the domain from the core > code without any of these hacks, and this is what I'm working on at the > moment. There is no way external code will be allowed to mess with the > internals of the ITS. > > For the time being, just expose the domain with a helper (you can match > it with the of_node). Do you mean add a fucntion in ITS likes below: struct irq_domain *get_its_domain(struct device_node *node) { struct its_node *its = NULL; list_for_each_entry(its, &its_nodes, entry) { if(its->msi_chip.of_node == node) break; } return (its)?its->domain:NULL; } How about add a '.match ' member in its_domain_ops just like: .match = get_its_domain; So, I can use the fucntion 'irq_find_host' in mbigne driver >In the long run, you should be able to look it up > directly from the domain list. > I think the domain list you said is 'irq_domain_list' which defined in Irqdomain.c static LIST_HEAD(irq_domain_list); Thanks!
WARNING: multiple messages have this Message-ID (diff)
From: majun258@huawei.com (majun (F)) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt Date: Fri, 26 Jun 2015 20:04:42 +0800 [thread overview] Message-ID: <558D3FDA.6000903@huawei.com> (raw) In-Reply-To: <558D2C1A.3070702@arm.com> ? 2015/6/26 18:40, Marc Zyngier ??: > > My opinion is that we need to be able to lookup the domain from the core > code without any of these hacks, and this is what I'm working on at the > moment. There is no way external code will be allowed to mess with the > internals of the ITS. > > For the time being, just expose the domain with a helper (you can match > it with the of_node). Do you mean add a fucntion in ITS likes below: struct irq_domain *get_its_domain(struct device_node *node) { struct its_node *its = NULL; list_for_each_entry(its, &its_nodes, entry) { if(its->msi_chip.of_node == node) break; } return (its)?its->domain:NULL; } How about add a '.match ' member in its_domain_ops just like: .match = get_its_domain; So, I can use the fucntion 'irq_find_host' in mbigne driver >In the long run, you should be able to look it up > directly from the domain list. > I think the domain list you said is 'irq_domain_list' which defined in Irqdomain.c static LIST_HEAD(irq_domain_list); Thanks!
next prev parent reply other threads:[~2015-06-26 12:05 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-06-12 2:49 [PATCH v2 0/3] IRQ/Gic-V3:Support Mbigen interrupt controller Ma Jun 2015-06-12 2:49 ` Ma Jun 2015-06-12 2:49 ` [PATCH v2 1/3] IRQ/Gic-V3: Add mbigen driver to support mbigen " Ma Jun 2015-06-12 2:49 ` Ma Jun 2015-06-12 2:49 ` [PATCH v2 2/3] IRQ/Gic-V3: Change arm-gic-its to support the Mbigen interrupt Ma Jun 2015-06-12 2:49 ` Ma Jun 2015-06-12 10:48 ` Thomas Gleixner 2015-06-12 10:48 ` Thomas Gleixner 2015-06-15 7:05 ` majun (F) 2015-06-15 7:05 ` majun (F) 2015-06-18 23:52 ` Thomas Gleixner 2015-06-18 23:52 ` Thomas Gleixner 2015-06-23 9:03 ` majun (F) 2015-06-23 9:03 ` majun (F) 2015-06-23 9:29 ` Thomas Gleixner 2015-06-23 9:29 ` Thomas Gleixner 2015-06-26 8:45 ` Marc Zyngier 2015-06-26 8:45 ` Marc Zyngier 2015-06-26 6:31 ` majun (F) 2015-06-26 6:31 ` majun (F) 2015-06-26 8:44 ` Marc Zyngier 2015-06-26 8:44 ` Marc Zyngier 2015-06-26 10:28 ` majun (F) 2015-06-26 10:28 ` majun (F) 2015-06-26 10:40 ` Marc Zyngier 2015-06-26 10:40 ` Marc Zyngier 2015-06-26 12:04 ` majun (F) [this message] 2015-06-26 12:04 ` majun (F) 2015-06-26 13:14 ` Marc Zyngier 2015-06-26 13:14 ` Marc Zyngier 2015-06-12 2:49 ` [PATCH v2 3/3] dt-binding:Documents the mbigen bindings Ma Jun 2015-06-12 2:49 ` Ma Jun
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=558D3FDA.6000903@huawei.com \ --to=majun258@huawei.com \ --cc=Catalin.Marinas@arm.com \ --cc=Mark.Rutland@arm.com \ --cc=Will.Deacon@arm.com \ --cc=huxinwei@huawei.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lizefan@huawei.com \ --cc=marc.zyngier@arm.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.